From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
Juanma Barranquero <lekktu@gmail.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 14734@debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Fri, 5 Jul 2013 07:50:13 -0700 (PDT) [thread overview]
Message-ID: <5c00eebb-f58f-4d6f-a648-d10fbd11d7cf@default> (raw)
In-Reply-To: <jwvd2r44bsn.fsf-monnier+emacs@gnu.org>
> > But I also agree with Drew that the current doctrings for adviced
> > functions are horrible and a big step backwards for users.
>
> Patches welcome,
The problem is not doc strings but the regression in user interaction.
Perhaps that is what Juanma meant: what the user sees via `C-h f'.
The patch for that is to revert the changes that caused the regression.
There is nothing wrong with providing a new advice mechanism, and a
better one is certainly welcome. Thank you for working on that.
There is something very wrong, however, if doing that ruins the user
interface.
Advising functions provides a Lisp feature that is usable by Lisp users.
But ALL users make use of `C-h f', and often, and the changes made to
facilitate introducing the new advice have (apparently) broken the user
experience with `C-h f'.
This is a serious regression that deserves to be taken seriously. The
code that introduced the regression should be backed out immediately, if
fixing it now would be too onerous.
next prev parent reply other threads:[~2013-07-05 14:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 17:08 bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Drew Adams
2013-06-27 18:15 ` Stefan Monnier
2013-06-27 18:40 ` Drew Adams
2013-06-28 17:39 ` Drew Adams
2013-06-28 20:44 ` Dmitry Gutov
2013-06-28 21:56 ` Drew Adams
2013-06-28 22:19 ` Michael Heerdegen
2019-09-23 21:07 ` bug#13581: " Lars Ingebrigtsen
2013-06-28 22:27 ` Michael Heerdegen
2013-06-28 23:21 ` Stefan Monnier
2013-06-29 1:37 ` Drew Adams
2013-06-29 2:09 ` Stefan Monnier
2013-06-29 2:28 ` Drew Adams
2013-06-29 3:24 ` Stefan Monnier
2013-06-29 20:29 ` Juanma Barranquero
2013-06-30 1:39 ` Stefan Monnier
2013-07-05 14:50 ` Drew Adams [this message]
2013-07-05 14:57 ` Juanma Barranquero
2013-07-05 22:44 ` Stefan Monnier
2013-07-06 1:40 ` Drew Adams
2013-07-06 9:18 ` Stefan Monnier
2013-07-06 20:22 ` Drew Adams
2013-10-20 23:27 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c00eebb-f58f-4d6f-a648-d10fbd11d7cf@default \
--to=drew.adams@oracle.com \
--cc=14734@debbugs.gnu.org \
--cc=lekktu@gmail.com \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).