unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: damien@cassou.me, 29223@debbugs.gnu.org
Cc: Nicolas Petton <nicolas@petton.fr>
Subject: bug#29223: 26.0.90; [Regression][Emacs26] Problem in network stack
Date: Wed, 8 Nov 2017 21:32:49 -0800	[thread overview]
Message-ID: <5b859e12-fab0-f288-bc7b-6da82fb6c55c@cs.ucla.edu> (raw)
In-Reply-To: <87tvy458vp.fsf@cassou.me>

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

Thanks for reporting the problem. I installed the attached patch into the 
emacs-26 branch; please give it a try.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-URL-cookie-expiration-bug.patch --]
[-- Type: text/x-patch; name="0001-Fix-URL-cookie-expiration-bug.patch", Size: 973 bytes --]

From 781f276cc12a204ec7db9ffd30d22a9a18c0fe94 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 8 Nov 2017 21:30:26 -0800
Subject: [PATCH] Fix URL cookie expiration bug

Problem reported by Damien Cassou (Bug#29223).
* lisp/url/url-cookie.el (url-cookie-expired-p):
Fix typo in previous change, which caused unexpired cookies
to be treated as expired and vice versa.
---
 lisp/url/url-cookie.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/url/url-cookie.el b/lisp/url/url-cookie.el
index 28dfced..d922033 100644
--- a/lisp/url/url-cookie.el
+++ b/lisp/url/url-cookie.el
@@ -161,7 +161,7 @@ url-cookie-expired-p
   (let ((exp (url-cookie-expires cookie)))
     (and (> (length exp) 0)
 	 (condition-case ()
-	     (time-less-p nil (date-to-time exp))
+	     (time-less-p (date-to-time exp) nil)
 	   (error nil)))))
 
 (defun url-cookie-retrieve (host &optional localpart secure)
-- 
2.7.4


  reply	other threads:[~2017-11-09  5:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  5:16 bug#29223: 26.0.90; [Regression][Emacs26] Problem in network stack Damien Cassou
2017-11-09  5:32 ` Paul Eggert [this message]
2017-11-09  6:30   ` Damien Cassou
2017-11-09  6:45     ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b859e12-fab0-f288-bc7b-6da82fb6c55c@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=29223@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=nicolas@petton.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).