unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Phil Sainty <psainty@orcon.net.nz>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 45084@debbugs.gnu.org, Richard Stallman <rms@gnu.org>,
	jidanni@jidanni.org
Subject: bug#45084: so-long mode vs. dired-view-file
Date: Mon, 07 Jun 2021 20:14:11 +1200	[thread overview]
Message-ID: <5b60e019029d510150f5bd9f2b87ddf4@webmail.orcon.net.nz> (raw)
In-Reply-To: <87y2bns2q5.fsf@gnus.org>

Hi Lars,

Thanks for this.  I've actually implemented a more general solution
with default support for the view-mode case, so I'll revert your
changes when I merge the scratch/so-long changes.

https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=scratch/so-long&id=6edeae3b4b7dd5105c9cf0dc0560d4c2c96a85bd

I don't see a problem with leaving your change in place for the interim,
though.  It doesn't handle the `so-long-revert' case, but there's no
need to address that as my changes will deal with it.


-Phil



On 2021-06-06 22:32, Lars Ingebrigtsen wrote:
> Richard Stallman <rms@gnu.org> writes:
> 
>> dired-view-file does something quite unusual: it visits a file and 
>> puts
>> it in View mode.
>> 
>> I think so-long needs to make a special case for View mode.
>> For instance, if View mode is in effect, it could (1) turn off View 
>> mode,
>> (2) switch modes however it does, then (3) reenable View mode.
> 
> It does feel a bit messy to special-case `view-mode' here, but on the
> other hand, not doing so will make the `v' command in Dired a less
> handy.
> 
> So I've gone ahead with Richard's suggestion here in Emacs 28 --
> `so-long' will now restore the view minor mode if it was switched on.






      reply	other threads:[~2021-06-07  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 12:22 bug#45084: so-long mode vs. dired-view-file 積丹尼 Dan Jacobson
2020-12-07  4:24 ` Phil Sainty
2020-12-08  5:30   ` Richard Stallman
2021-06-06 10:32     ` Lars Ingebrigtsen
2021-06-07  8:14       ` Phil Sainty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b60e019029d510150f5bd9f2b87ddf4@webmail.orcon.net.nz \
    --to=psainty@orcon.net.nz \
    --cc=45084@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).