* bug#45945: 28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction
@ 2021-01-18 1:55 Dmitry Gutov
2021-01-19 1:11 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2021-01-18 1:55 UTC (permalink / raw)
To: 45945; +Cc: juri
X-Debbugs-CC: rudalics@gmx.at, juri@linkov.net
It will be helpful to limit the height of the resulting window (either
in lines or in percentages of the parent window height). If the split
has been performed, of course.
At the moment, it can take up almost all of the parent window's height,
and that's not ideal for our use of it in
xref-show-definitions-buffer-at-bottom.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#45945: 28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction
2021-01-18 1:55 bug#45945: 28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction Dmitry Gutov
@ 2021-01-19 1:11 ` Dmitry Gutov
2021-01-19 17:41 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2021-01-19 1:11 UTC (permalink / raw)
To: 45945-done
On 18.01.2021 03:55, Dmitry Gutov wrote:
> It will be helpful to limit the height of the resulting window (either
> in lines or in percentages of the parent window height). If the split
> has been performed, of course.
Looks like I've managed that with 'window-height' alist entry set to a
function that wraps fit-window-to-buffer.
Commit 4ca808ee7a in master.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#45945: 28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction
2021-01-19 1:11 ` Dmitry Gutov
@ 2021-01-19 17:41 ` Juri Linkov
2021-01-19 19:31 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2021-01-19 17:41 UTC (permalink / raw)
To: 45945; +Cc: dgutov
>> It will be helpful to limit the height of the resulting window (either
>> in lines or in percentages of the parent window height). If the split has
>> been performed, of course.
>
> Looks like I've managed that with 'window-height' alist entry set to
> a function that wraps fit-window-to-buffer.
>
> Commit 4ca808ee7a in master.
Indeed, maybe this could be customizable. For example,
like there is the customizable variable display-buffer-alist,
a new customizable variable with a name like post-display-buffer-functions
could be used to add/remove such hooks as fit-window-to-buffer.
like temp-buffer-resize-mode does. But this should a more general feature.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#45945: 28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction
2021-01-19 17:41 ` Juri Linkov
@ 2021-01-19 19:31 ` Dmitry Gutov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2021-01-19 19:31 UTC (permalink / raw)
To: Juri Linkov, 45945
On 19.01.2021 19:41, Juri Linkov wrote:
>>> It will be helpful to limit the height of the resulting window (either
>>> in lines or in percentages of the parent window height). If the split has
>>> been performed, of course.
>>
>> Looks like I've managed that with 'window-height' alist entry set to
>> a function that wraps fit-window-to-buffer.
>>
>> Commit 4ca808ee7a in master.
>
> Indeed, maybe this could be customizable. For example,
> like there is the customizable variable display-buffer-alist,
> a new customizable variable with a name like post-display-buffer-functions
> could be used to add/remove such hooks as fit-window-to-buffer.
> like temp-buffer-resize-mode does. But this should a more general feature.
The general feature sounds interesting, but I personally have avoided
customizing even display-buffer-alist so far, and doing that with either
of the variables (the existing or the proposed one) seems pretty far
from the capabilities of an average Emacs user.
Speaking of customization, I rather wondered whether the max height
percentage in xref-show-definitions-buffer-at-bottom should be
customizable (as a float number, probably).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-19 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 1:55 bug#45945: 28.0.50; Feature request: Some kind of 'max-window-height' parameter for display-buffer-in-direction Dmitry Gutov
2021-01-19 1:11 ` Dmitry Gutov
2021-01-19 17:41 ` Juri Linkov
2021-01-19 19:31 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).