From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#37153: 26.1; some png images scrambled Date: Fri, 23 Aug 2019 12:37:12 -0700 Organization: UCLA Computer Science Department Message-ID: <5b006777-5e97-a641-6f93-83a437ca9ca7@cs.ucla.edu> References: <28732.94605.161707.23903@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E88883693D964CCD1F5989A2" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="137747"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: 37153@debbugs.gnu.org To: Roland Winkler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 21:38:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1FO0-000ZhQ-1I for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 21:38:12 +0200 Original-Received: from localhost ([::1]:33538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1FNy-0005h1-Pc for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 15:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50183) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1FNs-0005fM-Co for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 15:38:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1FNr-0001dP-Bx for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 15:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1FNr-0001dJ-98 for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 15:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1FNq-0007NB-1b for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 15:38:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <28732.94605.161707.23903@gargle.gargle.HOWL> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37153 X-GNU-PR-Package: emacs Original-Received: via spool by 37153-submit@debbugs.gnu.org id=B37153.156658904128288 (code B ref 37153); Fri, 23 Aug 2019 19:38:01 +0000 Original-Received: (at 37153) by debbugs.gnu.org; 23 Aug 2019 19:37:21 +0000 Original-Received: from localhost ([127.0.0.1]:41234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1FNB-0007MC-Bo for submit@debbugs.gnu.org; Fri, 23 Aug 2019 15:37:21 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1FN9-0007Lz-HW for 37153@debbugs.gnu.org; Fri, 23 Aug 2019 15:37:20 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EDC38160073; Fri, 23 Aug 2019 12:37:13 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id s6mXKF_6FVH3; Fri, 23 Aug 2019 12:37:13 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4029416008D; Fri, 23 Aug 2019 12:37:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WNFCKXYwP4eh; Fri, 23 Aug 2019 12:37:13 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 19176160073; Fri, 23 Aug 2019 12:37:13 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165721 Archived-At: This is a multi-part message in MIME format. --------------E88883693D964CCD1F5989A2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I didn't reproduce the problem with Emacs master on Ubuntu 18.04.3 LTS. The Emacs display agrees with the Gimp's display of that tiny image. Also, the rpng test program of the librpng 1.6.37 (the current version) also displays the image the same way. I had to patch librpng with the attached to get the test program to compile. Do you see the same problem when using Emacs master? If not, then perhaps we can just marked the bug as fixed in the next release. --------------E88883693D964CCD1F5989A2 Content-Type: text/x-patch; name="libpng.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="libpng.patch" diff -pru libpng-1.6.37/contrib/gregbook/readpng.c libpng-1.6.37-fixed/contrib/gregbook/readpng.c --- libpng-1.6.37/contrib/gregbook/readpng.c 2019-04-14 11:10:32.000000000 -0700 +++ libpng-1.6.37-fixed/contrib/gregbook/readpng.c 2019-08-23 12:14:13.106180379 -0700 @@ -266,7 +266,7 @@ uch *readpng_get_image(double display_ex /* Guard against integer overflow */ if (height > ((size_t)(-1))/rowbytes) { - fprintf(stderr, "readpng: image_data buffer would be too large\n", + fprintf(stderr, "readpng: image_data buffer would be too large\n"); return NULL; } --------------E88883693D964CCD1F5989A2--