From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Tue, 25 Apr 2023 02:45:46 +0300 Message-ID: <5ae14089-f76f-84a1-d39a-3ec9e473a0aa@gutov.dev> References: <87a5zj2vfo.fsf@gmail.com> <83pm7y6fdo.fsf@gnu.org> <47140c27-ba63-ca7b-8b9e-cc38a6f9a866@gutov.dev> <838rem636a.fsf@gnu.org> <83leil4u63.fsf@gnu.org> <8a9d0e2b-6ae2-bcdc-efd0-52a44ac862bb@gutov.dev> <83h6t94hru.fsf@gnu.org> <7676c8d2-1324-31e7-38b3-de167ecf683a@gutov.dev> <8e9bd99a-3093-3b69-8429-aa1ae6b7240d@gutov.dev> <834jp82u5c.fsf@gnu.org> <83ildo189j.fsf@gnu.org> <6e91a10e-e8bb-c7db-f6ce-917790e7e391@gutov.dev> <83edoc1602.fsf@gnu.org> <8e4ec101-adc3-0d1b-af3d-cce92f17b874@gutov.dev> <83r0sbyuew.fsf@gnu.org> <83edoazr8k.fsf@gnu.org> <3fb17c71-2a37-b306-472b-d8bc845e5777@gutov.dev> <83a5yyznfe.fsf@gnu.org> <41a79777-2cc6-9562-8915-9f28070b7bc9@gutov.dev> <83cz3txzi5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FsAX70WOxfKx4tsPIcDcGXJM" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27374"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca, larsi@gnus.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 25 01:46:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pr5tA-0006ta-Gb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Apr 2023 01:46:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pr5sw-0002Hq-6Q; Mon, 24 Apr 2023 19:46:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pr5si-0002HK-T5 for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2023 19:46:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pr5sg-0001Vv-Ot for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2023 19:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pr5sg-0005om-5P for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2023 19:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2023 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168237996022356 (code B ref 62720); Mon, 24 Apr 2023 23:46:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 24 Apr 2023 23:46:00 +0000 Original-Received: from localhost ([127.0.0.1]:50725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pr5sd-0005oW-JY for submit@debbugs.gnu.org; Mon, 24 Apr 2023 19:46:00 -0400 Original-Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:54369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pr5sc-0005oG-5d for 62720@debbugs.gnu.org; Mon, 24 Apr 2023 19:45:58 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id D6CC12B06432; Mon, 24 Apr 2023 19:45:50 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 24 Apr 2023 19:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1682379950; x=1682383550; bh=VS VW68P9O1/Oa10hRoyP7srH5KO+Em9emASqj5TU0oA=; b=MnxE5DOX+HoiZq73uj pSR2o3nO95Q6ush1HSMqKirwUWQG+wzCcSMdWuv4AS0HcESu4P5XfvQV2B8Ybv6n GuBP3ZJ3ZJB8iD4rRU27CJUYT+JSK3CifEQ22K7xnNzfkfK778E0+cSZrgsp+Rl5 XHtgB+N5hV39Md6x4cL2wYNCjqBT/0duAeeOx/TdBJHPLimCXsMGrWa9SlDjNwcp PYhIZ5C6CSpZW0W15bKlwDccs0yQZ2g86zkBUtmDF0jbiFQJeaGA8+HXCjMeYTB1 GtbNn81FqwV2hyofa+hsVHke0REywMo8F+QPR8D5mgtKUpBq2lyJyPm/A7iK6VJm 13rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682379950; x=1682383550; bh=VSVW68P9O1/Oa 10hRoyP7srH5KO+Em9emASqj5TU0oA=; b=VZ6S+1CUm4GSSh7NWK6hgLa9lGyu1 u95uJsPTNXxReUYulr3ElNzP+Ym/VTlQxkhzaG+1GGvEMuWK2ttXOnl+aF+mDT7b VJuRQAx297Ts0fcj3mDqIpXsrt9wpDHS1y+FrALcfcWqzTV8CL8gxTz9Rr28H78w 1zY+XrEq5U+rcmloZhiQQX1A5KRQb4vqx94ZqJm+WbseEWALWAe0A88FncLhKD5k IoVTI5+DjH/pyKaJbJVyNz/QfBXHLZvH3740aL7AWxzRwqP7x2NyqgMxcOjCzx9T O83Bd2zXnDFK98kHEFAqcB3W5gATWYu73rPNhIls3IBXesEIoPjJZYHAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduuddgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehteekgfetieeujeeuvddtvdelteffleejteduvdefffejieehheeuteffveei jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 Apr 2023 19:45:48 -0400 (EDT) Content-Language: en-US In-Reply-To: <83cz3txzi5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260588 Archived-At: This is a multi-part message in MIME format. --------------FsAX70WOxfKx4tsPIcDcGXJM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/04/2023 14:58, Eli Zaretskii wrote: >> Date: Mon, 24 Apr 2023 00:53:30 +0300 >> Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, >> joaotavora@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >> On 23/04/2023 17:24, Eli Zaretskii wrote: >>>> Date: Sun, 23 Apr 2023 16:11:44 +0300 >>>> Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, >>>> joaotavora@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca >>>> From: Dmitry Gutov >>>> >>>>>> It addressed two last points from your previous email, obviously. >>>>> Which points are those? Please help me identify them. >>>> >>>> These two: >>>> >>>> > There is already such an option, added as part of fixing this bug. >>>> >>>> The binding was added, so now we straight away delegate to package-install. >>> >>> I meant to give the user the control on whether package-update will >>> update built-in packages, like we did with package-install: either via >>> prefix argument or by customizing the user option. >> >> That would be a different change, though. >> >> So what are we guarding against here? That the user will choose a >> built-in package to upgrade by accident? > > Yes. Also, against invocations of this command from other commands > and from the menu. It's not in the menu. There are also no known callers aside from package-update-all. >> And we'll show her an error, saying "use the prefix argument"? > > No, I think we'll do whatever the code does today when passed a > built-in package. Very well, here's the next version. It adds a new optional argument to the function (so that people can evaluate e.g. (package-update 'eglot t)). When called interactively, it is determined by current-prefix-argument. Also please review the docstring change. Regarding obeying package-install-upgrade-built-in, I think it would need to be renamed, and both package-update-all and package-menu-mark-upgrades would need to be made obey it too. All that could be done in a subsequent change. --------------FsAX70WOxfKx4tsPIcDcGXJM Content-Type: text/x-patch; charset=UTF-8; name="package-update-fix.diff" Content-Disposition: attachment; filename="package-update-fix.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1s aXNwL3BhY2thZ2UuZWwKaW5kZXggZmZhNjI3MmRkMWYuLmI3MmJmODZjNzczIDEwMDY0NAot LS0gYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAorKysgYi9saXNwL2VtYWNzLWxpc3Av cGFja2FnZS5lbApAQCAtMjI2NiwyMSArMjI2NiwzOSBAQCBwYWNrYWdlLWluc3RhbGwKIChk ZWNsYXJlLWZ1bmN0aW9uIHBhY2thZ2UtdmMtdXBkYXRlICJwYWNrYWdlLXZjIiAocGtnKSkK IAogOzs7IyMjYXV0b2xvYWQKLShkZWZ1biBwYWNrYWdlLXVwZGF0ZSAobmFtZSkKLSAgIlVw ZGF0ZSBwYWNrYWdlIE5BTUUgaWYgYSBuZXdlciB2ZXJzaW9uIGV4aXN0cy4iCisoZGVmdW4g cGFja2FnZS11cGRhdGUgKG5hbWUgJm9wdGlvbmFsIHVwZGF0ZS1idWlsdC1pbnMpCisgICJV cGRhdGUgcGFja2FnZSBOQU1FIGlmIGEgbmV3ZXIgdmVyc2lvbiBleGlzdHMuCisKK09ubHkg cGFja2FnZXMgaW5zdGFsbGVkIGZyb20gRUxQQSBhcmUgYWxsb3dlZCB0byBiZSB1cGRhdGVk IHRoaXMKK3dheS4KKworQnV0IGlmIFVQREFURS1CVUlMVC1JTlMgaXMgbm9uLW5pbCwgb3Ig aWYgdGhlIGNvbW1hbmQgaXMgaW52b2tlZAoraW50ZXJhY3RpdmVseSB3aXRoIGEgcHJlZml4 IGFyZ3VtZW50LCBpdCB3aWxsIGFsbG93IHVwZ3JhZGluZyBvZgorYWN0aXZlIGJ1aWx0LWlu IHBhY2thZ2VzLiIKICAgKGludGVyYWN0aXZlCiAgICAobGlzdCAoY29tcGxldGluZy1yZWFk Ci0gICAgICAgICAgIlVwZGF0ZSBwYWNrYWdlOiAiIChwYWNrYWdlLS11cGRhdGVhYmxlLXBh Y2thZ2VzKSBuaWwgdCkpKQorICAgICAgICAgICJVcGRhdGUgcGFja2FnZTogIiAocGFja2Fn ZS0tdXBkYXRlYWJsZS1wYWNrYWdlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y3VycmVudC1wcmVmaXgtYXJnKQorICAgICAgICAgIG5pbCB0KQorICAgICAgICAgY3VycmVu dC1wcmVmaXgtYXJnKSkKICAgKGxldCogKChwYWNrYWdlIChpZiAoc3ltYm9scCBuYW1lKQog ICAgICAgICAgICAgICAgICAgICAgIG5hbWUKICAgICAgICAgICAgICAgICAgICAgKGludGVy biBuYW1lKSkpCi0gICAgICAgICAocGtnLWRlc2MgKGNhZHIgKGFzc3EgcGFja2FnZSBwYWNr YWdlLWFsaXN0KSkpKQotICAgIChpZiAocGFja2FnZS12Yy1wIHBrZy1kZXNjKQorICAgICAg ICAgKHBrZy1kZXNjIChjYWRyIChhc3NxIHBhY2thZ2UgcGFja2FnZS1hbGlzdCkpKQorICAg ICAgICAgKHBhY2thZ2UtaW5zdGFsbC11cGdyYWRlLWJ1aWx0LWluIChhbmQKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdXBkYXRlLWJ1aWx0LWlucwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobm90IHBrZy1k ZXNjKSkpKQorICAgIDs7IGBwa2ctZGVzYycgd2lsbCBiZSBuaWwgd2hlbiB0aGUgcGFja2Fn ZSBpcyBhbiAiYWN0aXZlIGJ1aWx0LWluIi4KKyAgICAoaWYgKGFuZCBwa2ctZGVzYyAocGFj a2FnZS12Yy1wIHBrZy1kZXNjKSkKICAgICAgICAgKHBhY2thZ2UtdmMtdXBkYXRlIHBrZy1k ZXNjKQotICAgICAgKHBhY2thZ2UtZGVsZXRlIHBrZy1kZXNjICdmb3JjZSkKLSAgICAgIChw YWNrYWdlLWluc3RhbGwgcGFja2FnZSAnZG9udC1zZWxlY3QpKSkpCi0KLShkZWZ1biBwYWNr YWdlLS11cGRhdGVhYmxlLXBhY2thZ2VzICgpCisgICAgICAod2hlbiBwa2ctZGVzYworICAg ICAgICAocGFja2FnZS1kZWxldGUgcGtnLWRlc2MgJ2ZvcmNlICdub3NhdmUpKQorICAgICAg KHBhY2thZ2UtaW5zdGFsbCBwYWNrYWdlCisgICAgICAgICAgICAgICAgICAgICAgIDs7IEFu IGFjdGl2ZSBidWlsdC1pbiBoYXMgbmV2ZXIgYmVlbiAic2VsZWN0ZWQiCisgICAgICAgICAg ICAgICAgICAgICAgIDs7IGJlZm9yZS4gIE1hcmsgaXQgYXMgaW5zdGFsbGVkIGV4cGxpY2l0 bHkuCisgICAgICAgICAgICAgICAgICAgICAgIChhbmQgcGtnLWRlc2MgJ2RvbnQtc2VsZWN0 KSkpKSkKKworKGRlZnVuIHBhY2thZ2UtLXVwZGF0ZWFibGUtcGFja2FnZXMgKCZvcHRpb25h bCBhbGxvdy1idWlsdGlucykKICAgOzsgSW5pdGlhbGl6ZSB0aGUgcGFja2FnZSBzeXN0ZW0g dG8gZ2V0IHRoZSBsaXN0IG9mIHBhY2thZ2UKICAgOzsgc3ltYm9scyBmb3IgY29tcGxldGlv bi4KICAgKHBhY2thZ2UtLWFyY2hpdmVzLWluaXRpYWxpemUpCkBAIC0yMjkxLDExICsyMzA5 LDIxIEBAIHBhY2thZ2UtLXVwZGF0ZWFibGUtcGFja2FnZXMKICAgICAgIChvciAobGV0ICgo YXZhaWxhYmxlCiAgICAgICAgICAgICAgICAgIChhc3NxIChjYXIgZWx0KSBwYWNrYWdlLWFy Y2hpdmUtY29udGVudHMpKSkKICAgICAgICAgICAgIChhbmQgYXZhaWxhYmxlCi0gICAgICAg ICAgICAgICAgICh2ZXJzaW9uLWxpc3QtPAotICAgICAgICAgICAgICAgICAgKHBhY2thZ2Ut ZGVzYy12ZXJzaW9uIChjYWRyIGVsdCkpCi0gICAgICAgICAgICAgICAgICAocGFja2FnZS1k ZXNjLXZlcnNpb24gKGNhZHIgYXZhaWxhYmxlKSkpKSkKLSAgICAgICAgICAocGFja2FnZS12 Yy1wIChjYWRyIChhc3NxIChjYXIgZWx0KSBwYWNrYWdlLWFsaXN0KSkpKSkKLSAgICBwYWNr YWdlLWFsaXN0KSkpCisgICAgICAgICAgICAgICAgIChvciAoYW5kCisgICAgICAgICAgICAg ICAgICAgICAgYWxsb3ctYnVpbHRpbnMKKyAgICAgICAgICAgICAgICAgICAgICAobm90IChw YWNrYWdlLWRlc2MtdmVyc2lvbiAoY2FkciBlbHQpKSkpCisgICAgICAgICAgICAgICAgICAg ICAodmVyc2lvbi1saXN0LTwKKyAgICAgICAgICAgICAgICAgICAgICAocGFja2FnZS1kZXNj LXZlcnNpb24gKGNhZHIgZWx0KSkKKyAgICAgICAgICAgICAgICAgICAgICAocGFja2FnZS1k ZXNjLXZlcnNpb24gKGNhZHIgYXZhaWxhYmxlKSkpKSkpCisgICAgICAgICAgKHBhY2thZ2Ut dmMtcCAoY2FkciBlbHQpKSkpCisgICAgKGlmIGFsbG93LWJ1aWx0aW5zCisgICAgICAgIChh cHBlbmQgcGFja2FnZS1hbGlzdAorICAgICAgICAgICAgICAgIChtYXBjYW4KKyAgICAgICAg ICAgICAgICAgKGxhbWJkYSAoZWx0KQorICAgICAgICAgICAgICAgICAgICh3aGVuIChub3Qg KGFzc3EgKGNhciBlbHQpIHBhY2thZ2UtYWxpc3QpKQorICAgICAgICAgICAgICAgICAgICAg KGxpc3QgKGxpc3QgKGNhciBlbHQpIChwYWNrYWdlLS1mcm9tLWJ1aWx0aW4gZWx0KSkpKSkK KyAgICAgICAgICAgICAgICAgcGFja2FnZS0tYnVpbHRpbnMpKQorICAgICAgcGFja2FnZS1h bGlzdCkpKSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBwYWNrYWdlLXVwZGF0ZS1hbGwg KCZvcHRpb25hbCBxdWVyeSkK --------------FsAX70WOxfKx4tsPIcDcGXJM--