From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 60285@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#60285: xref-query-replace-in-results could show an arrow pointing to the current item being replaced
Date: Mon, 16 Jan 2023 03:41:56 +0200 [thread overview]
Message-ID: <5ada9b8c-8ec6-d31c-8133-462a577727ad@yandex.ru> (raw)
In-Reply-To: <86v8ll2kk3.fsf@mail.linkov.net>
On 05/01/2023 19:55, Juri Linkov wrote:
>>> For example,
>>> as you can undo or go to the previous match during the query replace,
>>> the arrow should point to the previous result, if possible.
>> Hmm, I'm not sure how to implement that. Some new hook inside
>> perform-replace?
>>
>> Maybe Juri has some ideas.
> Indeed, there is a special hook for such cases:
> 'replace-update-post-hook'.
That one seems problematic. First of all, I think (?) that we need to
update the arrow's position when the replacement prompt appears, not
after a replacement.
Second, it fires in all cases -- whether the replacement is going
forward, or it being undone, is that right? I suppose this will mean
we'll need to maintain a reverse mapping: from the markers back to the
Xref buffer lines. Hopefully they will be in expected position after the
"undo" actions too.
next prev parent reply other threads:[~2023-01-16 1:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m15ye2j5h3.fsf.ref@yahoo.es>
2022-12-23 19:16 ` bug#60285: xref-query-replace-in-results could show an arrow pointing to the current item being replaced Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-24 17:45 ` Dmitry Gutov
2023-01-01 11:23 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-04 23:48 ` Dmitry Gutov
2023-01-05 17:55 ` Juri Linkov
2023-01-16 1:41 ` Dmitry Gutov [this message]
2023-01-16 17:39 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ada9b8c-8ec6-d31c-8133-462a577727ad@yandex.ru \
--to=dgutov@yandex.ru \
--cc=60285@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).