From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#29412: 27.0.50; dired-toggle-read-only should (at some point!) check that the direcory is writeable Date: Sun, 13 Dec 2020 08:55:36 -0800 (PST) Message-ID: <5aa02c80-bcf2-4e99-915b-013275f3328d@default> References: <87o9nt2cvo.fsf@ctlt579.codethink.co.uk> <87y2i35ke7.fsf@gnus.org> <505c79af-0056-4f66-aca8-9559f6ef2bff@default> <878sa2qfmq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35322"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Marshall , Lars Ingebrigtsen , 29412@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 13 17:57:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koUgK-00094e-Da for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 17:57:12 +0100 Original-Received: from localhost ([::1]:47786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koUgJ-0004rQ-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Dec 2020 11:57:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koUgA-0004oc-9E for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 11:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koUgA-0003Fn-00 for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koUg9-0000nE-Su for bug-gnu-emacs@gnu.org; Sun, 13 Dec 2020 11:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Dec 2020 16:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 29412-submit@debbugs.gnu.org id=B29412.16078785622980 (code B ref 29412); Sun, 13 Dec 2020 16:57:01 +0000 Original-Received: (at 29412) by debbugs.gnu.org; 13 Dec 2020 16:56:02 +0000 Original-Received: from localhost ([127.0.0.1]:49966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koUfC-0000m0-I7 for submit@debbugs.gnu.org; Sun, 13 Dec 2020 11:56:02 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:39692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koUfB-0000lW-2l for 29412@debbugs.gnu.org; Sun, 13 Dec 2020 11:56:01 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BDGrvPh094638; Sun, 13 Dec 2020 16:55:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=y1x8+AOltgsNdWkkWzsAvsv1+zxVtG6HXVqExOjBY4U=; b=gl+LISKKIFW/LUrv1n7MdfIzB0r70dOmw2sNiHk8Wh/NYyLXG0JR0IAZkuKwxUzR4Phv U0UPGcLyDMOFJdO2S+vfiNZwFYg8BuBanxUeEsoAH+lhv4ZKANSD7evs1f3RuBloZsU9 U1G5Sy7NNRGVUl44+l/9Owb2kiRw2PdI51AzgzvGMNOimTFH9f4iImWq6Y1/IUICUPJ8 nM0CIJwf2akCTHcUwJLH4RGrss79mEaVv9lnK2Wfv7jzXBrEdKxec27a+JLeZOA+WhVK LES0ghwFnLIngRbFuHEuZM8qlAFJ9TARXuCSdxQf+2w+yR52exSURHrXv8gteQHOa4Wn 1Q== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 35cntktj3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 13 Dec 2020 16:55:46 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BDGnxkH015833; Sun, 13 Dec 2020 16:55:45 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 35d7stj8ua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 13 Dec 2020 16:55:45 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BDGtbhe012744; Sun, 13 Dec 2020 16:55:37 GMT In-Reply-To: <878sa2qfmq.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxlogscore=912 spamscore=0 mlxscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012130132 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9834 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 mlxlogscore=932 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012130133 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195971 Archived-At: > >> I've now made `C-c C-q' signal an error if the directory isn't writabl= e > >> in Emacs 28. > > > > I don't feel strongly about this, but I wonder whether > > that's the right thing to do. We do NOT do that for > > files, for example. >=20 > OTOH, displaying a warning might go unnoticed by the user. > Then maybe better would be to ask a y-or-n question > whether the user still wants to edit the unwritable buffer. I disagree. This should be handled _exactly_ the same way we handle a buffer for a file that is read-only. I see no argument why we should treat a directory buffer different from a file buffer. For a file buffer, `C-x C-q' simply echoes: "Read-Only mode disabled in current buffer" That is perfectly clear. And any attempt to use a subsequent `C-x C-q to save edit changes should be the time to query a user for what to do (e.g. confirm saving the changes or ignore them). Come up with a good argument why this should be handled differently from the file-editing case and we can talk about it. There are very good use cases for allowing the _buffer_ to be edited, regardless of whether the user ultimately wants such changes applied to disk.