From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: H.-J. =?UTF-8?Q?Heitl=C3=A4nder?= Newsgroups: gmane.emacs.bugs Subject: bug#62239: patch feedback Date: Mon, 27 Mar 2023 08:27:48 +0000 Message-ID: <5a6682df-f4fc-5ce7-1d04-6f40b5e2d955@posteo.de> References: <6445c1ab-07e5-1473-c4a0-9e4f21f4eb6d@posteo.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------pW8YK0wnYg1Xvk79kLd5lsWv" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4456"; mail-complaints-to="usenet@ciao.gmane.io" To: 62239@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 15:15:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgmhU-0000sw-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 15:15:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgmgo-0002mG-FZ; Mon, 27 Mar 2023 09:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgmgk-0002jE-TH for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 09:15:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgmgk-0001sd-Hq for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 09:15:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgmgk-0005Nn-8H for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 09:15:06 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <6445c1ab-07e5-1473-c4a0-9e4f21f4eb6d@posteo.de> Resent-From: H.-J. =?UTF-8?Q?Heitl=C3=A4nder?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 13:15:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62239 X-GNU-PR-Package: emacs Original-Received: via spool by 62239-submit@debbugs.gnu.org id=B62239.167992284720489 (code B ref 62239); Mon, 27 Mar 2023 13:15:06 +0000 Original-Received: (at 62239) by debbugs.gnu.org; 27 Mar 2023 13:14:07 +0000 Original-Received: from localhost ([127.0.0.1]:46764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgmfm-0005KO-NX for submit@debbugs.gnu.org; Mon, 27 Mar 2023 09:14:07 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:38217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgiCq-00034V-7j for 62239@debbugs.gnu.org; Mon, 27 Mar 2023 04:27:57 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E2DA3240084 for <62239@debbugs.gnu.org>; Mon, 27 Mar 2023 10:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1679905669; bh=LhKVGzatNtG5ydHGlYAuToTEb3iMcAQQJIolk9WAOkk=; h=Date:To:From:Subject:From; b=dkhgRfgplmx7nCYFagADnojheGNby+c76N6ATdNSJqtVl/ryhTP2w0hxg3qKZfDfy gj1Hqi5EnMQ024gM7q8nrJYUeJ25IUtTa9BNmTwz+I6toXiGttwudd9W3sr7G4+aHb L/HZ2HGsIeZpI9zFPNzrwGXZWTX8GVLJxhxF7Qpf9NdAqxHzufxLW6wFpmkawLL4q5 Zt2v/Q1TEFs2EQlRYASJpm9+LOn3BhuutH3TuvumbpAo7EuTHkmKQS5N2b1ixeTWFr Trwr80BZ+qIJHOHDgp4Pwvxc3OMiIB2lzB4nf8T2ZhOxtZ6BoKML/T5ruQsUtHH2wc bOeUL0VCx7C4A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PlQtD5Jrsz9rxW for <62239@debbugs.gnu.org>; Mon, 27 Mar 2023 10:27:48 +0200 (CEST) Content-Language: de-DE X-Mailman-Approved-At: Mon, 27 Mar 2023 09:14:06 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258721 Archived-At: This is a multi-part message in MIME format. --------------pW8YK0wnYg1Xvk79kLd5lsWv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi there, Michael Heerdegen developed a patch for the problem. Feedback: apply patch - not quite successfull When trying to apply the patch M-diff-mode open patch-file M-n C-c C-a I get "Hunk seriously messed up" If I understand diff correctly, the patch aims for line 2204 = "(add-hook 'change-major-mode-hook..." In my version of doc-view.el that line: "(add-hook 'change-major-mode-hook..." is contained in line 2207. That is probably the reason for "Hunk seriously messed up" ... So what I did is: I changed the source code of view-doc.el manually and not via the delevered patch. Then I tested it and ... TADA!!! Success!!! It works. Thanks for the effort Heiner --------------pW8YK0wnYg1Xvk79kLd5lsWv Content-Type: text/x-patch; charset=UTF-8; name="62239.patch" Content-Disposition: attachment; filename="62239.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZG9jLXZpZXcuZWwgYi9saXNwL2RvYy12aWV3LmVsCmluZGV4 IGIxNDY1NWZiMjc0Li4wMDI0MGViZjA4ZCAxMDA2NDQKLS0tIGEvbGlzcC9kb2Mtdmlldy5l bAorKysgYi9saXNwL2RvYy12aWV3LmVsCkBAIC0yMjA0LDcgKzIyMDQsOSBAQCBkb2Mtdmll dy1tb2RlCiAgICAgKGFkZC1ob29rICdjaGFuZ2UtbWFqb3ItbW9kZS1ob29rCiAJICAgICAg KGxhbWJkYSAoKQogCQkoZG9jLXZpZXcta2lsbC1wcm9jKQotCQkocmVtb3ZlLW92ZXJsYXlz IChwb2ludC1taW4pIChwb2ludC1tYXgpICdkb2MtdmlldyB0KSkKKwkJKHJlbW92ZS1vdmVy bGF5cyAocG9pbnQtbWluKSAocG9pbnQtbWF4KSAnZG9jLXZpZXcgdCkKKyAgICAgICAgICAg ICAgICAocmVtb3ZlLWZ1bmN0aW9uIChsb2NhbCAncmV2ZXJ0LWJ1ZmZlci1mdW5jdGlvbikK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICMnZG9jLXZpZXctLXJldmVydC1i dWZmZXIpKQogCSAgICAgIG5pbCB0KQogICAgIChhZGQtaG9vayAnY2xvbmUtaW5kaXJlY3Qt YnVmZmVyLWhvb2sgIydkb2Mtdmlldy1jbG9uZS1idWZmZXItaG9vayBuaWwgdCkKICAgICAo YWRkLWhvb2sgJ2tpbGwtYnVmZmVyLWhvb2sgIydkb2Mtdmlldy1raWxsLXByb2MgbmlsIHQp --------------pW8YK0wnYg1Xvk79kLd5lsWv--