From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Tim Daly Jr." Newsgroups: gmane.emacs.bugs Subject: bug#13223: patch to fix this bug Date: Tue, 30 Apr 2013 18:35:59 -0700 Message-ID: <5F5F4251-B57C-4908-BBBB-6848AA6EF362@tenkan.org> References: <58A8252B-C006-4216-97FD-3D2933D35282@tenkan.org> <96A9F7F8-2C61-422F-A18E-9C95511F260F@tenkan.org> <87ppxexhjh.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1367372207 21261 80.91.229.3 (1 May 2013 01:36:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 1 May 2013 01:36:47 +0000 (UTC) Cc: 13223@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 01 03:36:45 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UXLyO-0005LI-Ml for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 May 2013 03:36:44 +0200 Original-Received: from localhost ([::1]:54344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXLyO-0003Rt-88 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2013 21:36:44 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXLyJ-0003Rn-Bt for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2013 21:36:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXLyH-0003Zb-4I for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2013 21:36:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXLyH-0003ZX-1b for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2013 21:36:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UXLyg-0008WH-Su for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2013 21:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Tim Daly Jr." Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 May 2013 01:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13223-submit@debbugs.gnu.org id=B13223.136737219932663 (code B ref 13223); Wed, 01 May 2013 01:37:02 +0000 Original-Received: (at 13223) by debbugs.gnu.org; 1 May 2013 01:36:39 +0000 Original-Received: from localhost ([127.0.0.1]:53009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UXLyE-0008Ud-NB for submit@debbugs.gnu.org; Tue, 30 Apr 2013 21:36:39 -0400 Original-Received: from tenkan.org ([216.114.78.229]:48213) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UXLy8-0008Tw-KF for 13223@debbugs.gnu.org; Tue, 30 Apr 2013 21:36:33 -0400 Original-Received: from [10.0.0.253] (c-24-5-122-5.hsd1.ca.comcast.net [24.5.122.5]) by tenkan.org (Postfix) with ESMTPSA id 790AF257A077; Wed, 1 May 2013 01:36:00 +0000 (UTC) In-Reply-To: <87ppxexhjh.fsf@mail.jurta.org> X-Mailer: Apple Mail (2.1085) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73860 Archived-At: On Apr 28, 2013, at 11:45 PM, Juri Linkov wrote: >> * comint.el (comint-history-isearch-in-progress): new variable >> that lets us detect that an isearch is running over command >> history >=20 > I wonder why you didn't use the existing variable `isearch-mode' > to detect that an isearch is running? There should be no problem > using `isearch-mode' as you can see in the patch below. >=20 > Additionally it will display only the current history item where > isearch actually matches, i.e. to display just one "History item" > message per one M-r isearch match. This is necessary to inform the = user > about the current history index as the commands `M-p' = (comint-previous-input) > and `M-n' (comint-next-input) already do: quite right, your patch looks much better. :) -tim