From: "Tim Daly Jr." <tim@tenkan.org>
To: Juri Linkov <juri@jurta.org>
Cc: 13223@debbugs.gnu.org
Subject: bug#13223: patch to fix this bug
Date: Tue, 30 Apr 2013 18:35:59 -0700 [thread overview]
Message-ID: <5F5F4251-B57C-4908-BBBB-6848AA6EF362@tenkan.org> (raw)
In-Reply-To: <87ppxexhjh.fsf@mail.jurta.org>
On Apr 28, 2013, at 11:45 PM, Juri Linkov wrote:
>> * comint.el (comint-history-isearch-in-progress): new variable
>> that lets us detect that an isearch is running over command
>> history
>
> I wonder why you didn't use the existing variable `isearch-mode'
> to detect that an isearch is running? There should be no problem
> using `isearch-mode' as you can see in the patch below.
>
> Additionally it will display only the current history item where
> isearch actually matches, i.e. to display just one "History item"
> message per one M-r isearch match. This is necessary to inform the user
> about the current history index as the commands `M-p' (comint-previous-input)
> and `M-n' (comint-next-input) already do:
quite right, your patch looks much better. :)
-tim
next prev parent reply other threads:[~2013-05-01 1:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 6:39 bug#13223: 24.2; comint history rendered useless by messages Tim Daly Jr.
2013-04-28 22:27 ` bug#13223: patch to fix this bug Tim Daly Jr.
2013-04-29 6:45 ` Juri Linkov
2013-05-01 1:35 ` Tim Daly Jr. [this message]
2013-04-28 23:13 ` bug#13223: resending the patch as text/plain Tim Daly Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F5F4251-B57C-4908-BBBB-6848AA6EF362@tenkan.org \
--to=tim@tenkan.org \
--cc=13223@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).