unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 'Dan Nicolaescu' <dann@ics.uci.edu>,
	'Chong Yidong' <cyd@stupidchicken.com>,
	rms@gnu.org, 3370@emacsbugs.donarmstrong.com
Subject: bug#3370: 23.0.94; `comment-region' indents comment chars  inappropriately
Date: Mon, 25 May 2009 14:56:37 -0700	[thread overview]
Message-ID: <5E5C09B3DBFB4C6B98C6903351B48B7E@us.oracle.com> (raw)
In-Reply-To: <jwvvdnoq3zi.fsf-monnier+emacsbugreports@gnu.org>

> Yes, I know that.
> 
> > Commenting out this line:
> >   `abcdef'
> > gives this, prior to Emacs 23:
> > ;;   `abcdef'
> > Commenting out the line is different from inserting a comment at the
> > same level:
> >   ;;
> >   `abcdef'
> 
> I know.  Yet, most cases of commented-out code would use
> 
>     ;; `abcdef'

No, that was not an example of commenting-out code. It was an example of
inserting a comment - as I said.

> Obviously, you don't like it, just like Richard doesn't like it.  I do
> believe you're in the minority, tho.

No, you're mistaken. I don't really care one way or the other about it.

The information that was missing (and is still missing) is about `comment-style'
and `comment-styles'. You gave me a solution for the code I have, but still no
explanation of `comment-style'. There is still no doc for it.

I don't need to use a different value of `comment-style' for my own use
interactively - I don't really care whether the commented lines are indented or
not. (At least I don't have a preference at the moment.) My question was about
use of `comment-region' in code, not interactively. See the original bug
report's use case.

The real bug I guess is that there is no explanation of `comment-style'.
Whenever things like this change, there is the potential (almost the certainty)
that existing code will break, as it did in my case. My real need, I came to
realize here, is not that `comment-region' act, by default, as it did before,
but that I know how to fix the broken code due to its behavior change. The
answer was to bind `comment-style', as you suggested.

But there is no explanation, hence no understanding, of that answer - no doc for
`comment-style'. And, as I said, the doc string for `comment-style' (which is
pretty much useless) refers to `comment-styles', which is not recognized (and
therefore has no link).







  reply	other threads:[~2009-05-25 21:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24 23:31 bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Chong Yidong
2009-05-24 23:57 ` Drew Adams
2009-05-25  0:04 ` Lennart Borgman
2009-05-25  0:54   ` Chong Yidong
2009-05-25  1:28     ` Jason Rumney
2009-05-25  2:09       ` Drew Adams
2009-05-25  4:47       ` Chong Yidong
2009-05-25  7:01         ` Drew Adams
2009-05-25 13:27           ` Chong Yidong
2009-05-25 17:42             ` Drew Adams
2009-05-25 13:38           ` Stefan Monnier
2009-05-25 17:42             ` Drew Adams
2009-05-25 21:22               ` Stefan Monnier
2009-05-25 21:56                 ` Drew Adams [this message]
2009-05-25 22:46                 ` Jason Rumney
2009-05-26  1:16                   ` Stefan Monnier
2012-02-22  2:46                     ` Glenn Morris
2009-05-25  5:26       ` Dan Nicolaescu
2009-05-25  7:02         ` Drew Adams
2009-05-25 13:30           ` Chong Yidong
2009-05-25 13:39           ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2009-05-24 22:31 Drew Adams
2009-05-25 13:41 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E5C09B3DBFB4C6B98C6903351B48B7E@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=3370@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    --cc=dann@ics.uci.edu \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).