From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, 34179@debbugs.gnu.org
Subject: bug#34179: 27.0.50; message hangs when buffer with process visible
Date: Fri, 25 Jan 2019 17:51:53 +0100 [thread overview]
Message-ID: <5C4B3EA9.5030900@gmx.at> (raw)
In-Reply-To: <83woms6ex9.fsf@gnu.org>
> You are right, but window-font-width called by
> window-max-chars-per-line also calls select-window.
>
> Btw, I don't think replacing with-selected-window with
> with-current-buffer will necessarily yield the same results.
Right. I attach a more correct patch now that does not select a
window in these cases. Michael, please check whether it fixes your
use case.
> And we
> cannot in general forbid calls to with-selected-window in hooks called
> from run_window_change_functions anyway, can we?
Certainly not.
>> I can't get the hang with a single frame. Can you?
>
> OK, but does that change anything? Why is having a separate frame a
> problem?
That's what I would have liked to find out.
>> It's an infloop triggered in ‘window-configuration-change-hook’ and it
>> was always easy to trigger an infloop there.
>
> Not sure I understand what you mean. The loop is in
> redisplay_internal, not in window-configuration-change-hook. How was
> it easy to trigger that in the past? And even if it was, shouldn't we
> avoid such a loop?
Agreed.
> In any case, it is way too easy to do in functions called from
> run_window_change_functions something that sets
> windows_or_buffers_changed, so automatically retrying redisplay based
> on that variable after run_window_change_functions returns is IMO
> dangerous.
But what would be the alternatives? Having clients ask for redisplay
explicitly every time they are in a hook? Or maybe just suppress
redisplay_other_windows when running from the hook.
Thanks, martin
next prev parent reply other threads:[~2019-01-25 16:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:10 bug#34179: 27.0.50; message hangs when buffer with process visible Michael Heerdegen
2019-01-23 16:29 ` Eli Zaretskii
2019-01-24 13:19 ` Michael Heerdegen
2019-01-24 13:35 ` Michael Heerdegen
2019-01-24 14:39 ` Eli Zaretskii
2019-01-24 14:58 ` Michael Heerdegen
2019-01-24 15:04 ` Michael Heerdegen
2019-01-24 15:25 ` Michael Heerdegen
2019-01-24 15:36 ` Michael Heerdegen
2019-01-24 16:05 ` martin rudalics
2019-01-24 18:22 ` Michael Heerdegen
2019-01-24 18:33 ` martin rudalics
2019-01-24 18:36 ` Eli Zaretskii
2019-01-24 18:51 ` martin rudalics
2019-01-24 18:59 ` Eli Zaretskii
2019-01-24 19:20 ` Michael Heerdegen
2019-01-24 18:55 ` Michael Heerdegen
2019-01-24 18:47 ` Michael Heerdegen
2019-01-24 19:21 ` Eli Zaretskii
2019-01-24 19:49 ` Eli Zaretskii
2019-01-25 9:44 ` martin rudalics
2019-01-25 10:15 ` Eli Zaretskii
2019-01-25 10:36 ` martin rudalics
2019-01-25 13:32 ` Eli Zaretskii
2019-01-25 16:51 ` martin rudalics [this message]
2019-01-25 17:22 ` martin rudalics
2019-01-26 12:58 ` Michael Heerdegen
2019-01-26 15:09 ` martin rudalics
2019-01-26 18:48 ` martin rudalics
2019-01-27 14:22 ` Michael Heerdegen
2019-01-28 18:38 ` martin rudalics
2019-01-30 22:29 ` Michael Heerdegen
2019-01-31 8:32 ` martin rudalics
2019-01-31 14:06 ` Eli Zaretskii
2019-01-31 18:44 ` martin rudalics
2019-01-31 20:10 ` Eli Zaretskii
2019-02-01 9:04 ` martin rudalics
2019-01-31 14:44 ` Michael Heerdegen
2019-02-02 9:28 ` martin rudalics
2019-02-04 23:35 ` Michael Heerdegen
2019-02-19 8:39 ` martin rudalics
2019-01-25 18:31 ` Eli Zaretskii
2019-01-25 18:54 ` martin rudalics
2019-01-25 19:48 ` Eli Zaretskii
2019-01-24 15:46 ` martin rudalics
2019-01-24 14:32 ` Eli Zaretskii
2019-01-24 14:41 ` Michael Heerdegen
2019-01-24 14:49 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C4B3EA9.5030900@gmx.at \
--to=rudalics@gmx.at \
--cc=34179@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).