unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: michael_heerdegen@web.de, 34179@debbugs.gnu.org
Subject: bug#34179: 27.0.50; message hangs when buffer with process visible
Date: Fri, 25 Jan 2019 11:36:24 +0100	[thread overview]
Message-ID: <5C4AE6A8.9030006@gmx.at> (raw)
In-Reply-To: <83y37959hp.fsf@gnu.org>

 >> If I replace the line
 >>
 >>     (with-selected-window (window-normalize-window window t)
 >>
 >> of 'window-max-chars-per-line' by the line
 >>
 >>     (with-current-buffer (window-buffer window)
 >>
 >> the problem persists.  So it is not the 'select-window' call per se
 >> that causes the trouble.
 >
 > That's because both selecting a window and changing its buffer sets
 > windows_or_buffers_changed via redisplay_other_windows.

But ‘with-current-buffer’ does not change a window's buffer.  Or what
am I missing?

 >> The problem is with having that separate frame that gets its echo
 >> area resized.
 >
 > What separate frame?

The one from Michael's scenarios.  As in

   I can provoke the hang in emacs -Q by just doing M-x shell, C-x 5 2,
   and M-: (message "A\nB").

I can't get the hang with a single frame.  Can you?

 >> Using 'window-size-change-functions' (patch attached) instead of
 >> 'window-configuration-change-hook' fixes the problem here.
 >
 > That might be a good change anyway, but the more general problem of
 > having an easily triggered infloop in redisplay_internal remains, and
 > we should fix that, IMO.

It's an infloop triggered in ‘window-configuration-change-hook’ and it
was always easy to trigger an infloop there.  Obviously, resizing the
minibuffer window did not trigger `window-configuration-change-hook'
at all before my change.

 > Let me turn the table and ask: why do we need to retry redisplay when
 > some function called from run_window_change_functions does something
 > that requires redisplay?  Why not leave that to the next redisplay
 > cycle?

Bug#34138 is one example why redisplay should be triggered from within
a function on 'window-configuration-change-hook'.

martin






  reply	other threads:[~2019-01-25 10:36 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 15:10 bug#34179: 27.0.50; message hangs when buffer with process visible Michael Heerdegen
2019-01-23 16:29 ` Eli Zaretskii
2019-01-24 13:19   ` Michael Heerdegen
2019-01-24 13:35     ` Michael Heerdegen
2019-01-24 14:39       ` Eli Zaretskii
2019-01-24 14:58         ` Michael Heerdegen
2019-01-24 15:04           ` Michael Heerdegen
2019-01-24 15:25             ` Michael Heerdegen
2019-01-24 15:36               ` Michael Heerdegen
2019-01-24 16:05                 ` martin rudalics
2019-01-24 18:22                   ` Michael Heerdegen
2019-01-24 18:33                     ` martin rudalics
2019-01-24 18:36                     ` Eli Zaretskii
2019-01-24 18:51                       ` martin rudalics
2019-01-24 18:59                         ` Eli Zaretskii
2019-01-24 19:20                           ` Michael Heerdegen
2019-01-24 18:55                       ` Michael Heerdegen
2019-01-24 18:47                     ` Michael Heerdegen
2019-01-24 19:21                       ` Eli Zaretskii
2019-01-24 19:49                         ` Eli Zaretskii
2019-01-25  9:44                           ` martin rudalics
2019-01-25 10:15                             ` Eli Zaretskii
2019-01-25 10:36                               ` martin rudalics [this message]
2019-01-25 13:32                                 ` Eli Zaretskii
2019-01-25 16:51                                   ` martin rudalics
2019-01-25 17:22                                     ` martin rudalics
2019-01-26 12:58                                       ` Michael Heerdegen
2019-01-26 15:09                                         ` martin rudalics
2019-01-26 18:48                                           ` martin rudalics
2019-01-27 14:22                                           ` Michael Heerdegen
2019-01-28 18:38                                             ` martin rudalics
2019-01-30 22:29                                               ` Michael Heerdegen
2019-01-31  8:32                                                 ` martin rudalics
2019-01-31 14:06                                                   ` Eli Zaretskii
2019-01-31 18:44                                                     ` martin rudalics
2019-01-31 20:10                                                       ` Eli Zaretskii
2019-02-01  9:04                                                         ` martin rudalics
2019-01-31 14:44                                                   ` Michael Heerdegen
2019-02-02  9:28                                                     ` martin rudalics
2019-02-04 23:35                                                       ` Michael Heerdegen
2019-02-19  8:39                                                         ` martin rudalics
2019-01-25 18:31                                     ` Eli Zaretskii
2019-01-25 18:54                                       ` martin rudalics
2019-01-25 19:48                                         ` Eli Zaretskii
2019-01-24 15:46               ` martin rudalics
2019-01-24 14:32     ` Eli Zaretskii
2019-01-24 14:41       ` Michael Heerdegen
2019-01-24 14:49         ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C4AE6A8.9030006@gmx.at \
    --to=rudalics@gmx.at \
    --cc=34179@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).