unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Barry Warsaw <barry@python.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-pretest-bug@gnu.org, 1496@emacsbugs.donarmstrong.com
Subject: bug#1496: 23.0.60; comint-delete-output should copy region to the kill ring
Date: Thu, 11 Dec 2008 11:48:55 -0500	[thread overview]
Message-ID: <5C47C6C8-BB87-4BE3-9B21-FCFE478E8C25@python.org> (raw)
In-Reply-To: <jwv4p1a8yw5.fsf-monnier+emacsbugreports@gnu.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Dec 11, 2008, at 11:24 AM, Stefan Monnier wrote:

>> comint-delete-output uses delete-region instead of kill-region  
>> because the
>> latter sets this-command.
>
> I do not know if it's the reason for it, but I think your suggestion  
> is
> about right, except that if the command kills the output, it should be
> called comint-kill-output rather than comint-delete-output.

Yes, that's a better name for it, thanks.

I remember reading a comment somewhere that that was the reason for  
using delete-region instead of kill-region, but I could be  
misremembering.

Cheers
- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iQCVAwUBSUFEd3EjvBPtnXfVAQKLFgP+KPFvYZ9znlSvgRs6M+3w7/1/FBh/8mgJ
qXzaRmmQN803tNFoQN6fx30+z516/m/Oy1Hhx5UFvjrxdS/7mOpXsBr5gd6sPc6n
1lwYY1Fhv//vONfavTIcUV7VopBTERyDIxxOHwO2WyuePVIUq2L37IySF5APQUqz
Q1nnyxsmO3s=
=K/F4
-----END PGP SIGNATURE-----






  reply	other threads:[~2008-12-11 16:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 23:37 bug#1496: 23.0.60; comint-delete-output should copy region to the kill ring barry
2008-12-11 16:24 ` Stefan Monnier
2008-12-11 16:48   ` Barry Warsaw [this message]
2021-07-19 15:14 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C47C6C8-BB87-4BE3-9B21-FCFE478E8C25@python.org \
    --to=barry@python.org \
    --cc=1496@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).