From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Tue, 08 Jan 2019 15:47:07 +0100 Message-ID: <5C34B7EB.8030907@gmx.at> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> <874lak9kr0.fsf@mail.linkov.net> <87zhscklhq.fsf@gmail.com> <5C346C76.4050803@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1546958775 14272 195.159.176.226 (8 Jan 2019 14:46:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Jan 2019 14:46:15 +0000 (UTC) Cc: 33870@debbugs.gnu.org, Juri Linkov , Stefan Monnier , Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 08 15:46:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggsdu-0003cy-Hv for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jan 2019 15:46:10 +0100 Original-Received: from localhost ([127.0.0.1]:43109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggsg0-0003nq-JU for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jan 2019 09:48:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggsfk-0003mI-Jw for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 09:48:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggsfi-0006Wg-Oy for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 09:48:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggsfi-0006Vs-L9 for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 09:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ggsfi-0003gb-Ey for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 09:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jan 2019 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.154695886014138 (code B ref 33870); Tue, 08 Jan 2019 14:48:02 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 8 Jan 2019 14:47:40 +0000 Original-Received: from localhost ([127.0.0.1]:49368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggsfJ-0003fu-CZ for submit@debbugs.gnu.org; Tue, 08 Jan 2019 09:47:39 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:36479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggsfF-0003fg-Cs for 33870@debbugs.gnu.org; Tue, 08 Jan 2019 09:47:33 -0500 Original-Received: from [192.168.1.101] ([212.95.5.3]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MACmL-1gaWrd2MG1-00BMfr; Tue, 08 Jan 2019 15:47:16 +0100 In-Reply-To: X-Provags-ID: V03:K1:eQSpeMGN7ro1sJutibpkEadbNZY05fbaar7SXJ2gCn6iE/Tnsj2 nq+lTxPotMbynw2cdaEViMcau/GPSEZ5LWvml7coKbxrqhKoTDNPLQhnBmdS+u7rQUqhWqx xSgGiw1znWcMDISQEm0bu7cCcbjHKBJfwEyjd+GEmzJlO0FmHXOLJ36yhLkJjmzWu6n9tZJ udVt34YzjdKaFj4uxC4lQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:sljNtiOBQeY=:LZszgsmZLAA+6Ehy506H/W CAeVKjoyxm0PnWAgx2Eq4y/Z/b4h6ewcok/+oCOJhzrZ8dswxV3igrR5lP8Wu5mvAdtJ44B3r KgV/cO5PbMjp9Ob1sHRHyj358cIuAsQDaPKOFe/oOeOqUcTuFkZsUoR6pcxI6korlnpt642qN L61LVDAE2We9b4yOQKZQCUNMUE7DyNjGPmiNo7HcSLhV/0aXfnT5cDXsNiJhmIvtD3SlFKoU1 Pu15SBjMygogygNiZhFtjB4AQ/cIFdu9Uvb0KAObc7dXFDeLvWJdUL0UpM5T/61YzHm2irDLO tuHRLyIolUhDr7Wk66zkig7aIKDxV+N/pjSW2elxnU3JNj9M0KBvYK1VXYdFGn9BqeCJRm1lj J0k1dxohCtzx8qLmOFAGCtqw114Lkm0b3C7Uj0bOJyPYYhmRaC4m+5AabXvCLWxPr42QjdRik YU6hy4/YTpLWSsLWxN3nZkxUSnT6IjhFVbGZqMr4f2scDs7oITvDAoE9Z03eT1SQI4KcISb3n 3mWKG3AYCgOdKxDg3xVPrKGOZYCIoM/9taE9FZEIEij3Gy6UtPg3Ige6qioSchVgKKRz1qc64 Wqm1ncYX3AogCQ0Gko4UiN4HHxe7lVGhXSwH88E20f/cNsTvNXJs/hk2G4kXdLbUlkbF3H2BF eaZt9uxvZrjvbiTZmb5/tmsxe8I8IM09/P2zU+GSMsxx75Nz2M4Z9yJrIZ7k50aA/7CPPP0i5 RCnN3nm5OlaJxBlwjOlhOc35He0xCUnSjBtB11jHVAsabuAwRpFc4ZKzV9NNApqsWHoBM1m7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154257 Archived-At: >> So before making this function public, we should resolve this calling >> convention. > > Makes sense. Then, in my view, the logical sequence to fix this bug is > > A. First do these changes to window.el and publish a decent > window-display-buffer calling convention. > > B. Push a xref.el based on the new function that doesn't change > the xref UI. > > C. Discuss the xref.el UI in the other bug. I can only comment on A and even there I have to leave the judgment to Stefan Monnier as he's our only expert on window dedication and how 'display-buffer' is supposed to handle it. But I can offer a preambulatory piece of code we could splice into the function in order to do away with the DEDICATED argument. Untested! ... (unless (eq buffer (window-buffer window)) (set-window-dedicated-p window nil) (set-window-buffer window buffer)) (let ((alist-dedicated (assq 'dedicated alist))) (cond (alist-dedicated (set-window-dedicated-p window (cdr alist-dedicated))) ((and (not (eq type 'reuse)) display-buffer-mark-dedicated) (set-window-dedicated-p window display-buffer-mark-dedicated)))) (when (memq type '(window frame)) (set-window-prev-buffers window nil)) ... > Do both of these more ambitious refactorings really need to > make it in before we can do B as outlined above? Or can we > do them later in parallel? I recommend to do these before making that function public. I don't understand B and C sufficiently. martin