From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>
Cc: 33870@debbugs.gnu.org, joaotavora@gmail.com, dgutov@yandex.ru
Subject: bug#33870: 27.0.50; xref-goto-xref not configurable
Date: Tue, 08 Jan 2019 10:24:25 +0100 [thread overview]
Message-ID: <5C346C49.6060003@gmx.at> (raw)
In-Reply-To: <87wongazxq.fsf@mail.linkov.net>
> I understand that the word “maybe” indicates it's not guaranteed that
> the function will do what it's intended to do. IOW, these functions
> are conditional.
Like 'display-buffer'. But we don't call it 'display-buffer-maybe'.
> Since we can't lightly rename old functions, I have a question only
> about functions added in Emacs 27, namely, display-buffer--maybe-at-bottom.
> Its current body:
>
> (let ((alist (append alist `(,(if temp-buffer-resize-mode
> '(window-height . resize-temp-buffer-window)
> '(window-height . fit-window-to-buffer))
> ,(when temp-buffer-resize-mode
> '(preserve-size . (nil . t)))))))
> (or (display-buffer--maybe-same-window buffer alist)
> (display-buffer-reuse-window buffer alist)
> (display-buffer--maybe-pop-up-frame buffer alist)
> (display-buffer-in-previous-window buffer alist)
> (display-buffer-at-bottom buffer alist)))
>
> I propose to remove this function and replace its parts with
> more alists, i.e. this blob
>
> `(,(if temp-buffer-resize-mode
> '(window-height . resize-temp-buffer-window)
> '(window-height . fit-window-to-buffer))
> ,(when temp-buffer-resize-mode
> '(preserve-size . (nil . t))))
>
> with something shorter like `(fit-to-buffer . t)'
Can't we add this via a special value for the 'window-height' alist
entry? Where we explicitly state that it obeys
'temp-buffer-resize-mode' if that is active and the buffer qualifies
as temporary and so on ... Or is that what you mean already?
> And also to replace a long list of display-buffer-* that is a copy of
> `display-buffer-fallback-action' with something shorter like an alist
> `(pre-action . display-buffer-fallback-action).
I'm not sure I understand you. 'display-buffer-fallback-action' is
always tried after everything else failed. Would you want to run it
_before_ something else?
>> A single window frame where the buffer is not displayed runs this
>> part.
>
> You are lucky if you can invoke its second branch. I always get only
> its third branch in all tried configurations when testing with
> completions of `C-x C-f TAB TAB'.
I now always display completions in a child frame so I never run into
practical problems with it.
> After resizing an initial frame to 12 lines, so every vertically split
> window gets 6 lines, typing `C-x C-f TAB TAB' displays *Completions* in
> the upper window, when a previous window where *Completions* was
> previously displayed was moved to the upper window, e.g.
>
> 0. emacs -Q
> 1. resize the frame to 12 lines
> 2. C-x 2
> 3. C-x C-f TAB TAB C-g ;; *Completions* were displayed in the bottom window
> 4. C-x 0
> 5. C-x 2
> 6. C-x C-f TAB TAB C-g ;; *Completions* displayed in the upper window that was previous
Your bag of tricks is fathomless :-) Basically, this means that
'display-buffer-in-previous-window' and 'display-buffer-at-bottom' are
inherently irreconcilable when a window was at bottom once and moved
upwards. We could abuse the existing 'side' action alist entry for
not-atomic, non-side windows in the following sense: If 'side' equals
'bottom', a window is eligible for reuse if and only if it appears on
that side of the frame. To be obeyed by 'display-buffer-reuse-window'
and 'display-buffer-in-previous-window', I presume. WDYT?
martin
next prev parent reply other threads:[~2019-01-08 9:24 UTC|newest]
Thread overview: 159+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-25 20:42 bug#33870: 27.0.50; xref-goto-xref not configurable Juri Linkov
2018-12-26 2:10 ` Dmitry Gutov
2018-12-26 14:48 ` João Távora
2018-12-26 23:18 ` Juri Linkov
2018-12-27 0:05 ` João Távora
2018-12-27 13:20 ` Dmitry Gutov
2018-12-27 18:08 ` João Távora
2018-12-27 21:21 ` Juri Linkov
2018-12-27 23:23 ` Dmitry Gutov
2018-12-27 23:47 ` Juri Linkov
2018-12-28 0:35 ` Dmitry Gutov
2018-12-28 9:25 ` João Távora
2018-12-27 21:19 ` Juri Linkov
2018-12-27 21:49 ` João Távora
2019-01-03 0:18 ` Juri Linkov
2019-01-03 13:50 ` Eli Zaretskii
2019-01-03 14:24 ` João Távora
2019-01-03 21:29 ` Juri Linkov
2019-01-03 22:08 ` João Távora
2019-01-04 0:07 ` Juri Linkov
2019-01-04 0:42 ` Dmitry Gutov
2019-01-04 7:41 ` João Távora
2019-01-04 6:55 ` Eli Zaretskii
2019-01-05 23:23 ` Juri Linkov
2019-01-06 9:03 ` martin rudalics
2019-01-06 20:55 ` Drew Adams
2019-01-06 23:52 ` Juri Linkov
2019-01-06 23:48 ` Juri Linkov
2019-01-07 9:03 ` martin rudalics
2019-01-07 22:02 ` Juri Linkov
2019-01-08 9:24 ` martin rudalics [this message]
2019-01-09 0:15 ` Juri Linkov
2019-01-09 10:04 ` martin rudalics
2019-01-09 23:40 ` Juri Linkov
2019-01-10 10:19 ` martin rudalics
2019-01-10 21:56 ` Juri Linkov
2019-01-11 9:24 ` martin rudalics
2019-01-13 0:33 ` Juri Linkov
2019-01-13 8:34 ` martin rudalics
2019-01-13 21:32 ` Juri Linkov
2019-01-14 7:57 ` martin rudalics
2019-01-19 20:47 ` Juri Linkov
2019-01-20 9:14 ` martin rudalics
2019-01-20 20:46 ` Juri Linkov
2019-01-21 7:52 ` martin rudalics
2019-01-21 20:59 ` Juri Linkov
2019-01-24 9:07 ` martin rudalics
2019-01-27 20:23 ` Juri Linkov
2019-01-28 18:38 ` martin rudalics
2019-01-28 20:07 ` Juri Linkov
2019-01-29 8:50 ` martin rudalics
2019-01-29 21:10 ` Juri Linkov
2019-01-29 21:46 ` Drew Adams
2019-01-30 21:06 ` Juri Linkov
2019-01-30 21:39 ` Drew Adams
2019-01-30 8:08 ` martin rudalics
2019-01-30 21:12 ` Juri Linkov
2019-01-31 8:32 ` martin rudalics
2019-01-31 21:07 ` Juri Linkov
2019-02-01 9:05 ` martin rudalics
2019-02-02 9:30 ` martin rudalics
2019-02-02 21:14 ` Juri Linkov
2019-02-03 20:22 ` Juri Linkov
2019-02-04 7:30 ` martin rudalics
2019-02-04 21:41 ` Juri Linkov
2019-02-05 8:36 ` martin rudalics
2019-02-17 21:14 ` Juri Linkov
2019-01-03 22:48 ` Dmitry Gutov
2019-01-04 0:12 ` Juri Linkov
2019-01-04 0:39 ` Dmitry Gutov
2019-01-03 22:49 ` Dmitry Gutov
2019-01-03 23:31 ` Dmitry Gutov
2019-01-04 0:14 ` Juri Linkov
2019-01-04 0:36 ` Dmitry Gutov
2019-01-04 7:49 ` João Távora
2019-01-05 23:17 ` Juri Linkov
2019-01-05 23:52 ` Dmitry Gutov
2019-01-05 23:27 ` Juri Linkov
2019-01-05 23:55 ` Dmitry Gutov
2019-01-07 14:21 ` João Távora
2019-01-07 22:16 ` Juri Linkov
2019-01-07 23:46 ` Dmitry Gutov
2019-01-08 0:23 ` Juri Linkov
2019-01-08 1:04 ` Dmitry Gutov
2019-01-08 1:04 ` João Távora
2019-01-08 9:25 ` martin rudalics
2019-01-08 11:17 ` João Távora
2019-01-08 14:47 ` martin rudalics
2019-01-08 14:55 ` João Távora
2019-01-08 14:44 ` Stefan Monnier
2019-01-08 15:04 ` martin rudalics
2019-01-08 16:06 ` Stefan Monnier
2019-01-08 17:43 ` martin rudalics
2019-01-08 20:53 ` Stefan Monnier
2019-01-09 10:03 ` martin rudalics
2019-01-09 13:14 ` Stefan Monnier
2019-01-09 13:27 ` martin rudalics
2019-01-10 10:19 ` martin rudalics
2019-01-09 0:20 ` Juri Linkov
2019-01-09 9:57 ` João Távora
2019-01-11 1:18 ` Dmitry Gutov
2019-01-13 0:41 ` Juri Linkov
2019-01-13 11:52 ` João Távora
2019-01-13 21:54 ` Juri Linkov
2019-01-13 23:06 ` João Távora
2019-01-18 2:32 ` Dmitry Gutov
2019-01-18 15:26 ` João Távora
2019-01-18 17:33 ` martin rudalics
2019-01-18 22:22 ` João Távora
2019-01-19 20:35 ` Juri Linkov
2019-01-20 9:14 ` martin rudalics
2019-01-19 20:31 ` Juri Linkov
2019-01-20 0:34 ` Dmitry Gutov
2019-01-20 20:44 ` Juri Linkov
2019-01-21 20:43 ` Juri Linkov
2019-01-22 0:07 ` Dmitry Gutov
2019-01-18 2:37 ` Dmitry Gutov
2019-01-18 15:22 ` João Távora
2019-01-18 15:35 ` Dmitry Gutov
2019-01-18 15:40 ` João Távora
2019-01-18 17:33 ` martin rudalics
2019-01-18 17:38 ` Dmitry Gutov
2019-01-19 20:45 ` Juri Linkov
2019-01-20 0:27 ` Dmitry Gutov
2019-01-20 0:31 ` João Távora
2019-01-27 20:29 ` Juri Linkov
2019-01-31 22:14 ` João Távora
2019-02-01 0:17 ` João Távora
2019-02-01 1:39 ` Dmitry Gutov
2019-02-01 7:30 ` Eli Zaretskii
2019-02-01 8:19 ` João Távora
2019-02-01 18:27 ` Drew Adams
2019-02-02 0:00 ` Dmitry Gutov
2019-02-02 0:29 ` Dmitry Gutov
2019-02-02 9:30 ` martin rudalics
2019-02-02 21:16 ` Juri Linkov
2019-02-02 22:22 ` João Távora
2019-02-03 3:37 ` Eli Zaretskii
2019-02-03 12:00 ` João Távora
2019-02-03 17:09 ` Eli Zaretskii
2019-02-03 20:22 ` João Távora
2019-02-05 18:12 ` Eli Zaretskii
2019-02-05 18:34 ` João Távora
2019-02-06 22:53 ` João Távora
2019-02-17 20:17 ` Juri Linkov
2019-02-03 21:02 ` Drew Adams
2019-02-03 20:33 ` Juri Linkov
2019-02-03 21:08 ` João Távora
2019-02-04 21:35 ` Juri Linkov
2019-02-04 23:24 ` João Távora
2019-02-05 13:44 ` Dmitry Gutov
2019-02-17 21:20 ` Juri Linkov
2019-02-22 2:17 ` Dmitry Gutov
2019-06-11 0:00 ` Dmitry Gutov
2019-06-16 0:52 ` Dmitry Gutov
2018-12-26 15:36 ` Eli Zaretskii
2018-12-26 23:17 ` Juri Linkov
2018-12-27 15:27 ` Eli Zaretskii
2018-12-27 20:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C346C49.6060003@gmx.at \
--to=rudalics@gmx.at \
--cc=33870@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=joaotavora@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).