From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#32790: 27.0.50; point jumps unexpectedly after delete-window Date: Sun, 25 Nov 2018 09:23:15 +0100 Message-ID: <5BFA5BF3.50505@gmx.at> References: <87efdnsp2k.fsf@mail.linkov.net> <87tvklx4je.fsf@mail.linkov.net> <5BEA94A7.20809@gmx.at> <87r2foa8gq.fsf@mail.linkov.net> <5BEBDDCB.6090608@gmx.at> <87va4zfapq.fsf@mail.linkov.net> <5BED38A6.6020206@gmx.at> <87ftw2q74g.fsf@mail.linkov.net> <5BEE85A5.2070309@gmx.at> <878t1ruz4m.fsf@mail.linkov.net> <5BF12FB6.20203@gmx.at> <87o9am3smz.fsf@mail.linkov.net> <5BF2858C.40207@gmx.at> <87va4szo8n.fsf@mail.linkov.net> <5BF3D3D4.1080106@gmx.at> <87pnuzz2vf.fsf@mail.linkov.net> <5BF5151B.5000201@gmx.at> <87ftvu9f20.fsf@mail.linkov.net> <5BF65D56.9020806@gmx.at> <87pnuwenpk.fsf@mail.linkov.net> <5BF7AEC5.60808@gmx.at> <87va4mdoya.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1543134132 12609 195.159.176.226 (25 Nov 2018 08:22:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2018 08:22:12 +0000 (UTC) Cc: 32790@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 25 09:22:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQpg6-00038f-Sd for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Nov 2018 09:22:07 +0100 Original-Received: from localhost ([::1]:59110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQpiD-00026H-Bs for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Nov 2018 03:24:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gQpi3-00025x-HA for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2018 03:24:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gQphy-0001z5-Ja for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2018 03:24:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gQphy-0001ys-Fd for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2018 03:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gQphy-0002mm-8W for bug-gnu-emacs@gnu.org; Sun, 25 Nov 2018 03:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Nov 2018 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32790 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32790-submit@debbugs.gnu.org id=B32790.154313421010665 (code B ref 32790); Sun, 25 Nov 2018 08:24:02 +0000 Original-Received: (at 32790) by debbugs.gnu.org; 25 Nov 2018 08:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:46033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQphS-0002lw-0m for submit@debbugs.gnu.org; Sun, 25 Nov 2018 03:23:30 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:40861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQphP-0002ld-I3 for 32790@debbugs.gnu.org; Sun, 25 Nov 2018 03:23:28 -0500 Original-Received: from [192.168.1.101] ([46.125.250.102]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lu8Ri-1fRtJ20T5y-011Um8; Sun, 25 Nov 2018 09:23:18 +0100 In-Reply-To: <87va4mdoya.fsf@mail.linkov.net> X-Provags-ID: V03:K1:K7Y2QO3ARJWtgYSrzoCZqsNpgir9UxRYfpqvwb0S2S3dwH6dDi3 PUsZsuHmaRt0bhGE3FflvvINeJs1DxdyNc9wewyC9/Z/9YlttSb+ErZ+9EoNvzTRJlSolP6 clf3iPEtTWAjRpTpQFkQi98TOOhYJW4PGpsiUjvwkUhtSXSb0ie+1RNilFzY3FpleSMnMDB nBDeb1EoQQ5sql37UymYw== X-UI-Out-Filterresults: notjunk:1;V03:K0:S400sn6ElYk=:4UW/ZBgL7nsRA3deJg6lrr QeuoC50KV8VWOovOCBC+wtywS9p+AuiGGbXvOlSOQNrkpWCYG8ZniSoDweTksABvMpIkygk6X XU7TyqO6mkTNohffbq0v0UAzTxky+PuKTZRNVUoxc+aPSRii2hHZH7v1na63sb9hgjMc+swxi 5XnItRPRAXI9Tqse8XLqzM1w87/jZ6Oz46RBmuKAf1WndeJxnBVaf0g5qPrlj5TOuxE2fbXkT VKZEQ+U9pY3SA/5dA3XhKEL9srdxfHB/UG4XuLVifZtf4eMiI6Inq9YPzQR9LBRaWlJNyPPyG ZgokWygGoHpLVHj2hafp4BAk+uIaFBEXrAg1qByzAT+ynqI4Yu72xPanDmSxNtYVM5xifvAek LTZpN8HqR6xVvi3Ly/UwonnS75VP57IF1FmCLgJYUYLiaDoHhwMlZmVL8XF3ubWgfTAEbTaZr eGM/zFgpdLOGTFSZwUOlkXxhYT9AujJa/LrTJeAmG7a6UWs2Xfrkm6vBTi/AQGG7kmr1/MBkj I9l6Lh+nd21xlmNzApyJL0x0VEPeblgOpFwErpt3FEgtTvgf21EIAY//BgIdd771PVdjaoacW 8Cf5nYqSpkzmzodKiuOw/A9CljX+iQ28um0tGteSXt9DldIWJ+g8Sz/Fl21DFYozWIUBcCKgK BYGddNlXfXzow6CagwifJZLQ4qnvilj4lW1cSdKI5QbdDWomJrMZd7gNv2eBVqE550NbjKP2Q +xh7Ju5nRdB69X/XtlmRG40kjswprqZxWra+niif0MpJfmWGuehhgjpgU+BJk1b7dpuzB9u5 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152751 Archived-At: > Do you see a problem with this implementation? If 'switch-to-buffer-pop-to' is non-nil, you nevertheless run the 'force-same-window' rigmarole although 'pop-to-buffer-same-window' might want to select a completely different window. Please explain this discrepancy unless I'm missing something completely obvious. +(defcustom switch-to-buffer-pop-to nil + "If non-nil, use `pop-to-buffer-same-window' in the selected window. Something like "If non-nil, have `switch-to-buffer' run `pop-to-buffer-same-window'." seems better. BTW, I'm already thinking of calling this option 'switch-to-buffer-pop' because '-to' somehow requires an object where to pop to and I doubt that a user will supply one. Unless we do want to allow a window here. +This allows custmization of conditional actions for `display-buffer'." ^ This option's doc would need more text, maybe a small example. + (set-window-data-p t)) Here I would write (set-window-start-and-point (not switch-to-buffer-pop-to)) (recall also that we use a trailing -p only for functions). - ((eq buffer (window-buffer))) + ((and (eq buffer (window-buffer)) + (not switch-to-buffer-pop-to))) This would show the buffer twice even when it already appears in the same window, right? Are you sure that this is TRT? Unconditionally? + (unless (eq (selected-window) selected-window) + (setq set-window-data-p nil)))) Here I would then write (when (eq (selected-window) selected-window) (setq set-window-start-and-point t)))) and here instead of + (when set-window-data-p I would use (when set-window-start-and-point BTW your patch does not apply here well due to some whitespace mismatches. Thanks, martin