From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#32720: term-mode ignores certain window size changes Date: Fri, 16 Nov 2018 13:57:51 +0100 Message-ID: <5BEEBECF.5060601@gmx.at> References: <5BDEC23D.4080707@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1542373027 9593 195.159.176.226 (16 Nov 2018 12:57:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Nov 2018 12:57:07 +0000 (UTC) Cc: 32720@debbugs.gnu.org To: Gary Fredericks Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 16 13:57:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNdgF-0002Of-2J for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Nov 2018 13:57:03 +0100 Original-Received: from localhost ([::1]:44526 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNdiL-0001t4-KJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Nov 2018 07:59:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNdiE-0001sm-RH for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 07:59:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNdiB-0002zt-1Y for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 07:59:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50586) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNdiA-0002zi-OC for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 07:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gNdiA-000866-G0 for bug-gnu-emacs@gnu.org; Fri, 16 Nov 2018 07:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Nov 2018 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32720-submit@debbugs.gnu.org id=B32720.154237309131056 (code B ref 32720); Fri, 16 Nov 2018 12:59:02 +0000 Original-Received: (at 32720) by debbugs.gnu.org; 16 Nov 2018 12:58:11 +0000 Original-Received: from localhost ([127.0.0.1]:54841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNdhL-00084q-8b for submit@debbugs.gnu.org; Fri, 16 Nov 2018 07:58:11 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:49553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gNdhJ-00084d-2u for 32720@debbugs.gnu.org; Fri, 16 Nov 2018 07:58:10 -0500 Original-Received: from [192.168.1.101] ([212.95.5.219]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LtlG5-1fN6xY3CS5-01179s; Fri, 16 Nov 2018 13:58:01 +0100 In-Reply-To: X-Provags-ID: V03:K1:mTlgWisvaTKi+gw41EEC1Hf0JxgRm46uK88JCRs4wuxRY1ysskA FV2HC+YPuYWXO2F2Ma2P9Jsi+10ciBJfxt3zTkRpmKYQhCq0RqsC6zWvTM1UdtzH7t/kZd3 9h4VDyiHATDlykNxcVjlJbgoebd+CNXAQocl/LZnE3xJdpi3WFAK2ijzI2/DFE4zskrkGej oXqxxa8xFOETtuXYsBLcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:I0nn+JCXWtE=:ZhQ5JakISFM9p/JIZmB++F yQDssy+BDYW3e6UGIrUlJSTkD2Lwaov2DlW82aoLJOxmqDjGdhnWYut8rfnDmY+Qr0EOS4Zvn ELEzbkCRs1VG2WsJ9wl7HPQqdfZxNGvzCgh43Q0qnS+NUNcO0iyLyWpJfM0e7N2OfAEWKqtFx 2Tj+SnF+AfQxM2QymKlnac/9HI7GuL9FoUPX3idH7kCXpUPnwOLjBJt7+Vyg+Of8bmRaxc8Ds 4zyKZ5u7vh9njmtlL0yIGFKb/zWxH6zTneYmW76PI8vbyGDUibi29iR2e00RiDEYTk8PcKK+K rqgaXpYVuLJvYWePbgBpuHSYntUsYgYxIuRCCQzAf4mzxXO0ciDyD8QSQ6tc+EGlwLduxS0oN w1cB7xhv9LiDF8zNqbWJxNZlQf4nRq/IJvVD3Zcdx1CBuQmPmAbkMmHWTP/qLj0U58aAXyz9S bqNdHsOvtPfyKCWJ/yVXJ7iMWjyiMMjeFd1PHW+tGW7rpjqJsrh/xI0kXergwVE7RCN9SMIrb 5UW4bsSnqpKXXr8SyU6oBOrKRo8qeaKsMouAqNM0uRCT3C1bEiZ/M3C8fPFuq2Du8Qfav7dJW hygxbJJZsPu7gtbToiCK6sMMJ+APbRnDOWZq3Dv3UR2NRDSGUxq8kWHOglowQkwf2nyQ5fYIe gzhfxVD5AS+GM6TnFtkDREob3kJdXcCzWi4jJFwtG5eBVPIvuqvH+LEQp7/mBbotS8PD2seUz uNYAIT8U7Ml9DHv7FgXWOI37ESxmhIcgWk/zeKPs00M5JPQqDoyghNtx4NzccRjgNm/x2BlJ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152453 Archived-At: > Yep, it seems to work with the patch applied. Thanks for the feedback. But after more carefully looking into the 'window-adjust-process-windows' code I am now almost convinced that your original proposal is the way to go. That is, I nowhere found in that code anything that depends on the change of the window configuration. The only thing that code is interested in is tracing window size changes which 'window-configuration-change-hook' does not handle particularly well. So if you already have run Emacs for some time with your (add-hook 'window-size-change-functions (lambda (_frame) (window--adjust-process-windows))) and did not see any adversary effects I am inclined to install that for Emacs 26.2. For Emacs 27 I would then (after the release of Emacs 26.2) remove the (add-hook 'window-configuration-change-hook 'window--adjust-process-windows) call. Eli would that be OK with you as well? I'd still have to amend the doc of 'window-configuration-change-hook' but the net change would be considerably smaller than the one I proposed in the other thread. martin