From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#32790: 27.0.50; point jumps unexpectedly after delete-window Date: Thu, 08 Nov 2018 09:52:55 +0100 Message-ID: <5BE3F967.8080809@gmx.at> References: <87efdnsp2k.fsf@mail.linkov.net> <87in1phhx2.fsf@mail.linkov.net> <5BD2C52E.2060607@gmx.at> <87ftwrgwp2.fsf@mail.linkov.net> <5BD57A8D.8080408@gmx.at> <875zxmx95h.fsf@mail.linkov.net> <5BD70F14.8080509@gmx.at> <87lg6g750v.fsf@mail.linkov.net> <5BD81D97.2000000@gmx.at> <87bm7bru1c.fsf@mail.linkov.net> <5BD963C8.9090905@gmx.at> <87h8h195ki.fsf@mail.linkov.net> <5BDAC159.1060008@gmx.at> <87muqsh11q.fsf@mail.linkov.net> <5BDC0E81.1050806@gmx.at> <87tvkwh4bp.fsf@mail.linkov.net> <5BE00F12.5000703@gmx.at> <87d0rjuq8c.fsf@mail.linkov.net> <5BE15552.4040507@gmx.at> <87y3a5rgm2.fsf@mail.linkov.net> <5BE2AF28.2020505@gmx.at> <877ehowp0c.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541667161 20338 195.159.176.226 (8 Nov 2018 08:52:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2018 08:52:41 +0000 (UTC) Cc: 32790@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 08 09:52:37 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKg3I-00059G-6x for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 09:52:36 +0100 Original-Received: from localhost ([::1]:55058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKg5O-0002qI-Pg for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 03:54:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKg4m-0002XK-54 for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:54:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKg4i-0002jG-Qr for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:54:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36001) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKg4g-0002hK-5v for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKg4g-0000LX-2J for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Nov 2018 08:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32790 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32790-submit@debbugs.gnu.org id=B32790.15416671911244 (code B ref 32790); Thu, 08 Nov 2018 08:54:01 +0000 Original-Received: (at 32790) by debbugs.gnu.org; 8 Nov 2018 08:53:11 +0000 Original-Received: from localhost ([127.0.0.1]:40253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKg3q-0000K0-VC for submit@debbugs.gnu.org; Thu, 08 Nov 2018 03:53:11 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:58913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKg3p-0000Jo-Qa for 32790@debbugs.gnu.org; Thu, 08 Nov 2018 03:53:10 -0500 Original-Received: from [192.168.1.101] ([212.95.5.129]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MRTiG-1fwMnk03M8-00ScLf; Thu, 08 Nov 2018 09:53:00 +0100 In-Reply-To: <877ehowp0c.fsf@mail.linkov.net> X-Provags-ID: V03:K1:BHw10Vk7yRcRS+c1WRiqs8+qNKoJCl7z08TIImeuRg4wYqDcBdH c+KyV8RiL5gHOt97K7y09qVAfOs2kWVCgtMsNV6bySYeJU7WS+312iFkfZIlHXhguQVF9zx 2RktUVUx4YML9fLEKfkCkg9RNuEbz7Lq4ljzgP3aSgLvfsdcMBuNOgSKQShP2aE8HpKWjoL kyxbsl3IUX6aP9YgnioHw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ki6QHR+jqbI=:zUNZlXP/RHH5FDYStv1+42 /9b5bupSjg3fqgaws5FOoIvhUZnkXHlvjOrMZHOVIWsbZNj5Y0e+9QCXVohlWmJAKVRWGG56z zGCEu2c9FEG5hHvQMsX7KahS/xvxceGRJrj1vDW4QizV8ImfrtlijL+ZMRqH7Xmsehyw8f8al Q3+WPXRjLxyj3lc3bsPGt9geY435gytcvCJ9hdRPngKs6a6qyszUEmvq75iJxsvcOjoIulQNg GLLrJr/r1EUGUo3WMj77MKdpw9bvNzQl9JGEOO7PON1IiVdp1ipwluiOUwHc+iqxu2xO9qAc1 Gn6GChA5oBkxJ2QGC9vqsyhpS1BivFJSHm4dsBQGq/vN8PT7njz/uB7dj01u6vFnybkD2n1P5 e/Rzi2E1mpLmjPhcb+iPDx4f1MFI1lUwcMN48Xf61tZQvHslgn3o/DnfGmgtDZ4omBUnaaccb qoMyV8bGsNg3quwVK/sEe4DkBaCe5m/uCq8Oe3Za7VgsayLPGB7BZg3NQI1gvBTtaY8WNTys6 xYGMj+alvdbq1gnmHsdfLVgMYdJYPNDBEddQRD6V9cHVex+rSH28eeAClQ/HS3JIssM7VE9Zw NLR79g9/8JQp7nqJKVksW7LCm05nCi1sP0IvYM39HTDibtUpuvTaxzRl4cpsIsPfhiZbzzQTr QZZqpKU+gX716Ph1U1+DOBofqgmQakkK7DbqmF3vdQgMBDcAt65emm6nZkgwYPSVdgK4X9wAR di8ZOUpnK1IR8acx8CZqBir4OxQeodhF0fNvNcRn2KLQQhDbGSInGPCd8OR3jGfxoS750K+E X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152151 Archived-At: > Shouldn't xref support a shorter and easier to type key sequence > =E2=80=98S-M- M-.=E2=80=99 with the following patch: > > diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el > index 6b1421a6f7..6aab174bcf 100644 > --- a/lisp/progmodes/xref.el > +++ b/lisp/progmodes/xref.el > @@ -425,7 +425,7 @@ xref--pop-to-location > (xref-location-marker (xref-item-location item)))= ) > (buf (marker-buffer marker))) > (cl-ecase action > - ((nil) (switch-to-buffer buf)) > + ((nil) (pop-to-buffer-same-window buf)) > (window (pop-to-buffer buf t)) > (frame (let ((pop-up-frames t)) (pop-to-buffer buf t)))) > (xref--goto-char marker)) I think so. In particular because 'xref--goto-char' does not cohabit well with 'switch-to-buffer-preserve-window-point' in the first place. Dmitry should consent, though. > Then maybe all unused code should be removed including > windmove-other-window-loc, windmove-reference-loc, > windmove-wrap-loc-for-movement, windmove-constrain-loc-for-movement, > etc. Citing from a discussion with Dmitry: > I thought you might go ahead and just port windmove to use > `window-in-direction'. windmove has an extra ARG to distinguish the upper left corner of a window and its position of point as reference points. I can't easily dismiss that. I'm not sure whether it's still relevant but if so we'd have to include it in 'window-in-direction'. martin