From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Tue, 16 Oct 2018 10:47:04 +0200 Message-ID: <5BC5A588.9040001@gmx.at> References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B504994.3090202@gmx.at> <5B5199F7.7000303@gmx.at> <5B51D6C4.9030006@gmx.at> <5B52E425.8010608@gmx.at> <5B543148.1010004@gmx.at> <5B557ACA.4020106@gmx.at> <5BBF93CF.4060301@gmx.at> <5BC05EEB.9010609@gmx.at> <5BC0E405.90805@gmx.at> <5BC1AAE2.7070808@gmx.at> <5BC4DB0E.3050501@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1539679571 30314 195.159.176.226 (16 Oct 2018 08:46:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Oct 2018 08:46:11 +0000 (UTC) Cc: 22000@debbugs.gnu.org, David Engster To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 16 10:46:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCKzM-0007kj-Re for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Oct 2018 10:46:05 +0200 Original-Received: from localhost ([::1]:56579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCL1T-0005hO-63 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Oct 2018 04:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCL1K-0005hF-0R for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2018 04:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCL1G-00089E-M0 for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2018 04:48:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47523) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCL1G-00088s-Cq for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2018 04:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gCL1G-0002Ds-7M for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2018 04:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Oct 2018 08:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.15396796468500 (code B ref 22000); Tue, 16 Oct 2018 08:48:02 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 16 Oct 2018 08:47:26 +0000 Original-Received: from localhost ([127.0.0.1]:51781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCL0g-0002D0-7y for submit@debbugs.gnu.org; Tue, 16 Oct 2018 04:47:26 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:57003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gCL0e-0002Cn-14 for 22000@debbugs.gnu.org; Tue, 16 Oct 2018 04:47:24 -0400 Original-Received: from [192.168.1.101] ([212.95.5.116]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LgvEY-1fpdFb45eI-00oCFD; Tue, 16 Oct 2018 10:47:10 +0200 Original-Received: from [192.168.1.101] ([212.95.5.116]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LgvEY-1fpdFb45eI-00oCFD; Tue, 16 Oct 2018 10:47:10 +0200 In-Reply-To: X-Provags-ID: V03:K1:sb0qWyfRQCf9eA+0Myyp9Cvfc0LZWEIaXUyecuCcd76noKJr+In 0ynjiHL+pTdSDSLRC95SAyP6DzB2G9l4kZbszvqoll8dAvICMi4FtTTE7n6eKOPnQCb/QZf 2RtWrYXxrx4ZygOgasSzUV5TYnXVD7mfqIgbdCfHYtLUB/GcghnIMcFWK24Bl4IizDUB2BO E8hLohSWVHI2NallMeKBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:xvd2z8a3pHo=:MxyHNngLJuS/xrlFX5ViGz k150/f/JkaIR0Z+3sFAi6/ZcUDOGz9gechMIRZRMyg8HDPejigIyuF4AOKK6a0107+HKQIzGv +lp/AxYG3nu+SY616ZzZT3mYWdCTyoEgodJjC84RVmC5MaNmxoSiRDUnjUNh46COlh2m+decC xrj+qZ7VSKpQeI5sqvkwUx+/TxMEhHxdji+e9m9q9nqx87/XOdXqFNL3xhTmyACVQ+wdgsuyX i/yqMV/EHPnEOuxykBYAY8vptYGlJ+fRTIagIuxf8fFX2Wlsff+mdlLzqM8Lv+bVhk3NU7GxG VwIwlqB1w/rGCQ2P4K6EuW0pVdZLfnseQOsqaGxh1cVhpZDwyRr52KcH1pBzp7OZH36gJmCk7 mxFYhEwSJZyUV0YFl4ySubxnmf5NRVu7IiHPTFqQZkN4/yJZmg+gzFJRFrQJy/Gp2YrDEGX/B ZWNpnROlHT5ljkILrYmCoo+54qAX+eS+S2WgoLzpp85N1GiqRPTFyFq75NC7Is16l1HV0UcIn zdMIBYtNAnE7+flu2XwnhKg5ZPojZRZT49S+7ze7vonhJWiVmwBIsJFKZCi7P8s9Z6wS+iOZ5 gMgG2AJUsDMwzLgM0NaKCFQYZGrNQf8+S3YXWYSH1ihT4u+aisXVWbs8oZdHNbQyY1pdPx2NA 0Q5FofmpVeFmLtLI3OZr5GQUVFzUYeKF4jZS3p7NV+0ehu7cy/GSGbcvwP4L9I2DIxDTwfnd6 l75uj/ezapvHXDc6AcDXSYiFYFKG/Su49hadRMPO5Hnbo+RXfCkZJNqoOR7WeQEimq4eoEpf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151303 Archived-At: > Assuming nil behaviour = menu bar is truncated when too wide but > has no scrollbar and no extra padding - GTK < 3.16 can't do this > without either implementing a custom widget or providing the > equivalent of GTK_POLICY_EXTERNAL. > > 3.16+: > always - scrollbar always present, menu bar would be vertically > padded but we compress it with CSS > automatic - similar, but scrollbar disappears when not required > forced-resize - no scrollbar and no padding. frame will resize > semi-predictably when the menu bar's natural size > exceeds that of the frame. > nil - no scrollbar, menu would be vertically padded but > we compress it with CSS. menu bar is truncated > if it tries to extend past the frame edge. > > 3.16-: > always - scrollbar always present, menu bar is vertically > padded. does not appear to bepossible to fix > this with CSS. > automatic - similar, but scrollbar disappears when not required > forced-resize - no scrollbar and no padding. frame will resize > semi-predictably when the menu bar's natural size > exceeds that of the frame. > nil - identical to forced-resize for these GTK versions Good. We could for the 3.16- nil case do what you did earlier with the extra padding but I think that having this as default would harm more than do any good. So let's stick to this your proposal - it's the most sane approach I can think of at the moment. > To clarify - a user can _try_ to manually resize the frame but sooner > or later (usually sooner) the gdk timer fires and gtk notices that > the menu bar wants more space and resizes the frame. Depending on > your exact GTK version and the phase of the moon you _may_ be able > to dodge this forced resize but you cannot reliably do so. Yes. I forgot about this timer issue. >> of the Options menu. Provided we can add/remove a menu bar scrollbar >> dynamically to/from an existing frame. No great harm if we can't > > We can, I've been testing this to make sure it works. Fine. > Currently working on updating the patches to address these points (and the others to which I have not replied specifically here) - will probably > send an updated series tomorrow (2018-10-16) We'll then have to discuss with Eli whether to apply this to Emacs 26.2 or to master. Thanks, martin