From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Sat, 13 Oct 2018 10:20:50 +0200 Message-ID: <5BC1AAE2.7070808@gmx.at> References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B4EE5AF.5000304@gmx.at> <5B504994.3090202@gmx.at> <5B5199F7.7000303@gmx.at> <5B51D6C4.9030006@gmx.at> <5B52E425.8010608@gmx.at> <5B543148.1010004@gmx.at> <5B557ACA.4020106@gmx.at> <5BBF93CF.4060301@gmx.at> <5BC05EEB.9010609@gmx.at> <5BC0E405.90805@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1539418810 19368 195.159.176.226 (13 Oct 2018 08:20:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 Oct 2018 08:20:10 +0000 (UTC) Cc: 22000@debbugs.gnu.org, David Engster To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 13 10:20:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBF9W-0004ql-OR for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Oct 2018 10:20:02 +0200 Original-Received: from localhost ([::1]:44152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBFBd-0005of-BD for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Oct 2018 04:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBFBX-0005nw-M2 for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2018 04:22:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBFBS-0001l2-O2 for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2018 04:22:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBFBS-0001jX-Iq for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2018 04:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gBFBS-0006s5-Dr for bug-gnu-emacs@gnu.org; Sat, 13 Oct 2018 04:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Oct 2018 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.153941886726348 (code B ref 22000); Sat, 13 Oct 2018 08:22:02 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 13 Oct 2018 08:21:07 +0000 Original-Received: from localhost ([127.0.0.1]:47712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBFAZ-0006qu-K7 for submit@debbugs.gnu.org; Sat, 13 Oct 2018 04:21:07 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:52941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBFAY-0006q6-7a for 22000@debbugs.gnu.org; Sat, 13 Oct 2018 04:21:06 -0400 Original-Received: from [192.168.1.100] ([213.162.73.245]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUYiV-1g2kgi32lH-00RICD; Sat, 13 Oct 2018 10:20:51 +0200 Original-Received: from [192.168.1.100] ([213.162.73.245]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUYiV-1g2kgi32lH-00RICD; Sat, 13 Oct 2018 10:20:51 +0200 In-Reply-To: X-Provags-ID: V03:K1:ih3skM9zYkq5PNHC3QXIqhJHW093jcSqXrYXs/7OlWUR427ZTgO 613HYULh7rboQcPEkQ/YhEfS9CBF88qXlAu0cavTDhEcTDJhuzvH/8JqbXJfV/Z7Wu/RDQc RQOnsmRV5WTsC1+WgJ18oDUa/vGkbxMHLI64QucTa/DwlgIbLA/c7ieV5uR88OckNYoNX5O ZP5Mnu/l76U0ivpHLbY9Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:YloIODPw3Fs=:apvLNZLNqvmQMBQ7D04886 EXY/tGcseFlqhoBJtkTDahv4rIqTiajaf4Kv+ZLSh0aNbRbA4JuCa0mK4lVAq6vflOAzO8QHi MDHin3WeeUtIAwtndwYsbMsnA2BHBmiZfKg+F5Zq3V9fb0hN53i6MHhK6+trgEX9c5ah7VDfB MQsVv4vjEV5002WD90MnXxKsEIngTDReLZsG9tc7gVkg6v4+e3DRIvmlrtpjyPkeKckwJ6GZH ofEp/FoA8VVBupea4HdUSsXYLEnttUVhs8thW3z4Lj5/HfDVRUhPEZvIAJeUj0qQnedRYpuDr L1XEWNwh6BDMSJavTqyR9pwBozgxrN3NA+aCHbTEEgsf+tuLI0ITExXRxyd98D5e52jE3JdCh ma9R5q2x9599SLGbTTW2q4OmSkVwYridgGs0riB44u92277W0JBfUpJCKNnfz8Cc89AkWLbSi 15dYsluockEMaG5WRx7rWLFcwuCoQmyCFsM1bz1QWbXkneeun+85db1Ipv90sU7ZSyeLOo/JA ed4VtX7eU5Zc90VZXDvrH5ejY8RtleLyPHHuhApsEsLKSmyZ1VzC5aaXdn7V0sMvVUrq/Mbek SVq7QGqFcSbbQuwDoO8QiA8cZKk6KqRfk/UmQ6pd7aI9JRb4TMPXyYRgQrLqGxkIJeNDhZT2d wJgCu9un+69zrRekw4tFJ5aFWqXEOqzbgN7dBUCgGAwr/XyLy5vGMMUFBbg7cIFbDBBpRm5nX P0J64zV8zDFcxrZxESocuxbkfQ4/TOZ7CCNKeKVmGJDZkI6uIW0QcUQCSJnaGdYx7tlpt2TL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151199 Archived-At: >>> I might be able to fix it with a style change, if I can defeat the gtk3 >> docs >>> and figure out if/how to set a style property on a widget. >> >> Let's postpone that for the moment. > > It's done, see latest patchset. Commented below. >> Anyway, the primary warning I see is the following: >> >> (emacs:4182): Gtk-WARNING **: gtk_scrolled_window_add(): cannot add non scrollable widget use gtk_scrolled_window_add_with_viewport() instead > > Aha! I think I know what's happening. You used to have to add the viewport > manually for widgets that weren't inherently scrollable. I'll add > some #if guarded code for the earlier GTK versions. With that code it works with the non-compact series without warnings and error messages under GTK 3.4.2. However with the compact series I can't compile because GTK_POLICY_EXTERNAL is undefined for versions less than 3.16.0. If, to fix that, I do + switch (scroll_policy) + { +#if GTK_CHECK_VERSION (3, 16, 0) + case GTK_POLICY_EXTERNAL: +#endif + case GTK_POLICY_NEVER: + gtk_style_context_remove_class (style, "mbscroll"); + gtk_style_context_add_class (style, "mbtrunc"); + break; + default: + gtk_style_context_remove_class (style, "mbtrunc"); + gtk_style_context_add_class (style, "mbscroll"); + } then there is no compaction - at least by default. Is there a parameter I would have to set via 'default-frame-alist' here? Thanks, martin