From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles Date: Tue, 02 Oct 2018 09:39:54 +0200 Message-ID: <5BB320CA.5090606@gmx.at> References: <5BADDC88.7010206@gmx.at> <5BB10CCE.4020503@gmx.at> <5BB1DBF0.5060706@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1538465948 1596 195.159.176.226 (2 Oct 2018 07:39:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2018 07:39:08 +0000 (UTC) Cc: 31240@debbugs.gnu.org, charles@aurox.ch To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 02 09:39:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7FGq-0000KM-4E for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Oct 2018 09:39:04 +0200 Original-Received: from localhost ([::1]:42156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7FIw-0006bK-Lq for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Oct 2018 03:41:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7FIp-0006bE-E4 for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 03:41:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7FIk-0000QK-SB for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 03:41:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7FIk-0000QF-MI for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 03:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g7FIk-0008Au-IX for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 03:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Oct 2018 07:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31240-submit@debbugs.gnu.org id=B31240.153846601431360 (code B ref 31240); Tue, 02 Oct 2018 07:41:02 +0000 Original-Received: (at 31240) by debbugs.gnu.org; 2 Oct 2018 07:40:14 +0000 Original-Received: from localhost ([127.0.0.1]:33719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7FHy-00089k-6e for submit@debbugs.gnu.org; Tue, 02 Oct 2018 03:40:14 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:42729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7FHw-00089V-Hb for 31240@debbugs.gnu.org; Tue, 02 Oct 2018 03:40:13 -0400 Original-Received: from [192.168.1.101] ([212.95.5.220]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKYpv-1g7Wna2DG3-001zO5; Tue, 02 Oct 2018 09:39:57 +0200 Original-Received: from [192.168.1.101] ([212.95.5.220]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKYpv-1g7Wna2DG3-001zO5; Tue, 02 Oct 2018 09:39:57 +0200 In-Reply-To: X-Provags-ID: V03:K1:c6BEKtvFhwffqPmmKpTFOIkv4L5pyy0/wqHWgG9fnPN+s/zwD6u f7QQDCqCQpUnBuV76SeveIBtjsRKydXPt5e1dQT4r81DzkNRPf4WgP7VBt9nhHgwJkMm9W4 9YiFaSjypA21bzzQsFKT3+87AUA1q+7/MTCAHcaAT6sAo/evMxDR6nfS0Ho5q3Ad+KyXSiz 2zb2HPHSNOFgZBUaxL39A== X-UI-Out-Filterresults: notjunk:1;V01:K0:jDysCFaM26w=:LI+5eiA+E0ykh2e6puLVXG 5Jf8FMkLugR20oM1xofCUkoMmRaxcn6JUtLppJPNIXt/4qNsNcGPcc2EP72r0J4O0suPF9L2d vEZjU+xutCj5MYe7o1+Au9y2Xf+1ijXM2WmT5QI/0eM2fL/s+C64PShlzi3vEAA3bVl8qpThX 9toabvdNjqB8XWhEXJ66uqEoUprclW0eG14EVudboxjz6h2tCzV40vfHqlMx9O0c0R/KsMCX+ 3oOa5JiNYZhH9QyRWCpt1wtUwjOKH39p8vs4N5ya6RxEF5VBRIvgrA5Afw1zYB65ZGC3yJBZh Sti42E98kCL7aZuGUiXhVAqX11EsStSYWu9a2m1EdHzv18AEqaIPrxDJr/lKOYe++wo8yf9b1 qb/d81ATjiufcia/H/Q85A0+rPvldffoFAFn4L5SvfT8/PSJCUbqd+x4kfJESd2qnWmTjZgtG i9CpJcLuRLuV1DXqMoSNNe95gjOXNqrP7X4ZVOY3ArO32hLTRF14Id/M41fH/CmuNo11SO48w 4cF2x26FTbavsSknYqpFNVGaCHwprcCg8A2tDtbbSC9jtU1xnI55QjJjkPInNDedzwL3ftL8o uZ94SMw44lFMFw58WawW6sJzUk0v4ctKy8TqfwdAtoyj/1J6sciEPQoI9lDQRw45GXrUuXfnA Kdm9jFaARsXC8z0jmEAvfJxmaNHOV21gwwgvmKk5hlSVBx+LB+9dZ+H2bDrUoDv9mkWmJd+Y8 56qDnvcTc48PXn5ORI/yKYNXCqSoGcNr08pveNqM6DmlXcDWDDwQfeoHmxFiNMnI1ilIqzsP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150899 Archived-At: > While fixing the mistake, I found the function line-number-at-pos, > which uses the same method I was using (after your correction) to > calculate the line number. I'm attaching a new patch which uses this > function instead. OK. I'll install it in a few days if there are no objections. BTW 'line-number-at-pos' is overly complicated, there is no need for 'start' in it, it should simply do (save-excursion (goto-char opoint) (forward-line 0) (1+ (count-lines (point-min) (point))))))) instead. > Slightly related question: is it better for me to keep sending patches > with all my changes and fixes included, or is it better to send an > initial one, and then send additional (smaller) patches with fixes to > the first one? Personally, I prefer "patches with all changes and fixes included" because that makes it easy for me to throw them away immediately and resurrect them any time later. martin