From: martin rudalics <rudalics@gmx.at>
To: Federico Tedin <federicotedin@gmail.com>
Cc: 31240@debbugs.gnu.org, charles@aurox.ch
Subject: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles
Date: Mon, 01 Oct 2018 10:33:52 +0200 [thread overview]
Message-ID: <5BB1DBF0.5060706@gmx.at> (raw)
In-Reply-To: <CAA8GjPnVsWgqvv-xxP=ppkVoy96gcV5JG5-hfq8gv1Zvb-Q_bg@mail.gmail.com>
> The problem with using just (count-lines (point-min) position) is that
> the return value
> is different when the point is on column 0 and when it is on column 1
> or greater.
OK. (count-lines (point-min) (point-min)) returns 0 because START and
END are equal so let's assume you want to special-case that. Now the
problem with your code is that
+ (line (progn
+ (forward-line 0)
+ (count-lines (point-min) position))))
probably doesn't do what you expect: The value of POSITION in the call
of 'count-lines' is the _same_ it was before the 'forward-line' call
because 'forward-line' only changes the value of point but not that of
POSITION. So if you want a possible return value of 0 you have to
write
+ (line (progn
+ (forward-line 0)
+ (count-lines (point-min) (point)))))
instead.
> I
> needed to be sure that if the position was anywhere on line N, the
> result was N (with
> N starting at 0).
Agreed, once more. You want to special-case POSITION on the first
line of the buffer. But go the ends of the following two forms and
type C-x C-e on each:
(let ((position 3))
(save-excursion
(goto-char position)
(forward-line 0)
(count-lines (point-min) position)))
(let ((position 3))
(save-excursion
(goto-char position)
(forward-line 0)
(count-lines (point-min) (point))))
Here the first evaluation gets me 1 and the second 0. I suppose it's
the latter you want.
martin
next prev parent reply other threads:[~2018-10-01 8:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 18:35 bug#31240: 26.1; mouse-save-then-kill does not kill rectangles Charles A. Roelli
2018-08-20 2:26 ` Federico Tedin
2018-08-30 20:06 ` Charles A. Roelli
2018-09-12 0:39 ` Federico Tedin
2018-09-12 18:14 ` Charles A. Roelli
2018-09-22 20:05 ` Federico Tedin
2018-09-23 10:16 ` Charles A. Roelli
2018-09-23 22:23 ` Federico Tedin
2018-09-24 20:04 ` Charles A. Roelli
2018-09-26 0:33 ` Federico Tedin
2018-09-27 20:34 ` Charles A. Roelli
2018-09-27 23:45 ` Federico Tedin
2018-09-28 7:47 ` martin rudalics
2018-09-29 23:18 ` Federico Tedin
2018-09-30 7:59 ` martin rudalics
2018-09-30 15:45 ` Charles A. Roelli
2018-09-30 16:20 ` Federico Tedin
2018-09-30 17:18 ` Eli Zaretskii
2018-09-30 17:50 ` martin rudalics
2018-09-30 18:25 ` Federico Tedin
2018-10-01 8:33 ` martin rudalics [this message]
2018-10-01 21:34 ` Federico Tedin
2018-10-02 7:39 ` martin rudalics
2018-10-02 12:37 ` Federico Tedin
2018-10-02 13:17 ` martin rudalics
2018-10-04 2:56 ` Homeros Misasa
2018-10-05 6:57 ` martin rudalics
2018-10-05 9:28 ` Tak Kunihiro
2018-10-05 12:15 ` Federico Tedin
2018-10-06 17:08 ` martin rudalics
2018-10-06 20:16 ` Federico Tedin
2018-10-07 6:17 ` martin rudalics
2018-10-08 10:25 ` Tak Kunihiro
2018-10-08 23:18 ` Federico Tedin
2018-10-09 7:43 ` martin rudalics
2018-10-10 6:19 ` martin rudalics
2018-10-12 0:42 ` Federico Tedin
2018-10-12 8:44 ` martin rudalics
2018-10-12 22:08 ` Federico Tedin
2018-10-13 8:18 ` martin rudalics
2018-10-13 14:01 ` Federico Tedin
2018-10-15 7:56 ` martin rudalics
2018-10-17 7:28 ` martin rudalics
2018-10-19 0:02 ` Federico Tedin
2018-10-19 7:40 ` martin rudalics
2018-10-19 12:53 ` Federico Tedin
2018-10-11 2:14 ` Tak Kunihiro
2018-09-29 10:07 ` Charles A. Roelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BB1DBF0.5060706@gmx.at \
--to=rudalics@gmx.at \
--cc=31240@debbugs.gnu.org \
--cc=charles@aurox.ch \
--cc=federicotedin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).