From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65051: internal_equal manipulates symbols with position without checking symbols-with-pos-enabled. Date: Wed, 9 Aug 2023 20:45:58 +0200 Message-ID: <5B511686-67B7-40A3-971A-E5089B1D9A18@gmail.com> References: <2F680A0A-54B5-42C2-B27B-4E5C6332517A@gmail.com> <65A42652-DB4A-4FA6-8ADA-0D5BEB00F54C@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38044"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65051@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 09 20:47:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qToDN-0009gd-DK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Aug 2023 20:47:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qToD1-00007R-Tz; Wed, 09 Aug 2023 14:47:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qToD0-00007H-L1 for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 14:47:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qToD0-0002Z1-Cu for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qToCz-00059S-VF for bug-gnu-emacs@gnu.org; Wed, 09 Aug 2023 14:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Aug 2023 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65051 X-GNU-PR-Package: emacs Original-Received: via spool by 65051-submit@debbugs.gnu.org id=B65051.169160676919739 (code B ref 65051); Wed, 09 Aug 2023 18:47:01 +0000 Original-Received: (at 65051) by debbugs.gnu.org; 9 Aug 2023 18:46:09 +0000 Original-Received: from localhost ([127.0.0.1]:40507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qToC8-00058I-T8 for submit@debbugs.gnu.org; Wed, 09 Aug 2023 14:46:09 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:50589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qToC7-00057f-6M for 65051@debbugs.gnu.org; Wed, 09 Aug 2023 14:46:08 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4fe48a2801bso94030e87.1 for <65051@debbugs.gnu.org>; Wed, 09 Aug 2023 11:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691606761; x=1692211561; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=8B7/5eEbJXBAtbY32qZ/x6HOSxpLnJElO3uQfNUJdrY=; b=InXDivvovbuEW/fvmonQ3tse+M1z5TZtD3mFMtq2HB+RHRpHewHc5mZB12/YeHQf49 kuMXo8H6P3+F8M0dg0zCruJpGkN1XnDXA4eztyMBKkf7MjZHArpRJHTvjrzutM6OngiS 37DkmFVIXpBAZ7dZJC/fcyBXEdexIPz4X68sthF1Fk1XvAxVywtzJWmtZMgCrtfUAwVn /50n/7NOVwf5+wRjktRp6BBRZu3PZ4DqK/QVf6AVTvlrDlJxTQAahIfKWd2CEnLRbhhC eEXTWKsOpD4JZ1ae4bdkSnBrbApngDPuFyqqfk2XzZKEEUU984f+ydXS4dC2HlCPNhqJ RGdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691606761; x=1692211561; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8B7/5eEbJXBAtbY32qZ/x6HOSxpLnJElO3uQfNUJdrY=; b=WIBu2c6wfLFz108M40ZsQ5wSEjaRlcg97Z2NZWPnZ/hoGtwKOp/lyP4EzDgNYYN+x/ gh+frjDGkOIGxtTGX2xs4E42pvnLSQxFii8DjToJEH235Yr6e3XobqEd8AjdH+s2VA43 TOkpuQtTOPiB2S7S38HBVq++v5aoN5z4tXwIj11pw1gLUQumwotg7e3M3xnTb3eK/qjR z/4uy5TiOfQLl5gd3+Ntn/3CwZ+ZOFvxu3PtKB5fimkz8hKE/OitO7GdL/WKS2irN/2w ovR/xC8hJ8pCmgdV1FUNYyFzmtreoCJ7VZiH2IKu3yLcCp5sx/46sjC7UHYARIi38z60 TPEg== X-Gm-Message-State: AOJu0YwWTsgp2acXury4kmCC37Viqf0ZJB8LrQvrP5ghCaG36/Ujfy/P I6XNcWHtBSln+iZ9S4SHcW0= X-Google-Smtp-Source: AGHT+IEIX2ISNP2iWEl3fvh2iEbqZOYd5rKihigQvxq7ecOfNyodM4O2btvMFml0EaruMlmW5KP8mg== X-Received: by 2002:a19:8c06:0:b0:4fe:2ac1:4151 with SMTP id o6-20020a198c06000000b004fe2ac14151mr2251022lfd.63.1691606760851; Wed, 09 Aug 2023 11:46:00 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id y3-20020ac24463000000b004fddddcf5e7sm2409768lfl.91.2023.08.09.11.45.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Aug 2023 11:45:59 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267061 Archived-At: 7 aug. 2023 kl. 11.44 skrev Alan Mackenzie : >> Oh that part is perfectly fine (thank you), we just don't need to say >> that the sympos objects are stored "like vectors" -- that just = confuses >> the reader. >=20 > Why not? It's true, and I doubt it will cause confusion. I think we > need to say something positive in that place (since we're following it > with a negative). Perhaps you could suggest an alternative. What I meant is that sympos objects are not at all like vectors in that = they aren't mutable, indexable, readable, they can't be used with = aref/aset, can't hold arbitrary values, don't form sequences, and so on, = so it makes sense that we try finding another description. What about = some variation on: A @dfn{symbol with position} is an immutable object consisting of a @dfn{bare symbol} and a position, a natural number. (You can probably do better.) >> I meant that the components of equal sympos objects aren't merely = equal >> but identical. (This is a very minor quibble; you can keep the text = if >> you like.) >=20 > The current proposed text has a more subtle intention. It says that = eq > and equal behave just like they always have done for everything when > symbols-with-pos-enabled is nil. No, I just meant that the components themselves in equal sympos objects = are eq, not just equal. But this isn't important. >> If the compiler transforms (eq foo1 foo1) into t then the test won't >> actually exercise the implementation of `eq`. >=20 > Ah! You're talking about the tests. OK. In my tests, I timed (equal = a > b) where a and b were variables which were either equal or not. As a matter of fact I went ahead and added the aforementioned = optimisation. It is something I had wanted to do for quite some time = because code like (eq VAR VAR) does occur from time to time from = macro-expansion etc.