unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Mike Kupfer <mkupfer@alum.berkeley.edu>
Cc: kurn@sfu.ca, 32002@debbugs.gnu.org, npostavs@gmail.com, rpluim@gmail.com
Subject: bug#32002: 24.4; Scroll bar start, end not correct
Date: Mon, 09 Jul 2018 10:34:35 +0200	[thread overview]
Message-ID: <5B431E1B.2030800@gmx.at> (raw)
In-Reply-To: <5089.1531100575@alto>

 > To clarify: this was after I managed to get the steppers to appear and I
 > clicked on the up-stepper.

Does the slider of a one-line window's scroll bar also expand into the
other window's scroll bar when you remove the steppers?

 > If I click in the whitespace that I mentioned (no steppers, no slider),
 > nothing happens (the breakpoint is not triggered).
 >> M-: (setq window-min-height 1) RET
 >> C-x 2
 >> M-: (window-resize nil (- 2 (window-height))) RET
 >>
 >> This should get you a one-line window on top of the frame.  Here this
 >> window has just two small stepper buttons and no slider.  Hopefully,
 >> yours is the same.
 >
 > Unfortunately, not.  I initially get whitespace where the scrollbar
 > should be.

Hmmm...  yes.  With GTK the scroll bar is not drawn when the minimum
slider height exceeds the window height.

 > If I change the theme a few times, I eventually get stepper
 > buttons, but the slider is included, and it all extends down into the
 > second window (see attached).  (This is with the emacs-26 branch, built
 > July 4.)

Good catch!  Apparently, our default value for the minimum height of
windows usually prevents people from seeing this.  Obviously

xg_update_scrollbar_pos (struct frame *f,
                          ptrdiff_t scrollbar_id,
                          int top,
                          int left,
                          int width,
                          int height)
[...]			
       gtk_widget_style_get (wscroll, "min-slider-length", &msl, NULL);
       bool hidden = height < msl;

is not TRT because we do not account for the sizes of the steppers
when deciding whether 'hidden' should be set.  So we would have to ask
how many steppers are present for the scroll bar in the current theme,
guess their sizes (how?) and fix the test accordingly - maybe applying
scaling as well.  I doubt it's worth the trouble because apparently
GTK intends to remove or completely rework the style stuff sooner or
later anyway.

 > Let me know if I messed something up or there is additional data you
 > need.

You did it all right.  Unfortunately, the experiment failed to find
out why you get GTK_SCROLL_JUMP events when hitting a stepper.

Is scaling at work?  When debugging xg_update_scrollbar_pos what is
the value of 'scale' after doing

       int scale = xg_get_scale (f);

One more question: Can you get a GTK_SCROLL_STEP event when the slider
is in the middle of the scroll bar such that there remains some space
between slider and the stepper buttons.  Might be the sensitivity type
of stepper arrows hurts us here.

Thanks for the experiments, martin





  parent reply	other threads:[~2018-07-09  8:34 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29  7:36 bug#32002: 24.4; Scroll bar start, end not correct Andrew Kurn
2018-06-29  8:53 ` Eli Zaretskii
     [not found]   ` <20180629162402.GA21197@sfu.ca>
2018-06-29 17:24     ` Eli Zaretskii
2018-07-01  1:30       ` Andrew Kurn
2018-07-02 18:16         ` Glenn Morris
2018-07-02 18:20           ` Glenn Morris
2018-07-03 12:58           ` Andrew Kurn
2018-07-04  2:00             ` Noam Postavsky
2018-07-04  3:45               ` Andrew Kurn
2018-07-04  4:59                 ` Eli Zaretskii
2018-07-04  5:13                 ` Mike Kupfer
2018-07-04  5:34                   ` Eli Zaretskii
2018-07-04 16:32                     ` Mike Kupfer
2018-07-04 23:36                       ` Mike Kupfer
2018-07-04 23:44                         ` Noam Postavsky
2018-07-04 23:56                           ` Mike Kupfer
2018-07-05  2:36                             ` Eli Zaretskii
2018-07-05  5:28                               ` Mike Kupfer
2018-07-05  6:27                                 ` Eli Zaretskii
2018-07-05 15:05                                   ` Mike Kupfer
2018-07-06  3:58                                     ` Mike Kupfer
2018-07-06  6:10                                       ` Eli Zaretskii
2018-07-06 10:32                                         ` Robert Pluim
2018-07-06 12:56                                           ` martin rudalics
2018-07-06 13:31                                             ` Eli Zaretskii
2018-07-07  7:15                                               ` martin rudalics
2018-07-07  7:35                                                 ` Eli Zaretskii
2018-07-07  7:47                                                   ` martin rudalics
2018-07-07 15:19                                                     ` Mike Kupfer
2018-07-07 15:59                                                       ` Eli Zaretskii
2018-07-07 23:05                                                         ` Mike Kupfer
2018-07-08  3:00                                                           ` Mike Kupfer
2018-07-07 16:00                                                       ` Mike Kupfer
2018-07-08  8:11                                                       ` martin rudalics
2018-07-09  1:42                                                         ` Mike Kupfer
2018-07-09  2:53                                                           ` Mike Kupfer
2018-07-09  8:34                                                             ` martin rudalics
2018-07-09  8:34                                                           ` martin rudalics [this message]
2018-07-09 14:39                                                             ` Mike Kupfer
2018-07-10  7:30                                                               ` martin rudalics
2018-07-14  4:31                                                                 ` Mike Kupfer
2018-07-14  8:00                                                                   ` martin rudalics
2018-07-21  0:28                                                                     ` Mike Kupfer
2018-07-21  7:44                                                                       ` martin rudalics
2018-07-14  4:13                                                             ` Mike Kupfer
2018-07-06 15:02                                           ` Mike Kupfer
2018-07-06 16:02                                             ` Robert Pluim
2018-07-07  7:17                                             ` martin rudalics
2018-07-04  7:49                   ` Andrew Kurn
2018-07-04  9:30                     ` Stephen Berman
2018-07-04 12:10                     ` Noam Postavsky
2018-07-04 16:34                     ` Mike Kupfer
2018-07-10 19:16 ` Andrew Kurn
2018-07-11  3:02   ` Eli Zaretskii
2018-07-12  7:11     ` Andrew Kurn
2018-07-12 13:29       ` Eli Zaretskii
2018-07-12 15:57         ` Stephen Berman
2018-07-12 16:35           ` Eli Zaretskii
2018-07-14  4:56         ` Mike Kupfer
2018-07-14  6:49           ` Eli Zaretskii
2018-07-14  8:01             ` martin rudalics
2018-07-21 13:50               ` Eli Zaretskii
2018-07-22  7:25                 ` martin rudalics
2018-07-22 14:55                   ` Eli Zaretskii
2018-07-23  6:51                     ` martin rudalics
2018-07-27  8:30                   ` Eli Zaretskii
2018-07-27  9:23                     ` martin rudalics
2018-07-27 11:03                       ` Andrew Kurn
2018-07-27 12:27                         ` Eli Zaretskii
2018-07-28  7:22                           ` martin rudalics
2018-07-29  2:51                             ` Mike Kupfer
2018-07-16  1:47             ` Mike Kupfer
2018-07-21 13:53               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B431E1B.2030800@gmx.at \
    --to=rudalics@gmx.at \
    --cc=32002@debbugs.gnu.org \
    --cc=kurn@sfu.ca \
    --cc=mkupfer@alum.berkeley.edu \
    --cc=npostavs@gmail.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).