unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 31968@debbugs.gnu.org, Robert Pluim <rpluim@gmail.com>,
	Jonathan Kyle Mitchell <kyle@jonathanmitchell.org>
Subject: bug#31968: 26.1.50; Allow to hide title bar on maximize (gtk/gnome/csd)
Date: Mon, 02 Jul 2018 11:13:01 +0200	[thread overview]
Message-ID: <5B39EC9D.3030107@gmx.at> (raw)
In-Reply-To: <CAELgYhfUL1JscWX2MSY+A2tO2-+=Wi4ZtXSooXnPDQtrVB-2QQ@mail.gmail.com>

 > Under Cinnamon it worked without flickering.

Thanks.  But please post your code here so we know what we are
discussing.

 > There is just a minor
 > problem that could be pointing to a bug elsewhere in emacs. Cinnamon
 > implements a progression of tiles layouts, for instance starting from
 > a normal sized window (i) you press Super-Up and the window is tiled
 > to the top half of the screen, (ii) you then press Super-Up again and
 > the window is maximized, (iii) finally you press Super-Down and the
 > window returns to top half tile mode. In general only fully maximized
 > windows (ii) gets undecorated, as intended, but when transitioning
 > from fully maximized to top half tiled (ii->iii) emacs still sees the
 > maximized state in the fullscreen frame parameter and fails to
 > undecorate the window. Nevertheless the client state in (ii) is:
 >
 > ~:: xprop | grep _NET_WM_STATE
 > _NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_VERT, _NET_WM_STATE_TILED
 >
 > The problem seems to be in the reported frame parameters, not in
 > Jonathan's hook.

get_current_wm_state in xterm.c has this

       else if (a == dpyinfo->Xatom_net_wm_state_maximized_vert)
         {
           if (*size_state == FULLSCREEN_WIDTH)
             *size_state = FULLSCREEN_MAXIMIZED;
           else
             *size_state = FULLSCREEN_HEIGHT;
         }

Could you try setting a GDB breakpoint at the

           if (*size_state == FULLSCREEN_WIDTH)

line and see if it ever gets executed during (ii->iii).

Thanks for trying, martin





  parent reply	other threads:[~2018-07-02  9:13 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 20:43 bug#31968: 26.1.50; Allow to hide title bar on maximize (gtk/gnome/csd) Carlos Pita
2018-06-27 10:07 ` Robert Pluim
2018-06-27 13:02   ` Carlos Pita
2018-06-27 13:25     ` Robert Pluim
2018-06-27 15:20       ` Carlos Pita
2018-06-28  4:22         ` Jonathan Kyle Mitchell
2018-06-28  8:02           ` martin rudalics
2018-06-28 12:23             ` Robert Pluim
2018-06-28  8:02     ` martin rudalics
2018-06-28 15:25       ` Robert Pluim
2018-06-29  8:42         ` martin rudalics
2018-06-29  8:48           ` Robert Pluim
2018-06-30  8:33             ` martin rudalics
2018-06-30 22:32               ` Jonathan Kyle Mitchell
2018-06-30 22:54                 ` Carlos Pita
2018-06-30 23:25                   ` Carlos Pita
2018-07-01  0:13                     ` Carlos Pita
2018-07-01  9:04                       ` martin rudalics
2018-07-01 17:23                         ` Carlos Pita
2018-07-01 17:35                           ` Carlos Pita
2018-07-01 17:46                             ` Carlos Pita
2018-07-01 18:08                               ` Carlos Pita
2018-07-02 13:24                                 ` Robert Pluim
2018-07-02 14:28                                   ` Carlos Pita
2018-07-02 17:44                                     ` Carlos Pita
2018-07-02 20:03                                       ` Robert Pluim
2018-07-02 22:29                                         ` Carlos Pita
2018-07-03  2:06                                           ` Carlos Pita
2018-07-03  2:09                                             ` Carlos Pita
2018-07-03 23:35                                               ` Carlos Pita
2018-07-02  9:13                           ` martin rudalics [this message]
2018-07-02 13:21                     ` Robert Pluim
2018-07-01  9:02                   ` martin rudalics
2018-07-02 13:31                   ` Robert Pluim
2018-07-02 14:22                     ` Carlos Pita
2018-07-01  9:02                 ` martin rudalics
2018-07-02  5:06                   ` Jonathan Kyle Mitchell
2020-09-04  4:15         ` Lars Ingebrigtsen
2022-04-28 12:03           ` Lars Ingebrigtsen
2022-04-29  4:28           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 10:03             ` Lars Ingebrigtsen
2022-04-29 10:25               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-29 10:31                 ` Lars Ingebrigtsen
2022-04-29 10:42                   ` Lars Ingebrigtsen
2022-04-29 17:11                   ` Juri Linkov
2022-04-29 18:57                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B39EC9D.3030107@gmx.at \
    --to=rudalics@gmx.at \
    --cc=31968@debbugs.gnu.org \
    --cc=carlosjosepita@gmail.com \
    --cc=kyle@jonathanmitchell.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).