From: martin rudalics <rudalics@gmx.at>
To: Noam Postavsky <npostavs@gmail.com>, Michael Welsh Duggan <mwd@md5i.com>
Cc: 17675@debbugs.gnu.org
Subject: bug#17675: 24.4.50; *gud* buffer keeps on getting buried
Date: Mon, 21 May 2018 08:49:57 +0200 [thread overview]
Message-ID: <5B026C15.8040602@gmx.at> (raw)
In-Reply-To: <87d0xpj2tr.fsf@gmail.com>
>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index 24d5469..71dc574 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -2603,7 +2603,12 @@ comint mode, which see."
>> file-subst)))
>> (filepart (and file-word (concat "-" (file-name-nondirectory file))))
>> (existing-buffer (get-buffer (concat "*gud" filepart "*"))))
>> - (switch-to-buffer (concat "*gud" filepart "*"))
>> + (select-window
>
> Is this select-window call neeeded?
Yes because 'display-buffer' does not select the window it uses.
>> + (display-buffer
>> + (get-buffer-create (concat "*gud" filepart "*"))
>> + '(display-buffer-reuse-window
>> + display-buffer-in-previous-window
>> + display-buffer-same-window display-buffer-pop-up-window)))
>> (when (and existing-buffer (get-buffer-process existing-buffer))
>> (error "This program is already being debugged"))
>> ;; Set the dir, in case the buffer already existed with a different dir.
>
> Martin, I see the switch-to-buffer is still present in master now,
> should it be fixed?
If you think that this might solve Bug#22374, I'd go for it. Can you
explain how it solves that bug?
martin
next prev parent reply other threads:[~2018-05-21 6:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 15:17 bug#17675: 24.4.50; *gud* buffer keeps on getting buried Michael Welsh Duggan
2014-06-03 16:08 ` martin rudalics
2014-06-04 0:52 ` Michael Welsh Duggan
2014-06-04 6:41 ` martin rudalics
2014-06-04 11:20 ` Michael Welsh Duggan
2014-06-04 14:51 ` martin rudalics
2014-06-05 0:48 ` Michael Welsh Duggan
2014-06-05 7:48 ` martin rudalics
2014-11-23 23:27 ` Michael Welsh Duggan
2014-11-23 23:31 ` Michael Welsh Duggan
2014-11-23 23:34 ` Michael Welsh Duggan
2018-05-20 23:59 ` Noam Postavsky
2018-05-21 0:18 ` Michael Welsh Duggan
2018-05-21 1:06 ` Noam Postavsky
2018-05-21 6:49 ` martin rudalics [this message]
2018-05-21 20:38 ` bug#22374: Buffers of previously open files appear in gud interaction window instead of source window in many-windows mode Noam Postavsky
2018-05-22 7:24 ` martin rudalics
2018-05-23 23:11 ` Noam Postavsky
2015-03-09 14:02 ` bug#17675: patch Dima Kogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B026C15.8040602@gmx.at \
--to=rudalics@gmx.at \
--cc=17675@debbugs.gnu.org \
--cc=mwd@md5i.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).