From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#31312: Segmentation fault with doom-emacs, NeoTree and Zoom Date: Wed, 02 May 2018 08:16:26 +0200 Message-ID: <5AE957BA.6000809@gmx.at> References: <87r2mvo6c8.fsf@gmail.com> <5AE87AA3.6050602@gmx.at> <87o9hznfam.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1525241710 29156 195.159.176.226 (2 May 2018 06:15:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 May 2018 06:15:10 +0000 (UTC) Cc: 31312@debbugs.gnu.org, Andrea Cardaci To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 02 08:15:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDl2d-0007SO-BM for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2018 08:15:03 +0200 Original-Received: from localhost ([::1]:47487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDl4i-0007Tn-0O for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 May 2018 02:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDl4b-0007Th-Nw for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 02:17:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDl4X-0003YX-S6 for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 02:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38441) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDl4X-0003YT-Nr for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 02:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDl4X-0005Mp-IB for bug-gnu-emacs@gnu.org; Wed, 02 May 2018 02:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 May 2018 06:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31312-submit@debbugs.gnu.org id=B31312.152524180520607 (code B ref 31312); Wed, 02 May 2018 06:17:01 +0000 Original-Received: (at 31312) by debbugs.gnu.org; 2 May 2018 06:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:46338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDl4G-0005MI-Vh for submit@debbugs.gnu.org; Wed, 02 May 2018 02:16:45 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:41357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDl4D-0005M2-0L for 31312@debbugs.gnu.org; Wed, 02 May 2018 02:16:41 -0400 Original-Received: from [192.168.1.101] ([213.162.73.252]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MdaiW-1ezNS20d7E-00PQsy; Wed, 02 May 2018 08:16:34 +0200 In-Reply-To: <87o9hznfam.fsf@gmail.com> X-Provags-ID: V03:K1:vGUFGKvIP4qSS7c2/svFIFi15Bz4RbPr85F0af8oN770KDqHmv5 phBPzr/oIzpSBAVq8CokRjT2DoYMKlBlaISLiYZaZFjE9cBAHfTpssa2sz3pIToLoSjGhyo q9j6xzzrVT0cBWAiYIELHUflQQNPxnSsAYiQsueaUbnPBhC4SNqYBjxmUt6rlasDnzrC8jM RMos0zGlTaWRepv6g29hw== X-UI-Out-Filterresults: notjunk:1;V01:K0:0wwKw8NqMAI=:/4l9NzeJpRPh4tIhj2qgGl orixbG++N4uczDBSMOxq0LVi/VBvteB47esiq468v+JxDu10xZrmsh4YYZrT9EYpaNFa+Uarx KQozDRE7b8i5xsqnlHMaOclSpcD0Nu+nWRRk3BCJw30JLc9CZy8GQRXowMsuwkGDRx0HlFA1K 80GJmia3dW1xVnev/c9caxBJru5R/x3H5s58txjsM4+BDJ1c0TJ9IYfbWgttzIJs9gElAjXu0 P4skoDK8HFseld8JAjN+W74ZBS9YQsXxkQ/hXSUPDPWAAtiXDoENdMhjXgkUwgeqphhaPICK7 Oozb2dRfOcU5vplS+KKTSG7A6nXFq9uJgM/Q0n05slvutcebHL2R6Fm9FgHYNKbwwNJJ2Aaz8 hvd4+lMCx2fLK9KFecyNQqUcknAYugpNKifDwVtnyazG2vJxrgrOL8p7fehqM8hmIApGdzJpO 2g7h7pTmERulJRnXubRKBubzf2LL0klh0iu9OS9kwIA4FdoIok08GiHz4aLKWVndoVa5wFyK1 GR24jwJeflI3IVpKqkBsqzV09dT2fwUlH+m3FPQr1KnJs0fTlz/VaV5KF3wBkZRNxSWhpVzpf vX317l3I9B9B9yQqKbWid6U868dND+DliH3d4sfvB5B4G4AOwzqCWHg8quSoCdv8npXiPRCFc vRbb4q1SDUuoOGdHI7DUAeBplQNT1AALUJWK24C59xBmKYPDyvIICbIi4ZZf7xio2DKbW5yss m5Y5ZBIsAkPzLrIeSn7x2X0DoP8ZJVW1ka69kXyqEK1fYFf/a5ODeOH/Ymw4Mf4J/cvmP58I X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145916 Archived-At: >> Is w in reconsider_clip_changes the same as XWINDOW (selected_window) >> when it fails? > > Nope. In fact, doing > > break 13939 if (w != XWINDOW(selected_window)) > > triggers only just before the bad reconsider_clip_changes call. > > #0 redisplay_internal () at ../../src/xdisp.c:13939 > #1 0x0000000000463c16 in redisplay () at ../../src/xdisp.c:13518 > #2 0x00000000005851ae in read_char (commandflag=1, map=XIL(0x5e99db3), prev_event=XIL(0), > used_mouse_menu=0x7fffffffe41f, end_time=0x0) at ../../src/keyboard.c:2480 > #3 0x00000000005957c5 in read_key_sequence (keybuf=0x7fffffffe570, bufsize=30, prompt=XIL(0), > dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true, > prevent_redisplay=false) at ../../src/keyboard.c:9147 > #4 0x0000000000581d55 in command_loop_1 () at ../../src/keyboard.c:1368 > (More stack frames follow...) > (gdb) p w > $16 = (struct window *) 0x47d22f0 > (gdb) p sw > $17 = (struct window *) 0x47d22f0 > (gdb) p XWINDOW(selected_window) > $18 = (struct window *) 0x61109d0 > (gdb) p w->contents > $19 = XIL(0) > (gdb) p XWINDOW(selected_window)->contents > $20 = XIL(0x493e565) > (gdb) xpr > Lisp_Vectorlike > PVEC_BUFFER > $21 = (struct buffer *) 0x493e560 > (unsigned char *) 0x4a34568 " *NeoTree*" I'm probably too silly to understand this. IIUC we are here /* do_pending_window_change could change the selected_window due to frame resizing which makes the selected window too small. */ if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw) sw = w; /* Clear frames marked as garbaged. */ clear_garbaged_frames (); /* Build menubar and tool-bar items. */ if (NILP (Vmemory_full)) prepare_menu_bars (); reconsider_clip_changes (w); and the only ways this could cause w != XWINDOW(selected_window) before the last call is either !WINDOWP (selected_window) or that clear_garbaged_frames or prepare_menu_bars change selected_window. Can you find the responsible? martin