From: martin rudalics <rudalics@gmx.at>
To: Sujith <m.sujith@gmail.com>
Cc: 30182@debbugs.gnu.org
Subject: bug#30182: Update
Date: Sun, 28 Jan 2018 09:26:47 +0100 [thread overview]
Message-ID: <5A6D8947.5010207@gmx.at> (raw)
In-Reply-To: <87r2qag5wp.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
>> If the crash still occurs please proceed as follows:
>
> I checked with master and the crash no longer happens.
Thanks for checking and for reporting this bug in the first place. It
revealed an awfully silly, costly and completely unnecessary way of
implementing the desired behavior.
Yet, I'd still like to know why and how that crash happened. So if
you have a few minutes to spend, please shortly undo the fix and try
the two things I asked in my other mail, namely to:
(1) Try with `x-gtk-use-system-tooltips' nil. This should tell
whether GTK tooltip handling interferes with our routines.
(2) Try the attached (again) diff. When the crash occurs please do
p old_len_0
p new_len_0
in the debugger and post the values it prints. This should tell
whether a timer is added while we construct the list for the copy.
Thanks again, martin
[-- Attachment #2: concat.diff --]
[-- Type: text/plain, Size: 801 bytes --]
diff --git a/src/fns.c b/src/fns.c
index 47457e4..6fea5cd 100644
--- a/src/fns.c
+++ b/src/fns.c
@@ -546,6 +546,9 @@ struct textprop_rec
struct textprop_rec *textprops = NULL;
/* Number of elements in textprops. */
ptrdiff_t num_textprops = 0;
+
+ EMACS_INT old_len_0, new_len_0;
+
USE_SAFE_ALLOCA;
tail = Qnil;
@@ -643,7 +646,11 @@ struct textprop_rec
/* Create the output object. */
if (target_type == Lisp_Cons)
- val = Fmake_list (make_number (result_len), Qnil);
+ {
+ old_len_0 = XFASTINT (Flength (args[0]));
+ val = Fmake_list (make_number (result_len), Qnil);
+ new_len_0 = XFASTINT (Flength (args[0]));
+ }
else if (target_type == Lisp_Vectorlike)
val = Fmake_vector (make_number (result_len), Qnil);
else if (some_multibyte)
next prev parent reply other threads:[~2018-01-28 8:26 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 6:26 bug#30182: 27.0.50; Crash when doing mouse-over on modeline Sujith
2018-01-20 6:28 ` bug#30182: Update Sujith
2018-01-20 10:35 ` martin rudalics
2018-01-20 10:45 ` Sujith
2018-01-20 14:12 ` martin rudalics
2018-01-20 15:27 ` Eli Zaretskii
2018-01-21 2:15 ` Sujith
2018-01-21 3:39 ` Eli Zaretskii
2018-01-21 3:55 ` Sujith
2018-01-21 16:15 ` Eli Zaretskii
2018-01-21 18:29 ` Sujith
2018-01-22 9:15 ` martin rudalics
2018-01-22 15:09 ` Sujith
2018-01-22 17:37 ` Eli Zaretskii
2018-01-22 18:59 ` martin rudalics
2018-01-22 20:40 ` Eli Zaretskii
2018-01-23 18:44 ` martin rudalics
2018-01-23 19:53 ` Eli Zaretskii
2018-01-24 8:39 ` martin rudalics
2018-01-23 2:49 ` Sujith
2018-01-23 16:18 ` Eli Zaretskii
2018-01-23 17:07 ` Sujith
2018-01-23 17:25 ` Eli Zaretskii
2018-01-23 18:10 ` Eli Zaretskii
2018-01-23 18:45 ` martin rudalics
2018-01-23 19:51 ` Eli Zaretskii
2018-01-24 8:38 ` martin rudalics
2018-01-24 19:10 ` Eli Zaretskii
2018-01-24 20:05 ` martin rudalics
2018-01-23 18:44 ` martin rudalics
2018-01-23 19:59 ` Eli Zaretskii
2018-01-24 8:39 ` martin rudalics
2018-01-24 19:13 ` Eli Zaretskii
2018-01-24 20:06 ` martin rudalics
2018-01-27 8:26 ` martin rudalics
2018-01-28 0:53 ` Sujith
2018-01-28 8:26 ` martin rudalics [this message]
2018-01-29 5:13 ` Sujith
2018-01-29 10:04 ` martin rudalics
2018-01-29 15:50 ` Eli Zaretskii
2018-01-30 8:30 ` martin rudalics
2018-01-30 13:32 ` Eli Zaretskii
2018-01-31 9:31 ` martin rudalics
2018-01-31 14:43 ` Eli Zaretskii
2018-02-01 2:29 ` Sujith
2018-02-01 9:26 ` martin rudalics
2018-02-01 17:44 ` Eli Zaretskii
2018-02-02 8:28 ` martin rudalics
2018-02-02 8:37 ` martin rudalics
2018-02-02 16:00 ` Eli Zaretskii
2018-02-03 9:03 ` martin rudalics
2018-02-03 10:29 ` Eli Zaretskii
2018-02-04 10:01 ` martin rudalics
2018-02-04 18:21 ` Eli Zaretskii
2018-02-06 9:28 ` martin rudalics
2018-02-10 9:47 ` martin rudalics
2018-02-02 14:14 ` Noam Postavsky
2018-02-02 16:11 ` Eli Zaretskii
2018-02-03 9:04 ` martin rudalics
2018-02-03 10:30 ` Eli Zaretskii
2018-02-04 10:01 ` martin rudalics
2018-02-04 18:01 ` Eli Zaretskii
2018-01-29 15:53 ` Eli Zaretskii
2018-01-30 8:30 ` martin rudalics
2018-01-30 13:34 ` Eli Zaretskii
2018-01-31 9:31 ` martin rudalics
2018-01-31 14:44 ` Eli Zaretskii
2018-01-21 18:37 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A6D8947.5010207@gmx.at \
--to=rudalics@gmx.at \
--cc=30182@debbugs.gnu.org \
--cc=m.sujith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).