From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#30207: 27.0.50; [PATCH] other-window-for-scrolling returns window on daemon frame Date: Mon, 22 Jan 2018 19:59:47 +0100 Message-ID: <5A6634A3.3040403@gmx.at> References: <87inbtvqci.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1516647568 31737 195.159.176.226 (22 Jan 2018 18:59:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 18:59:28 +0000 (UTC) To: "Basil L. Contovounesios" , 30207@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 22 19:59:24 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edhJM-0007a3-3K for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jan 2018 19:59:16 +0100 Original-Received: from localhost ([::1]:59324 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edhLM-0000mQ-50 for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jan 2018 14:01:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edhL7-0000cj-9Z for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:01:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edhL4-0002ko-4Y for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:01:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58750) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edhL4-0002kk-1e for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edhL3-0004ID-Qp for bug-gnu-emacs@gnu.org; Mon, 22 Jan 2018 14:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jan 2018 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30207-submit@debbugs.gnu.org id=B30207.151664760316357 (code B ref 30207); Mon, 22 Jan 2018 19:01:01 +0000 Original-Received: (at 30207) by debbugs.gnu.org; 22 Jan 2018 19:00:03 +0000 Original-Received: from localhost ([127.0.0.1]:38413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edhK6-0004Ff-CG for submit@debbugs.gnu.org; Mon, 22 Jan 2018 14:00:02 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:64473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edhK4-0004Eq-OZ for 30207@debbugs.gnu.org; Mon, 22 Jan 2018 14:00:01 -0500 Original-Received: from [192.168.1.100] ([213.162.73.147]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MFcg9-1eYPzZ3Vmn-00EhZX; Mon, 22 Jan 2018 19:59:52 +0100 In-Reply-To: <87inbtvqci.fsf@tcd.ie> X-Provags-ID: V03:K0:SrxhAehv1iYwhSWzexeXiaIQICib1OaM9pF2FuYrOJETDbkIesW 0NjpeH8ekbWSFn+Abt0N8ULLFpU7lALGiZhoJScjlJ2IppFt8p5Q3CDajEoC0/aaOPFMpjy VLZ36aDwFtV85aHNVeZRNcBkPZt6NTTWJd9amgCRZ0VLDC8+GyS9c8Y5p/m2YDCzaoRiPfl VkmhRqCoNEgco/g+zE++g== X-UI-Out-Filterresults: notjunk:1;V01:K0:bwzQPSiuteY=:jhK/bT8K6EeMXR4GP8tH3G qi5rfxvcJHcb11/1uBATfb4Vd95H2JgH4VeLKEsLnhUWPoTwXe3Y0p4Aa1hMsNuqze1ZT2RoK YLQFjSVVtDYYI+7CySfzxnOSdcKdld6XBHeKTuuLJ4N6iQKm7ZWR4j0miVI6JCbbOxwHThgKJ n8oe9i0aR623AyErLcRbY0uws08Srdz8U2JoWzGgdpfgz9H2YNUaivM+Y3tOb+9EJ2XaM7inM N2XhnVFTXEH78f6oMGIMhUt9T/MJSdyHNH5p+Ljs0H1IRAZ+1fP02hFXWF2fZiQJnNUDJgMSL x1Rgsm690+XUIRxZCt2uof9hiSk7y2Pju1M76AGF1k6ddETeku34bLsAUfIj06lEadzX3Lq+3 RouZnuLNhIOU6kfdn5++xCTApAvZrdlzppRxzmcYOpUH80nOZPUJi3sz7IHlb5JGTGDd+QpVg iHalK0yLQSaO000CM/PkbuxhigNKYxcfXgvmmxhQF2UMg2Sw9ZwrfKVQBf8T75NlWphuW1S3K U00mcP7YwFpTh1zANuocXhSIqlGax8c9IyRRfv5NjFdgo34+wlDUVs1yjlgWD2kH61ndLwLUm jA5e2IrYodjpVuZZhaezpLED4J5s2sTCoytiJh98nEotv1zDU2HqbNHyAaw9DOdVrVQP0+0BY xyUftxR3XH21HZhizWrercjDZRa1iKZWP7ebvpf2pg308oGDC3wbWLxIRAb3IMSkujeAyC9U9 /fLyqpmBVzw8LAndjUTBpoM9ZuBd7HtOou5bXh0aod8TqGa/OGssXd8YIWxRatS8mLl4g7A2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142387 Archived-At: > I believe this issue and its potential resolution share some ground with > bug#27210 in that the daemon frame is counterintuitively considered > visible in the following repeat-until condition in > Fother_window_for_scrolling: > > do > window = Fnext_window (window, Qnil, Qt); > while (! FRAME_VISIBLE_P (XFRAME (WINDOW_FRAME (XWINDOW (window)))) > && ! EQ (window, selected_window)); > > Until a more thorough review of the visibility of the initial daemon > frame is reached, I propose the attached patch to additionally ignore > the daemon frame in the aforementioned repeat-until condition. I assume > the overhead of the additional loop logic and IS_DAEMON invariant is > negligible compared to the rest of the function. > > An alternative approach to the attached patch would be to limit "other > window scrolling" to frames in the current terminal, as per the spirit > of bug#5616: > > > > > or at least prioritise the current terminal's frames. WDYT? I think all your proposals are good and make sense. Which one would you like most? martin