bug#29661: 27.0.50; emacs crashing on exchange-point-and-mark

[martin rudalics <rudalics@gmx.at>]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

 > Thanks, it now no longer crashes there, but crashes elsewhere but looks
 > to about to terminate in a more controlled manner?

IIUC what Emacs is trying to do here is to avoid the infinite loop
mentioned in etc/PROBLEMS:

   There is a long-standing bug in GTK that prevents it from recovering
   from disconnects: http://bugzilla.gnome.org/show_bug.cgi?id=85715.

It also says:

   If you need Emacs to be able to recover from closing displays, compile
   it with the Lucid toolkit instead of GTK.

So it might be interesting if Lucid (or non-toolkit) builds work around
this.

 > #1  check_glyph_memory () at dispnew.c:2264
 >          tail = XIL(0)

Yet another one.  I attached a new patch.

martin


[-- Attachment #2: FOR_EACH_FRAME.c.diff --]
[-- Type: text/plain, Size: 1888 bytes --]

diff --git a/src/dispnew.c b/src/dispnew.c
index b0fc5c3..d078647 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -2260,8 +2260,9 @@ struct glyph_row *
   Lisp_Object tail, frame;

   /* Free glyph memory for all frames.  */
-  FOR_EACH_FRAME (tail, frame)
-    free_glyphs (XFRAME (frame));
+  if (!NILP (Vframe_list))
+    FOR_EACH_FRAME (tail, frame)
+      free_glyphs (XFRAME (frame));

 #if defined GLYPH_DEBUG && defined ENABLE_CHECKING
   /* Check that nothing is left allocated.  */
diff --git a/src/frame.c b/src/frame.c
index 5bafbed..66d1b5c 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -2058,7 +2058,7 @@ of them (the selected terminal frame) is actually displayed.

   /* If we've deleted the last_nonminibuf_frame, then try to find
      another one.  */
-  if (f == last_nonminibuf_frame)
+  if (f == last_nonminibuf_frame && !NILP (Vframe_list))
     {
       last_nonminibuf_frame = 0;

@@ -2076,7 +2076,7 @@ of them (the selected terminal frame) is actually displayed.

   /* If there's no other frame on the same kboard, get out of
      single-kboard state if we're in it for this kboard.  */
-  if (kb != NULL)
+  if (kb != NULL && !NILP (Vframe_list))
     {
       /* Some frame we found on the same kboard, or nil if there are none.  */
       Lisp_Object frame_on_same_kboard = Qnil;
@@ -2093,7 +2093,9 @@ of them (the selected terminal frame) is actually displayed.
   /* If we've deleted this keyboard's default_minibuffer_frame, try to
      find another one.  Prefer minibuffer-only frames, but also notice
      frames with other windows.  */
-  if (kb != NULL && EQ (frame, KVAR (kb, Vdefault_minibuffer_frame)))
+  if (kb != NULL
+      && EQ (frame, KVAR (kb, Vdefault_minibuffer_frame))
+      && !NILP (Vframe_list))
     {
       /* The last frame we saw with a minibuffer, minibuffer-only or not.  */
       Lisp_Object frame_with_minibuf = Qnil;