From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29627@debbugs.gnu.org, terlar@gmail.com
Subject: bug#29627: 25.3; x-show-tip does not display text when x-gtk-use-tooltips is nil and left/right-margin-width is set
Date: Sun, 10 Dec 2017 15:28:55 +0100 [thread overview]
Message-ID: <5A2D44A7.4010502@gmx.at> (raw)
In-Reply-To: <83k1xuu141.fsf@gnu.org>
> First, I didn't make the window a pseudo-window; it was always a
> pseudo-window. The line
>
> w->pseudo_window_p = true;
>
> existed in x-show-tip ever since Emacs 21.
Ah, sorry. I misread both ChangeLog entry and diffs (and was probably
mislead by this change
- Currently only used for menu bar windows of frames. */
+ Currently only used for menu bar windows, for tool bar windows,
+ and for tooltips. */
)
> I didn't feel comfortable
> with changing that now, certainly not on the release branch.
Sure so.
> And you will see that window_box_left does this for pseudo-windows:
>
> if (w->pseudo_window_p)
> return FRAME_INTERNAL_BORDER_WIDTH (f);
>
> which is just another example of the above-mentioned assumption about
> pseudo-windows being margin-less.
Right.
> So from_x remained (almost) zero, unlike in normal windows, and the
> already displayed text was deleted.
>
> For some reason that I cannot identify, and don't really care about,
> the original recipe did work until Emacs 24.3. But it could only work
> by sheer luck, or maybe something else was preventing the window of
> the tooltip frame to acquire display margins. I just made this
> official with my changes, that's all.
>
> As for why I forced the tip buffer have zero margins, instead of doing
> the same with the window in which that buffer is displayed, then:
>
> . why does it matter? the buffer is a temporary buffer generated
> specifically for showing the tip text;
> . I thought doing that with the window is more complex, what with
> all the different ways one can affect a window's parameters
>
> Having said all that, if you see problem(s) caused by my change,
> please describe them; I'm not married to the fix I pushed.
It's OK. My concern was that turning tooltip windows into
pseudo-windows would have meant a quite substantial change for the
release branch.
Thanks for the explanations, martin
next prev parent reply other threads:[~2017-12-10 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 13:54 bug#29627: 25.3; x-show-tip does not display text when x-gtk-use-tooltips is nil and left/right-margin-width is set Terje Larsen
2017-12-09 20:07 ` Eli Zaretskii
2017-12-10 9:52 ` martin rudalics
2017-12-10 14:08 ` Eli Zaretskii
2017-12-10 14:28 ` martin rudalics [this message]
2017-12-10 14:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A2D44A7.4010502@gmx.at \
--to=rudalics@gmx.at \
--cc=29627@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=terlar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).