unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Aaron Jensen <aaronjensen@gmail.com>, Alan Third <alan@idiocy.org>
Cc: 28442@debbugs.gnu.org
Subject: bug#28442: 26.0.50; [PATCH] Save and restore frame pixel size with desktop-save-mode
Date: Mon, 27 Nov 2017 09:48:15 +0100	[thread overview]
Message-ID: <5A1BD14F.4060907@gmx.at> (raw)
In-Reply-To: <CAHyO48zD1fS1N7CUuknu_+qqKHgz3uWKb=Qnp=Emin+4biVwBA@mail.gmail.com>

 > How’s this?

Elegant, in particular the `frameset--restore-frame' part.  Eli will
decide whether we can put this on the release branch.  In either case
we'll have to wait until your paperwork is complete.  And please send
diffs as attachments, one of our MUAs has decided to truncate some of
the lines.

One thing I'm not yet sure about is how a user's setting of
`frame-resize-pixelwise' may affect restoring the desktop.  I'd be
reluctant to change that variable from within frameset or using
`desktop-after-read-hook' to set it (which might be too late anyway).

Note that some window managers may refuse to resize a frame to a
non-integral size unless the appropriate WM hints have been set as we do
in x_wm_set_size_hint in either xterm.c or gtkutil.c:

   size_hints.width_inc = frame_resize_pixelwise ? 1 : FRAME_COLUMN_WIDTH (f);
   size_hints.height_inc = frame_resize_pixelwise ? 1 : FRAME_LINE_HEIGHT (f);

Maybe we have to provide an additional frame parameter
'resize-pixelwise' which would override the global
`frame-resize-pixelwise' setting for that particular frame.  But let's
wait for such a thing until we see an urgent need for it.

Anyway, since I'm not using desktop please confirm the following: When
`desktop-read' runs and your init file contains a non-nil customization
for `frame-resize-pixelwise', the size hints are set correctly to 1 for
each frame restored.

Thank you very much, martin






  parent reply	other threads:[~2017-11-27  8:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 11:06 bug#28442: 26.0.50; desktop-save-mode no longer restores correct frame size on macOS Aaron Jensen
2017-09-13 11:22 ` Aaron Jensen
2017-11-22 17:07 ` Alan Third
2017-11-22 17:15   ` Aaron Jensen
2017-11-22 20:31     ` Alan Third
2017-11-23  7:46   ` martin rudalics
2017-11-23 20:41     ` Alan Third
2017-11-23 22:20       ` Aaron Jensen
2017-11-24  9:01         ` martin rudalics
2017-11-24 16:33           ` Aaron Jensen
2017-11-26 10:25             ` martin rudalics
2017-11-26 18:47               ` bug#28442: 26.0.50; [PATCH] Save and restore frame pixel size with desktop-save-mode Aaron Jensen
2017-11-26 22:15                 ` Aaron Jensen
2017-11-27  3:34                   ` Eli Zaretskii
2017-11-27  8:48                 ` martin rudalics [this message]
2017-11-27 16:52                   ` Aaron Jensen
2017-12-15 15:30                     ` Aaron Jensen
2017-12-15 18:16                       ` martin rudalics
2017-12-15 20:35                         ` Eli Zaretskii
2017-12-16  9:41                           ` martin rudalics
2017-12-16 16:21                             ` Aaron Jensen
2017-12-16 17:30                               ` martin rudalics
2017-12-16 17:39                               ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A1BD14F.4060907@gmx.at \
    --to=rudalics@gmx.at \
    --cc=28442@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=alan@idiocy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).