From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#45818: 28.0.50; Test solar-sunrise-sunset fails Date: Tue, 12 Jan 2021 22:02:15 +0100 Message-ID: <59D8F21E-DA21-4F8E-AB91-550B3C154985@acm.org> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> <87ft35j4xl.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9260"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45818-done@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 22:09:07 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzQuY-0002IN-D2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 22:09:06 +0100 Original-Received: from localhost ([::1]:46082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzQuX-0003Rx-BU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 16:09:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzQpf-0006gG-2h for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 16:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzQpe-0008UH-S4 for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 16:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzQpe-0003Fd-Oq for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 16:04:02 -0500 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45818 X-GNU-PR-Package: emacs Mail-Followup-To: 45818@debbugs.gnu.org, mattiase@acm.org, contovob@tcd.ie Original-Received: via spool by 45818-done@debbugs.gnu.org id=D45818.161048540712445 (code D ref 45818); Tue, 12 Jan 2021 21:04:02 +0000 Original-Received: (at 45818-done) by debbugs.gnu.org; 12 Jan 2021 21:03:27 +0000 Original-Received: from localhost ([127.0.0.1]:33441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzQp4-0003Ee-RF for submit@debbugs.gnu.org; Tue, 12 Jan 2021 16:03:27 -0500 Original-Received: from mail1447c50.megamailservers.eu ([91.136.14.47]:42954 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzQp2-0003EQ-Dq for 45818-done@debbugs.gnu.org; Tue, 12 Jan 2021 16:03:25 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1610485397; bh=1iRMA4fsRybSwn9Jt4NKEbXsQhWWmdnFU1z8j12Pfgs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=AMp6AVffUvMMQmBpdzQwOCgwtns8A7X7q+biUqzepIvozR3oU3LyzQiymDWSR/SjW fIB2pYcKKnabIRqTbhvR6ChbrkG8rkp1XUCiPDlxkfubDWkhj8kno78GP6kELWjQOM jkqy3I71mDqZUlCdEHt+NUSGi7Ngjd/ul6Pc6+88= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 10CL3Fex015709; Tue, 12 Jan 2021 21:03:17 +0000 In-Reply-To: <87ft35j4xl.fsf@tcd.ie> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F21.5FFE0E95.006B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QoAgIm6d c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=Ot-t5D0Ek9gns1uj3wwA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197863 Archived-At: 12 jan. 2021 kl. 21.06 skrev Basil L. Contovounesios : > So I'm guessing dst-adjust-time adjusts for DST in my locale (based on > some cache), but not yours? The following change lets the test = succeed > for me: Thank you, and I agree that it's probably the pragmatic choice. Much as = I would have liked to track down and explain the exact reason for the = observed phenomenon, I gave up and pushed your suggested patch. If I would hazard a guess, it's related to the fact that Ireland uses = daylight saving in winter (with opposite adjustment) rather than in = summer; this may trigger a daylight-saving adjustment for the dates in = question (late December). The fact that IST is used for both Irish and = Indian time may be significant or a mere coincidence; it certainly = didn't help matters. Date and time calculations can be both infuriatingly and delightfully = messy, but in this case the code didn't really help either, with way too = many implicit input parameters -- global variables, caches, system = settings, time-zone files, and so on. Not something to make a test = writer happy! Thanks again for the report, and for persevering!