From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18369: 24.4.50; interactive spec of `facemenu-add-face' Date: Sat, 30 Apr 2016 08:47:15 -0800 (GMT-08:00) Message-ID: <597bd140-2dd3-4ffa-8b59-2289a3dc6dc0@default> References: <62d59397-d3d8-474c-aced-78018b70e6e8@default> <87twijqk54.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1462034927 21457 80.91.229.3 (30 Apr 2016 16:48:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Apr 2016 16:48:47 +0000 (UTC) Cc: 18369@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 30 18:48:34 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awY4I-00021N-7y for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 18:48:34 +0200 Original-Received: from localhost ([::1]:59005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awY4B-0002Fk-1p for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 12:48:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awY41-00023m-RO for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 12:48:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awY3q-0005eo-3o for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 12:48:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awY3q-0005dw-0I for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 12:48:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awY3m-0007a3-G4 for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 12:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2016 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18369 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18369-submit@debbugs.gnu.org id=B18369.146203484829098 (code B ref 18369); Sat, 30 Apr 2016 16:48:02 +0000 Original-Received: (at 18369) by debbugs.gnu.org; 30 Apr 2016 16:47:28 +0000 Original-Received: from localhost ([127.0.0.1]:58155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awY3E-0007ZG-9g for submit@debbugs.gnu.org; Sat, 30 Apr 2016 12:47:28 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:24207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awY3C-0007Z3-GC for 18369@debbugs.gnu.org; Sat, 30 Apr 2016 12:47:26 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3UGlJI5014514 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 16:47:20 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u3UGlJBY029718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 16:47:19 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u3UGlH3U027978; Sat, 30 Apr 2016 16:47:18 GMT In-Reply-To: <87twijqk54.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117384 Archived-At: > I find these functions odd. > `facemenu-set-face' just does this: > (facemenu-add-new-face face) > (facemenu-add-face face start end) > after reading a face name with `read-face-name'. So it's a very thin > shim over `facemenu-add-face'. It adds the face to the Face menu (first sexp). `facemenu-add-face' does not do that - it just applies a face to buffer text. These are two very different uses of the word "add". > `M-x facemenu-add-face RET foo RET' and nothing happened. > Then I did `M-x facemenu-add-face RET bold RET', and it > errored out saying Invalid face reference: foo > Huh? Read the doc. If the region is empty then `facemenu-add-face' applies a face to the text you type. Else it applies it to the text in the region. Works fine. `foo' is not a defined face. > I have no idea what these two functions are supposed to be doing, but I > don't think... they are doing... whatever they should be doing. They are doing exactly what they are supposed to do, and what they are documented as doing. This bug report (enhancement request, if you prefer) is a request to have `facemenu-add-face' use `read-face-name' (which might not have existed when it was defined originally; dunno). [Note: To use these commands you had better turn off font-lock in your buffer. Since font-lock has now taken over all `face' highlighting (see other bugs, which you've closed), you will see no effect from any functions that add text property `face'. Font lock should NOT be monopolizing the use of property `face' (even Stefan agrees with that). But it does (now), so turn it off if you want to be able to make use of Facemenu (and other `face' highlighting).]