From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#67483: Wrong warning position given by the byte compiler for a malformed function Date: Thu, 30 Nov 2023 11:37:31 +0100 Message-ID: <59773797-CC64-4352-9528-4E7593DD3C1F@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 67483@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 30 11:38:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8eQu-0005W7-Ss for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Nov 2023 11:38:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8eQf-0005pU-9w; Thu, 30 Nov 2023 05:37:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8eQd-0005pH-GS for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 05:37:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8eQd-0004qN-8A for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 05:37:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8eQk-0003xA-7M for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 05:38:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Nov 2023 10:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67483 X-GNU-PR-Package: emacs Original-Received: via spool by 67483-submit@debbugs.gnu.org id=B67483.170134066915141 (code B ref 67483); Thu, 30 Nov 2023 10:38:02 +0000 Original-Received: (at 67483) by debbugs.gnu.org; 30 Nov 2023 10:37:49 +0000 Original-Received: from localhost ([127.0.0.1]:52399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8eQW-0003w9-Jn for submit@debbugs.gnu.org; Thu, 30 Nov 2023 05:37:48 -0500 Original-Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:58617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8eQV-0003vx-3F for 67483@debbugs.gnu.org; Thu, 30 Nov 2023 05:37:47 -0500 Original-Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c9b5e50c1fso10707841fa.0 for <67483@debbugs.gnu.org>; Thu, 30 Nov 2023 02:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701340653; x=1701945453; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=LABrHb8oELinn8NusjGnTtaiH8a3RJANuhfofyAjzAo=; b=DBjtJYs9NgRTt0viR0aWqsCWVm+1+S5sZ0nZDyVZX6vOIf89A55Ekk4edYqlUe8e27 R089TJY9cE4HDq9ffvKkn610mbxw+wfJhP4qH4R5cLiRKSefbvxC0giyP9SpXMFhmoWj hX4XMuZit/CAaMV1vm4jPBQG31zjboD576qzlojmepr5Xn4ipmye59LSFhdmA9bvXkwU o/ztFQGRkr9DpvO1ik72+mdXoN3oHjunoZHM2Jot4Daaql8ovHiE52kjRjIuxw6Azaem fQPJKGgagqpKTebgW2qqp5xf4h3nPwHbBxaBztTRPBPhUZ+FDclCqafibAOyHL907181 UVZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701340653; x=1701945453; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LABrHb8oELinn8NusjGnTtaiH8a3RJANuhfofyAjzAo=; b=GwQ9Rocs9qpOsx08bJDWRHxDeyEjmtvv0N1/8jMvgL1QDGqkYY1K1CmbNysY8e8VqG aPFajBLqoBkoXJ1wvkfvklGM/wvwnfSlYmwwxsRMo4TIo+oyCqqFbB4Rf6yi0qbCiNuP UJMSSlRqty66sF0Ni4tjvAWdx8KXHdBDO/iEwW6Ol3hJQs5wq23mhXmdawHfPL+aIP1h JWbkYmecbrvU/tcJYFqQgNLJwI0T6/xTITC7+Vlmpb8MlIJ0E0J1AAJy3YIBYOBNAMGF ZwpZ0sZsk75W6KdOCvhm4cCbRnyzoWJB9ojVAvEINznUQtSjvGbUxxIHdwucs80ywoZC kAuQ== X-Gm-Message-State: AOJu0YzEaj+uzJqYAz4kOVn5F7LK1jeJVWIRdiSRPwhwqHb0jzNvHtJ/ 3dyg/pZC7keyuNSfP5iTaOc= X-Google-Smtp-Source: AGHT+IEYUXFFkb8uVswS2soZpRhmHff7esKYFdxHNza8T0y4JhXJGVKVztl6vh42mDb3dPdQebluNg== X-Received: by 2002:a2e:8012:0:b0:2c9:bdb0:c15e with SMTP id j18-20020a2e8012000000b002c9bdb0c15emr4026782ljg.3.1701340652833; Thu, 30 Nov 2023 02:37:32 -0800 (PST) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id c11-20020a2e9d8b000000b002c9afbeb006sm107362ljj.129.2023.11.30.02.37.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Nov 2023 02:37:32 -0800 (PST) X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275283 Archived-At: > Buffer bad-error-position.el:2:4: Warning: `foo' is a malformed = function >=20 > .. This position 2:4 is wrong; it is the position of the `let' = symbol. > The correct position would be 3:6, the position of the `if' symbol. (Actually the correct position would be the position of the string = literal but of course our location tracking system is too simplistic for = that.) Thank you for bringing this to our attention. Now I only saw this from = the reference in your commit message; would you CC me next time? = (Stefan, too, unless he objects.) I'm modifying your work a bit because we're trying to remove warnings = from the optimiser, not entrenching them there. The warning is now in = cconv but perhaps it should be moved to macroexp-all, it's not very = important. I hope being able to reshape the front-end a bit later on. Also, we usually prefer let-binding dynamic variables to push-pop pairs.