From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#976: 23.0.60; incorrect code for filesets-get-filelist Date: Sat, 21 Nov 2020 14:40:54 -0800 (PST) Message-ID: <59553787-a4ef-4312-8079-4b8be56b1f91@default> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26643"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 976@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 21 23:42:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgba9-0006rO-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Nov 2020 23:42:13 +0100 Original-Received: from localhost ([::1]:39902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgba7-0006S8-S6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Nov 2020 17:42:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgbZy-0006S0-Pk for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2020 17:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgbZy-0000LF-Ho for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2020 17:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgbZy-0001Ts-EL for bug-gnu-emacs@gnu.org; Sat, 21 Nov 2020 17:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Nov 2020 22:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 976-submit@debbugs.gnu.org id=B976.16059984655617 (code B ref 976); Sat, 21 Nov 2020 22:42:02 +0000 Original-Received: (at 976) by debbugs.gnu.org; 21 Nov 2020 22:41:05 +0000 Original-Received: from localhost ([127.0.0.1]:46358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgbZ3-0001SX-0N for submit@debbugs.gnu.org; Sat, 21 Nov 2020 17:41:05 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:36846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgbZ0-0001Rv-Je for 976@debbugs.gnu.org; Sat, 21 Nov 2020 17:41:03 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0ALMZAuc049729; Sat, 21 Nov 2020 22:40:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=2FmStbKY3nodPMw5kcupE6ZbhfCekKGNhz/NBiogvqs=; b=P2zmIu1sQ5UrE0zfHy5Yy7NDcTLFulRjmLMcBZ+keazj9ehJVoL2NK8FC+l1CanYFZ+8 LEi4CvtFObiEHlLYYm5u3n8xnVTC7BscZl0gkG7pC1OXpfgzacP5yflI/MuZz6Jc7aj4 vCaoJsEiAo6wmtI5LnFPZU2pHLWtpzKBRX7To0UFbbaMVjZVrswUHMOD7BK0PRvNY4lN oCCTdADrUWzHlNvxofcmrKY/wgJP9YkPzy7dXXft5v8FUp316r/yYz1FqSHAgcQGfH13 Terju9TQLfWu9FREY7Uk0p2ZxNwvp2YrPWwrjwaKz3HPjOITTi/yP/i6IhzIoM9OBajN YA== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 34xrdahg57-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 21 Nov 2020 22:40:56 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0ALMZnMc126765; Sat, 21 Nov 2020 22:40:56 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 34xrx9kfv5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Nov 2020 22:40:56 +0000 Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0ALMetG4022073; Sat, 21 Nov 2020 22:40:55 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5071.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9812 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011210159 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9812 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 phishscore=0 clxscore=1011 malwarescore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011210159 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193826 Archived-At: > tags 976 patch > quit > > Hi Drew, > > It's been a long time, but your fix looks right to me, and of course > you're right that the current code is broken.=C2=A0 I created a :tree fil= eset > for testing: without your fix I get wrong-type-argument errors, while > with your fix it works just fine. > > I've recreated your fix below, added a commit message and formatted it > with `git format-patch'.=C2=A0 Could you please take a look and see if it > is OK to push it? Or maybe you would like to provide a different commit > message for your change? Hi Mauro. Thanks for working on this. It's been so long since I filed this bug that I'm not really any help on this. And I really don't have any time now to help with it or much else wrt Emacs. I have complete confidence that whatever you come up with will be an improvement (and it will likely be a complete fix). Please do whatever you think is needed. Thx.