From: Drew Adams <drew.adams@oracle.com>
To: 18093@debbugs.gnu.org
Subject: bug#18093: 24.4.50; `delsel.el' fixes for use with `completion.el'
Date: Wed, 23 Jul 2014 13:58:43 -0700 (PDT) [thread overview]
Message-ID: <592101d8-bb6f-4ee3-ae58-e28f0126f09a@default> (raw)
`delsel.el' should be updated to play well with library `completion.el'.
The following should be done (or equivalent):
1.
(put 'completion-separator-self-insert-command 'delete-selection t)
(put 'completion-separator-self-insert-autofilling 'delete-selection t)
2. If `last-command' is `complete' and `this-command' has
`delete-selection' property `supersede' or `kill', replace the last
inserted completion with the string that was completed.
(defun delete-active-region (&optional killp)
(cond ((and (eq last-command 'complete) ; See `completion.el'.
(boundp 'cmpl-last-insert-location))
;; Do not delete region if a `self-insert-command'. Delete it only if a
;; supersede or a kill.
(when (and (symbolp this-command)
(memq (get this-command 'delete-selection) '(supersede kill)))
(delete-region (point) cmpl-last-insert-location) ; Free var here.
(insert cmpl-original-string) ; Free var here.
(setq completion-to-accept nil))) ; Free var here.
(killp ; Do not let `kill-region' change `this-command'
(let (this-command)
(if (or (> emacs-major-version 24)
(and (= emacs-major-version 24) (< emacs-minor-version 4)))
(kill-region (point) (mark) 'REGION)
(kill-region (point) (mark)))))
((boundp 'region-extract-function) ; Emacs 24.4+
(funcall region-extract-function 'delete-only))
(t (delete-region (point) (mark))))
(deactivate-mark)
t)
In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/snapshot/trunk
--enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
-Ic:/Devel/emacs/include''
next reply other threads:[~2014-07-23 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 20:58 Drew Adams [this message]
2021-01-23 21:55 ` bug#18093: 24.4.50; `delsel.el' fixes for use with `completion.el' Lars Ingebrigtsen
2021-01-24 0:52 ` bug#18093: [External] : " Drew Adams
2021-01-25 23:57 ` Lars Ingebrigtsen
2021-01-26 2:00 ` Drew Adams
2021-01-26 2:07 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=592101d8-bb6f-4ee3-ae58-e28f0126f09a@default \
--to=drew.adams@oracle.com \
--cc=18093@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).