bug#25179: 26.0.50; Dired doesn't preserve window height

bug#25179: 26.0.50; Dired doesn't preserve window height

[Liu Hui]

1. Emacs -Q
2. C-x 2
3. M-x dired
4. press 'm' to mark two or more files
5. press 'D'
    => the window below becomes larger
6. answer 'no'
    => the window height is not restored

The problem is not found with dired on Emacs 24.5.


In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
  of 2016-12-10 built on lgw01-57
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:	Ubuntu 16.04.1 LTS

bug#25179: 26.0.50; Dired doesn't preserve window height

[Tino Calancha]

Liu Hui <liuhui1610@gmail.com> writes:

> 1. Emacs -Q
> 2. C-x 2
> 3. M-x dired
> 4. press 'm' to mark two or more files
> 5. press 'D'
>    => the window below becomes larger
> 6. answer 'no'
>    => the window height is not restored
>
> The problem is not found with dired on Emacs 24.5.
Thank you.
For deleting 2-3 files Emacs24 and Emacs25 differs; for deleting
many files they looks pretty similar:

emacs -Q
C-x 2
;; Visit a directory with several hundred of files.
M-: (dired (expand-file-name "lisp" source-directory))
RET
t D no RET
;; In both releases the window displaying *scratch* becames very small.

bug#25179: 26.0.50; Dired doesn't preserve window height

[martin rudalics]

 >> 1. Emacs -Q
 >> 2. C-x 2
 >> 3. M-x dired
 >> 4. press 'm' to mark two or more files
 >> 5. press 'D'
 >>     => the window below becomes larger
 >> 6. answer 'no'
 >>     => the window height is not restored
 >>
 >> The problem is not found with dired on Emacs 24.5.
 > Thank you.
 > For deleting 2-3 files Emacs24 and Emacs25 differs; for deleting
 > many files they looks pretty similar:
 >
 > emacs -Q
 > C-x 2
 > ;; Visit a directory with several hundred of files.
 > M-: (dired (expand-file-name "lisp" source-directory))
 > RET
 > t D no RET
 > ;; In both releases the window displaying *scratch* becames very small.

This is bug#25055.  I yet have to understand why the behavior changed
in the transition from 24.5 to 25.

The problem is that when fitting a window to its buffer steals space
from more than one other window, that space should be returned to those
windows when the window is eventually deleted.  Returning space to more
than one window requires binding ‘window-combination-resize’ to t around
the action deleting the window.  Apparently trivial, I have not yet
found a way to do that reliably.

martin

bug#25179: 26.0.50; Dired doesn't preserve window height

[martin rudalics]

 > 1. Emacs -Q
 > 2. C-x 2
 > 3. M-x dired
 > 4. press 'm' to mark two or more files
 > 5. press 'D'
 >     => the window below becomes larger
 > 6. answer 'no'
 >     => the window height is not restored
 >
 > The problem is not found with dired on Emacs 24.5.

Should have been fixed now on master with commit

23d3eeb798c7edc27898b0dbd4c2364a6ca6247d

Please (1) recompile window.el and after that (2) minibuffer.el and
dired.el and finally (3) rebuild Emacs.  Closing this bug.

Thanks, martin

bug#25179: 26.0.50; Dired doesn't preserve window height

[martin rudalics]

 > emacs -Q
 > C-x 2
 > ;; Visit a directory with several hundred of files.
 > M-: (dired (expand-file-name "lisp" source-directory))
 > RET
 > t D no RET
 > ;; In both releases the window displaying *scratch* becames very small.

This should not happen any more after my last commit.  Please check.

Thanks, martin

bug#25179: 26.0.50; Dired doesn't preserve window height

[Tino Calancha]

On Sat, 15 Apr 2017, martin rudalics wrote:

>> emacs -Q
>> C-x 2
>> ;; Visit a directory with several hundred of files.
>> M-: (dired (expand-file-name "lisp" source-directory))
>> RET
>> t D no RET
>> ;; In both releases the window displaying *scratch* becames very small.
>
> This should not happen any more after my last commit.  Please check.
Checked it.  It's OK now.  Thank you.

bug#25179: 26.0.50; Dired doesn't preserve window height

[martin rudalics]

 > Checked it.  It's OK now.  Thank you.

Thanks for checking.

martin