From: martin rudalics <rudalics@gmx.at>
To: Ken Brown <kbrown@cornell.edu>, 23144@debbugs.gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#23144: shrinking windows with gtk 3.20
Date: Fri, 24 Mar 2017 19:52:29 +0100 [thread overview]
Message-ID: <58D56AED.1030807@gmx.at> (raw)
In-Reply-To: <b3cec929-8a24-ca6c-8f09-b02a1ba1fe6c@cornell.edu>
>> gtkutil.c has 19 uses of GTK_CHECK_VERSION and none of the function. So
>> we probably should replace them all. Bit of annoying.
> Not necessarily. I think the macro is probably TRT in many (most?
> all?) cases. In the case at hand, the problem occurs only on the
> emacs-25 branch, so I don't think we should worry about the other
> uses.
In a sense, yes. A macro is bad when a GTK "feature" is no more
available after upgrading like in the case at hand. When a feature is
added due to upgrading it will be automatically incorporated in the next
build. Only when someone detects that upgrading GTK breaks something
else and his Emacs already uses the upgraded version, downgrading may
also break the build.
Still I think that people who upgrade GTK should rebuild Emacs right
away. Chances are that an upgraded GTK breaks something not covered by
GTK_CHECK_VERSION as well.
martin
next prev parent reply other threads:[~2017-03-24 18:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:52 bug#23144: shrinking windows with gtk 3.20 Matthias Clasen
2016-03-29 15:18 ` martin rudalics
2016-03-29 16:02 ` Eli Zaretskii
2016-03-29 17:20 ` martin rudalics
2016-03-31 16:09 ` John Wiegley
2016-04-01 7:48 ` martin rudalics
2016-04-01 9:46 ` Eli Zaretskii
2016-04-02 0:03 ` Paul Eggert
2016-04-02 7:01 ` Eli Zaretskii
2016-04-02 15:19 ` Matthias Clasen
2016-04-02 15:47 ` Eli Zaretskii
2016-04-02 16:06 ` martin rudalics
2016-04-02 16:28 ` Eli Zaretskii
2016-04-02 17:27 ` Matthias Clasen
2016-04-02 17:32 ` Eli Zaretskii
2016-04-02 23:20 ` Matthias Clasen
2016-04-03 2:36 ` Eli Zaretskii
2016-05-16 6:53 ` Paul Eggert
2016-05-16 8:21 ` martin rudalics
2016-05-16 15:53 ` Eli Zaretskii
2016-05-16 17:11 ` Paul Eggert
2017-03-24 13:01 ` Ken Brown
2017-03-24 13:24 ` martin rudalics
2017-03-24 13:38 ` Ken Brown
2017-03-24 18:52 ` martin rudalics [this message]
2017-03-24 13:35 ` Eli Zaretskii
2017-03-24 14:08 ` Ken Brown
2017-03-24 14:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58D56AED.1030807@gmx.at \
--to=rudalics@gmx.at \
--cc=23144@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).