From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M- Date: Fri, 28 Sep 2012 14:37:30 -0700 Message-ID: <584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1348868278 16079 80.91.229.3 (28 Sep 2012 21:37:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Sep 2012 21:37:58 +0000 (UTC) To: 12535@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 28 23:38:03 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1THiG1-0008GR-0T for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Sep 2012 23:38:01 +0200 Original-Received: from localhost ([::1]:33386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THiFv-0000aw-NL for geb-bug-gnu-emacs@m.gmane.org; Fri, 28 Sep 2012 17:37:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THiFr-0000an-U8 for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:37:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THiFr-0007Cy-02 for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:37:51 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THiFq-0007Cu-Sy for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:37:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1THiG2-0003la-3Z for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Sep 2012 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12535 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.134886827514463 (code B ref -1); Fri, 28 Sep 2012 21:38:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Sep 2012 21:37:55 +0000 Original-Received: from localhost ([127.0.0.1]:32775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1THiFv-0003lE-E3 for submit@debbugs.gnu.org; Fri, 28 Sep 2012 17:37:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35354) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1THiFt-0003l7-8D for submit@debbugs.gnu.org; Fri, 28 Sep 2012 17:37:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THiFg-0007CM-PH for submit@debbugs.gnu.org; Fri, 28 Sep 2012 17:37:41 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:42961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THiFg-0007CI-Lw for submit@debbugs.gnu.org; Fri, 28 Sep 2012 17:37:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THiFf-0000aj-Ok for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:37:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THiFe-0007C6-K7 for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:37:39 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:37369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THiFe-0007C2-EA for bug-gnu-emacs@gnu.org; Fri, 28 Sep 2012 17:37:38 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8SLbZLR000554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Sep 2012 21:37:36 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8SLbYVx011949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 28 Sep 2012 21:37:35 GMT Original-Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8SLbYPL028688 for ; Fri, 28 Sep 2012 16:37:34 -0500 Original-Received: from dradamslap1 (/10.159.184.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 28 Sep 2012 14:37:34 -0700 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2dwXY47w34iWZXR+OaF+upKt0G7Q== X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64992 Archived-At: (kbd "M-") incorrectly returns [M-TAB]. IMHO, it should return [134217737], the same thing that (kbd "M-TAB") returns. IOW, for consistency, TAB should be treated specially here, in the same way that NUL, RET, LFD, ESC, SPC, and DEL are treated specially. Yes, it is true that there is no predefined function key named `NUL' etc. But there is also no predefined function key named `TAB'. The predefined function key is named `tab', not `TAB'. `M-' is not the same thing as `M-', of course. It is better to help users avoid such possible confusion by treating `TAB' the same way we treat `NUL' etc. diff -c edmacro.el edmacro-patched.el *** edmacro.el Fri Sep 28 13:55:18 2012 --- edmacro-patched.el Fri Sep 28 13:56:24 2012 *************** *** 708,714 **** (substring word (match-beginning 3) (match-end 3)))) (not (string-match ! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$" word)))) (setq key (list (intern word)))) ((or (equal word "REM") (string-match "^;;" word)) --- 708,714 ---- (substring word (match-beginning 3) (match-end 3)))) (not (string-match ! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$" word)))) (setq key (list (intern word)))) ((or (equal word "REM") (string-match "^;;" word)) Diff finished. Fri Sep 28 13:56:44 2012 In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-09-17 on MARVIN Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'