unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: 12535@debbugs.gnu.org
Subject: bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>
Date: Fri, 28 Sep 2012 14:37:30 -0700	[thread overview]
Message-ID: <584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com> (raw)

(kbd "M-<TAB>") incorrectly returns [M-TAB].  IMHO, it should return
[134217737], the same thing that (kbd "M-TAB") returns.
 
IOW, for consistency, TAB should be treated specially here, in the
same way that NUL, RET, LFD, ESC, SPC, and DEL are treated specially.
 
Yes, it is true that there is no predefined function key named `NUL'
etc.  But there is also no predefined function key named `TAB'.  The
predefined function key is named `tab', not `TAB'.  `M-<tab>' is not the
same thing as `M-<TAB>', of course.  It is better to help users avoid
such possible confusion by treating `TAB' the same way we treat `NUL' etc.
 

diff -c edmacro.el edmacro-patched.el
*** edmacro.el Fri Sep 28 13:55:18 2012
--- edmacro-patched.el Fri Sep 28 13:56:24 2012
***************
*** 708,714 ****
        (substring word (match-beginning 3)
            (match-end 3))))
          (not (string-match
!        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
         word))))
          (setq key (list (intern word))))
         ((or (equal word "REM") (string-match "^;;" word))
--- 708,714 ----
        (substring word (match-beginning 3)
            (match-end 3))))
          (not (string-match
!        "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
         word))))
          (setq key (list (intern word))))
         ((or (equal word "REM") (string-match "^;;" word))
 
Diff finished.  Fri Sep 28 13:56:44 2012
 
 
In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
 of 2012-09-17 on MARVIN
Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 






             reply	other threads:[~2012-09-28 21:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>
     [not found] ` <<87eh3ba7s9.fsf@building.gnus.org>
     [not found]   ` <<ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
     [not found]     ` <<877fhuej87.fsf@gnus.org>
     [not found]       ` <<ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
     [not found]         ` <<87bn4t7ih6.fsf@gnus.org>
     [not found]           ` <<2493efa4-e079-446c-8926-f7ee14c04ec9@default>
     [not found]             ` <<87eg9oa7kp.fsf@gnus.org>
     [not found]               ` <<m3k1d76qgn.fsf@gnus.org>
     [not found]                 ` <<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>
     [not found]                   ` <<8736ji3vgs.fsf@gmail.com>
     [not found]                     ` <<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>
     [not found]                       ` <<83r2717si6.fsf@gnu.org>
2012-09-28 21:37                         ` Drew Adams [this message]
2014-02-10  4:52                           ` bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB> Lars Ingebrigtsen
2014-02-10  5:02                             ` Drew Adams
2016-02-24  6:05                               ` Lars Ingebrigtsen
2016-02-24 15:15                                 ` Drew Adams
2016-04-28 17:26                                   ` Lars Ingebrigtsen
2016-04-29  0:32                                     ` Drew Adams
2016-04-29 13:05                                       ` Lars Ingebrigtsen
2019-06-27 14:41                                         ` Lars Ingebrigtsen
2019-06-27 16:21                                           ` Drew Adams
2019-07-07 12:00                                             ` Noam Postavsky
2019-07-07 15:34                                               ` Drew Adams
2019-07-07 15:51                                                 ` Eli Zaretskii
2020-10-14  5:18                           ` Drew Adams
     [not found]                         ` <de9af715-ee6a-463e-9d91-4ae753f49c00@default>
2020-10-14 14:59                           ` Eli Zaretskii
     [not found] <<<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>
     [not found] ` <<<87eh3ba7s9.fsf@building.gnus.org>
     [not found]   ` <<<ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
     [not found]     ` <<<877fhuej87.fsf@gnus.org>
     [not found]       ` <<<ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
     [not found]         ` <<<87bn4t7ih6.fsf@gnus.org>
     [not found]           ` <<<2493efa4-e079-446c-8926-f7ee14c04ec9@default>
     [not found]             ` <<<87eg9oa7kp.fsf@gnus.org>
     [not found]               ` <<<m3k1d76qgn.fsf@gnus.org>
     [not found]                 ` <<<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>
     [not found]                   ` <<<8736ji3vgs.fsf@gmail.com>
     [not found]                     ` <<<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>
     [not found]                       ` <<<83r2717si6.fsf@gnu.org>
     [not found]                         ` <<de9af715-ee6a-463e-9d91-4ae753f49c00@default>
     [not found]                           ` <<83o8l4zwda.fsf@gnu.org>
2020-10-14 16:13                             ` Drew Adams
2020-10-14 16:28                               ` Eli Zaretskii
2020-10-16  4:07                                 ` Richard Stallman
2020-10-16  6:08                                   ` Eli Zaretskii
     [not found] <<<<584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com>
     [not found] ` <<<<87eh3ba7s9.fsf@building.gnus.org>
     [not found]   ` <<<<ebe2c1ae-e3b2-47fe-94e5-841990beb724@default>
     [not found]     ` <<<<877fhuej87.fsf@gnus.org>
     [not found]       ` <<<<ad8ef861-3ff5-42d8-851e-edaf894ce0a0@default>
     [not found]         ` <<<<87bn4t7ih6.fsf@gnus.org>
     [not found]           ` <<<<2493efa4-e079-446c-8926-f7ee14c04ec9@default>
     [not found]             ` <<<<87eg9oa7kp.fsf@gnus.org>
     [not found]               ` <<<<m3k1d76qgn.fsf@gnus.org>
     [not found]                 ` <<<<6b5e4737-edb3-4f0c-b4e7-252330d3436e@default>
     [not found]                   ` <<<<8736ji3vgs.fsf@gmail.com>
     [not found]                     ` <<<<9551e332-3baf-49d0-a6ff-4b2432457d5d@default>
     [not found]                       ` <<<<83r2717si6.fsf@gnu.org>
     [not found]                         ` <<<de9af715-ee6a-463e-9d91-4ae753f49c00@default>
     [not found]                           ` <<<83o8l4zwda.fsf@gnu.org>
     [not found]                             ` <<1d10d47c-2777-4c8f-89a3-e2693262391c@default>
     [not found]                               ` <<83blh4zs93.fsf@gnu.org>
2020-10-14 17:22                                 ` Drew Adams
2020-10-14 17:41                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=584510D2C7DE47CBAE19B5058B21B51C@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=12535@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).