From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Date: Sun, 24 Sep 2023 08:38:51 -0300 Message-ID: <5843bd17-61a0-c67c-1abb-7d2224475c10@gmail.com> References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> <87wmwnik0q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------a0L0bACR9inRcu4NW6BwV03h" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31317"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: 66071@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 24 13:40:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkNT4-000830-Nd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Sep 2023 13:40:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkNSr-00030x-QN; Sun, 24 Sep 2023 07:39:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkNSp-00030g-Ub for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:39:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkNSo-0004ca-Qq for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:39:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkNT0-0006z8-IR for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2023 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Cc: 66071@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169555556426798 (code B ref -1); Sun, 24 Sep 2023 11:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Sep 2023 11:39:24 +0000 Original-Received: from localhost ([127.0.0.1]:41182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkNSN-0006y9-Uw for submit@debbugs.gnu.org; Sun, 24 Sep 2023 07:39:24 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:51756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkNSJ-0006xh-U1 for submit@debbugs.gnu.org; Sun, 24 Sep 2023 07:39:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkNS2-0002yj-QU for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:39:02 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkNS0-0004Sd-3W for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 07:39:01 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qkNRx-0006iG-7f for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 13:38:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Content-Language: en-US In-Reply-To: <87wmwnik0q.fsf@gmail.com> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.473, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271234 Archived-At: This is a multi-part message in MIME format. --------------a0L0bACR9inRcu4NW6BwV03h Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/9/23 12:22, Robert Pluim wrote: >>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda said: > > Mauro> On 18/9/23 11:20, Robert Pluim wrote: > >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda > Mauro> said: > >> Mauro> Patch attached. > >> > >> Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 > Mauro> 00:00:00 2001 > >> Mauro> From: Mauro Aranda > >> Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 > >> Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output > Mauro> :type (Bug#66071) > >> > >> Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add > Mauro> missing choices. > >> Mauro> --- > >> Mauro> lisp/term.el | 5 ++++- > >> Mauro> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> Mauro> diff --git a/lisp/term.el b/lisp/term.el > >> Mauro> index b8466b21332..5dd73447cfb 100644 > >> Mauro> --- a/lisp/term.el > >> Mauro> +++ b/lisp/term.el > >> Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output > >> > >> Mauro> See variable `term-scroll-show-maximum-output'. > >> Mauro> This variable is buffer-local." > >> Mauro> - :type 'boolean > >> Mauro> + :type '(choice (const :tag "Don't scroll" nil) > >> Mauro> + (const :tag "Scroll selected window > Mauro> only" this) > >> Mauro> + (const :tag "Scroll unselected windows" > Mauro> others) > >> Mauro> + (other :tag "Scroll all windows" t)) > >> Mauro> :group 'term) > >> > >> The code (and the docstring) also mention 'all. > > Mauro> I know, that's why I put other, to catch either t or 'all, since it > Mauro> doesn't make sense to have 2 different items for the same option. And > Mauro> adding something to match only t or 'all didn't seem worth the trouble. > > Mauro> Am I missing something? > > Both before and after your patch, the defcustom and the docstring > disagree. The docstring says 'all', but thatʼs not a value you can get > via customize. > > Personally Iʼd be inclined to delete 'all' from the docstring. People > already using 'all' wonʼt notice, since the code will still recognize > it. > > Robert I've incorporated your suggestion in the attached patch. --------------a0L0bACR9inRcu4NW6BwV03h Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patch" Content-Disposition: attachment; filename*0="0001-Fix-term-scroll-to-bottom-on-output-type-Bug-66071.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBkOWY3ZGEzY2U1MjRhOTYwM2M4MDhmNTFlMzRhZjk5NDYwMjIzNGQ5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMTggU2VwIDIwMjMgMDk6MTk6MDQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggdGVybS1zY3JvbGwtdG8tYm90dG9tLW9uLW91dHB1dCA6dHlwZSAoQnVn IzY2MDcxKQoKKiBsaXNwL3Rlcm0uZWwgKHRlcm0tc2Nyb2xsLXRvLWJvdHRvbS1vbi1vdXRw dXQpOiBBZGQgbWlzc2luZyBjaG9pY2VzLgpEb24ndCBhZHZlcnRpc2UgdGhlIHZhbHVlIGFs bCBhbnltb3JlLgotLS0KIGxpc3AvdGVybS5lbCB8IDkgKysrKysrKy0tCiAxIGZpbGUgY2hh bmdlZCwgNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xp c3AvdGVybS5lbCBiL2xpc3AvdGVybS5lbAppbmRleCBiODQ2NmIyMTMzMi4uYjI4NzVlNGEx N2YgMTAwNjQ0Ci0tLSBhL2xpc3AvdGVybS5lbAorKysgYi9saXNwL3Rlcm0uZWwKQEAgLTQ4 Niw3ICs0ODYsNyBAQCB0ZXJtLWNoYXItbW9kZS1wb2ludC1hdC1wcm9jZXNzLW1hcmsKIAog KGRlZmN1c3RvbSB0ZXJtLXNjcm9sbC10by1ib3R0b20tb24tb3V0cHV0IG5pbAogICAiQ29u dHJvbHMgd2hldGhlciBpbnRlcnByZXRlciBvdXRwdXQgY2F1c2VzIHdpbmRvdyB0byBzY3Jv bGwuCi1JZiBuaWwsIHRoZW4gZG8gbm90IHNjcm9sbC4gIElmIHQgb3IgYGFsbCcsIHNjcm9s bCBhbGwgd2luZG93cyBzaG93aW5nIGJ1ZmZlci4KK0lmIG5pbCwgdGhlbiBkbyBub3Qgc2Ny b2xsLiAgSWYgdCwgc2Nyb2xsIGFsbCB3aW5kb3dzIHNob3dpbmcgYnVmZmVyLgogSWYgYHRo aXMnLCBzY3JvbGwgb25seSB0aGUgc2VsZWN0ZWQgd2luZG93LgogSWYgYG90aGVycycsIHNj cm9sbCBvbmx5IHRob3NlIHRoYXQgYXJlIG5vdCB0aGUgc2VsZWN0ZWQgd2luZG93LgogCkBA IC00OTQsNyArNDk0LDEyIEBAIHRlcm0tc2Nyb2xsLXRvLWJvdHRvbS1vbi1vdXRwdXQKIAog U2VlIHZhcmlhYmxlIGB0ZXJtLXNjcm9sbC1zaG93LW1heGltdW0tb3V0cHV0Jy4KIFRoaXMg dmFyaWFibGUgaXMgYnVmZmVyLWxvY2FsLiIKLSAgOnR5cGUgJ2Jvb2xlYW4KKyAgOnR5cGUg JyhjaG9pY2UgKGNvbnN0IDp0YWcgIkRvbid0IHNjcm9sbCIgbmlsKQorICAgICAgICAgICAg ICAgICAoY29uc3QgOnRhZyAiU2Nyb2xsIHNlbGVjdGVkIHdpbmRvdyBvbmx5IiB0aGlzKQor ICAgICAgICAgICAgICAgICAoY29uc3QgOnRhZyAiU2Nyb2xsIHVuc2VsZWN0ZWQgd2luZG93 cyIgb3RoZXJzKQorICAgICAgICAgICAgICAgICA7OyBXZSBhbHNvIHJlY29nbml6ZSBgYWxs JywgYnV0IHdlIGRvbid0IGFkdmVydGlzZSBpdAorICAgICAgICAgICAgICAgICA7OyBhbnlt b3JlLiAgKEJ1ZyM2NjA3MSkKKyAgICAgICAgICAgICAgICAgKG90aGVyIDp0YWcgIlNjcm9s bCBhbGwgd2luZG93cyIgdCkpCiAgIDpncm91cCAndGVybSkKIAogKGRlZmN1c3RvbSB0ZXJt LXNjcm9sbC1zbmFwLXRvLWJvdHRvbSB0Ci0tIAoyLjM0LjEKCg== --------------a0L0bACR9inRcu4NW6BwV03h--