From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#24828: 26.0.50; Renaming of display-buffer-in-major-side-window broke which-key.el Date: Sun, 30 Oct 2016 20:34:46 +0100 Message-ID: <58164B56.5040109@gmx.at> References: <87a8dld7fy.fsf@telefonica.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1477856186 25709 195.159.176.226 (30 Oct 2016 19:36:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Oct 2016 19:36:26 +0000 (UTC) To: =?UTF-8?Q?=C3=93scar?= Fuentes , 24828@debbugs.gnu.org, justin@burkett.cc Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 30 20:36:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0vts-0005KH-PV for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Oct 2016 20:36:12 +0100 Original-Received: from localhost ([::1]:59812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0vtv-0008KU-FN for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Oct 2016 15:36:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0vtl-0008JR-BD for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 15:36:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0vti-0008Bc-7C for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 15:36:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c0vth-0008BW-SJ for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 15:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c0vth-0000Gx-HT for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 15:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2016 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24828 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24828-submit@debbugs.gnu.org id=B24828.1477856102973 (code B ref 24828); Sun, 30 Oct 2016 19:36:01 +0000 Original-Received: (at 24828) by debbugs.gnu.org; 30 Oct 2016 19:35:02 +0000 Original-Received: from localhost ([127.0.0.1]:37446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0vsk-0000Fd-BI for submit@debbugs.gnu.org; Sun, 30 Oct 2016 15:35:02 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:65348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0vsi-0000F6-Us for 24828@debbugs.gnu.org; Sun, 30 Oct 2016 15:35:01 -0400 Original-Received: from [192.168.1.101] ([212.95.7.83]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MdaCy-1cFAw42fNs-00PNHe; Sun, 30 Oct 2016 20:34:52 +0100 In-Reply-To: <87a8dld7fy.fsf@telefonica.net> X-Provags-ID: V03:K0:gzq+NxMhkvd/uCCwCjm41HeMR5cjoTDhECenBaUe0yKC/MUPxDc TblQUx+w/DZXqcPY2wTXK+Vf7j4zPwvggE6NSI+CoYsNZ9jPYLK1bs6GmV/3INmJRnumuFC Myut3xXVsckl2P2jTooCGufFf+9Ae/jWr0ITz/1hFqR/mLmUzL/HFMLuZCO8K/v+3i+9/In w94rJ3eBNqnZR8LS5NB7g== X-UI-Out-Filterresults: notjunk:1;V01:K0:FKTLc6XoWBc=:+DcVlDG1W9Ej9Gza78wvlI +5HLzDnXuTayr11ccQ6uXFz/lqttriUqjmIqiLDYV01kqEIWg5W5H4mXMRCozHtSfs3m63x5A Q+EYTwPX9DxoZeztIS44UVHEypNBwaM9S2RoGCAJt0dLlRqDfRxWb4H5rsSq1er+U8kyCb2QA eVpU7GvwwLykL82gZjQhpIobX5043Geu0DA/TZGFSfdbQKaZvWrPRS7B9J3mOyeB89C7wawpE 4I5OenQoN7vY2ngsVojNmxlBZxXDLWhiTdO1QDF65Bg7J2L5O+q7yhTUDLXfswAjF/X3OLw78 Dw3szz3qjHMOarDUnl3O6pCsfJSTicHpPhEUmR37CYVx+LK1tkKPhXizA5SHksuxcQvD4/tDc 25uNHv3t2tQKTDVMAUSmpt8uNy2+I6f6Cvx5dv+qDLdu+unZ/oLGFhsLyE53BLONUTw3HJznn vTbr6x4wKIGlvWqFsIwSwnB0mk0aCYFE2WuGaqb0fhRAbOnS3YJa+IZeYrBG+q2XYvwjG2ehz UEq6YwD1jskxFpRzPayzyVQYCzMMjiPch2uwbAThJ9e/d6KPctD+JCFHx1BUn7I9t3stgmS+J /JNPVw3MCBvlhh+rh9Zd2Tx/k8ruvyHoMolxvn8ls7laVOdtwGdwqUnnBB1GpslI+jLL5D1eD nDxINhb3F1fdI0DPs9WFTGyc7gtEOv86QiQpXDaL72m7bgpy/aVPWQlFoMOC2Sxi3/jiXECwd oHMpClf3/3MoCuEMpUI4l0hg0dlO0sQGxBZiUgUSMJhN2/Wvu3c+xOofONTFEKq04+/ewZLs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125164 Archived-At: > Renaming of display-buffer-in-major-side-window broke which-key.el > > As the subject says. Maybe an alias is in order? > > I don't know if there are more cases like this. Hmm... all this is obviously my fault. As a matter of fact, I wasn't aware that side windows were anywhere used at all. The problem is that =E2=80=98display-buffer-in-major-side-window=E2=80=99= , which I renamed to =E2=80=98window--make-major-side-window=E2=80=99, actually is = an internal function which should not be used outside of window.el. With other words: If there is anything =E2=80=98window--make-major-side-window=E2=80= =99 does which =E2=80=98display-buffer-in-side-window=E2=80=99 doesn't, then I should fi= x that in the latter rather than exposing the side window internals. I added the author to the list of recipients. Maybe he can tell us more. If there's no other way, I'll obviously make the alias. Thanks for the report, martin