From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#49449: 28: TLS connection never gets to "open" stage Date: Sat, 10 Jul 2021 21:44:21 +0200 Message-ID: <580679E8-B94D-4B46-A0CB-CA52B9D535EB@acm.org> References: <87lf6h3nj0.fsf@gnus.org> <22155A42-4A01-4EF1-80BC-B9CDE31ED0B1@acm.org> <87o8bdt180.fsf@gnus.org> <875yxip21h.fsf@gnus.org> <875yxinm2e.fsf@gnus.org> <83sg0matjg.fsf@gnu.org> <6FC06816-48AF-4853-92A9-B0E6BA424533@acm.org> <83pmvqarua.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25273"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49449@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 10 21:45:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2Iub-0006Mi-NZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jul 2021 21:45:17 +0200 Original-Received: from localhost ([::1]:47678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2Iua-0008VP-7n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jul 2021 15:45:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2IuM-0008VG-NW for bug-gnu-emacs@gnu.org; Sat, 10 Jul 2021 15:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2IuM-0002sl-Ez for bug-gnu-emacs@gnu.org; Sat, 10 Jul 2021 15:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2IuM-00048m-Cm for bug-gnu-emacs@gnu.org; Sat, 10 Jul 2021 15:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jul 2021 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49449 X-GNU-PR-Package: emacs Original-Received: via spool by 49449-submit@debbugs.gnu.org id=B49449.162594626915863 (code B ref 49449); Sat, 10 Jul 2021 19:45:02 +0000 Original-Received: (at 49449) by debbugs.gnu.org; 10 Jul 2021 19:44:29 +0000 Original-Received: from localhost ([127.0.0.1]:33536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2Ito-00047m-Sa for submit@debbugs.gnu.org; Sat, 10 Jul 2021 15:44:29 -0400 Original-Received: from mail214c50.megamailservers.eu ([91.136.10.224]:57006 helo=mail193c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2Itm-00047d-UY for 49449@debbugs.gnu.org; Sat, 10 Jul 2021 15:44:28 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1625946264; bh=8nCQag0dZ5/pKsRvYm6yeQQE3W9MdUMAfEKj3IwVOMo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OFDGIhaAY7GGCIosSLRJQLmru+HD9QPkCcmf12m8BaYKfTD6eXEqVi+ByivxBd1P+ /+j2I0+Nyi+Mwde1ritRWwHGYcu7ui9WB6gjSQ0h2GTJ+BArKCealck8qdLnsD95yI QJ9hZYDrgLj1EpTWlNUJw7h01RvM2nZHWYuLz9h4= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 16AJiLAb021170; Sat, 10 Jul 2021 19:44:23 +0000 In-Reply-To: <83pmvqarua.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F19.60E9F898.0018, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=GJV27dFK c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=3GCg62y2ErdneZq37wYA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209772 Archived-At: 10 juli 2021 kl. 21.31 skrev Eli Zaretskii : > That's my question: why cannot the sentinel be called in this case? > what prevents it from being called? In the failing case, wait_reading_process_output calls = gnutls_try_handshake early on, which succeeds and this leads to = finish_after_tls_connection being called. Here, we have the condition else if ((fd_callback_info[p->outfd].flags & NON_BLOCKING_CONNECT_FD) = =3D=3D 0) which gates further progress, but this condition is false because the = flags have NON_BLOCKING_CONNECT_FD set. In the successful case, the first call to gnutls_try_handshake from = wait_reading_process_output fails because things haven't had the time to = be set up yet. This leads to a select being called on the socket for = writing (since it's in a nonblocking connect), and when ready, the = NON_BLOCKING_CONNECT_FD bit is cleared from the flags. This is a simplified view. The state is clearly more complex and things = need to be done in the proper order.