From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Tue, 2 Aug 2022 13:05:40 -0700 Message-ID: <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35341"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56896@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 02 22:06:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIy9e-000908-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 22:06:14 +0200 Original-Received: from localhost ([::1]:56738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIy9c-0008V5-Jx for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 16:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIy9T-0008TB-Cv for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 16:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIy9S-0003i8-DP for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 16:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIy9S-0000Xz-5F for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 16:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16594707512080 (code B ref 56896); Tue, 02 Aug 2022 20:06:02 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 2 Aug 2022 20:05:51 +0000 Original-Received: from localhost ([127.0.0.1]:45148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIy9H-0000XR-Aj for submit@debbugs.gnu.org; Tue, 02 Aug 2022 16:05:51 -0400 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:40874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIy9D-0000X0-RV for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 16:05:50 -0400 Original-Received: by mail-pj1-f49.google.com with SMTP id s5-20020a17090a13c500b001f4da9ffe5fso9414235pjf.5 for <56896@debbugs.gnu.org>; Tue, 02 Aug 2022 13:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=9GtjR5BHP2sGK1g5i1OqsXnlzNkl80z5f4h7qvXxQH0=; b=IbbcGrbR2mOMVsduCB0mQsX+6a1hKfNxW1LahjaU1KRWo+kjBesPiEYIJTP91vOxLU 7Zj2AVhNpHkRfhsvsob10QuEDdRjQcEfpaP7ACv0Am1kdXG/t8w3OYs4SG8rgkhsnOOZ mDAPyz/mN6UCFosdl8nS/81YLLEVFG9LbGQfZVcB94gQji4iegAn/Sz7RU5O/MpITIsc q6C4P6NVJku759Hpzm7opjQji6ZdDHcqSgtfVAQf3vJIqWzI6V5Td8j/TCBKi8UMLeqS Ld3num8kwi7Nb5PBEWDXJEm2jbU6i1THatoVF2FTZdAY+2Gi2L04DSMwuy4YFYkFIxKy cd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=9GtjR5BHP2sGK1g5i1OqsXnlzNkl80z5f4h7qvXxQH0=; b=oZ/E9W+aNfvpbXSvNv1LLSfW6as133BMz759v+NxdFD2295EyROzy28RKfrKaT96FA 5Isc/CbT6LHOhBV3YLxBEEYscKBnOuFXhxUsKwlZe8E7Ghj+HKbt3DPaLumLRkg/m4Zt z43+EHKup7mqnC2fyoV9NdNMAiF2fei4OSzUuezV8rNBk6hEdDsqnMz/3M8rA9is0dWv grWBZ/TdQg71Z1NMKEij7LRJuxQc+8V7sKmsjTJRh83yBwikuhsKBgzwA3bizY2PDIQm qLjvQ+05T6olqxgijiLIFSwj6rynEjtpPsfwbkZN7CWMSLf33swfU5kR0x9q9RhztgXh dggg== X-Gm-Message-State: ACgBeo3U3wAjZ/p0rfWPMODmkWXIdswHtYqJ1gXdOwGhudNSC4qxmWwe CCgeHzgFyMG7jp9Nwag1rLKXBthHElw= X-Google-Smtp-Source: AA6agR4lP7fQaVpR4RZMgPzuO1XugAdvc8RSBNiVPvlMxHeNTv6tZZ0qSt+mQTou2e6ukjSkFYeMaA== X-Received: by 2002:a17:902:8bc5:b0:16c:f48b:d5b5 with SMTP id r5-20020a1709028bc500b0016cf48bd5b5mr23390300plo.128.1659470741874; Tue, 02 Aug 2022 13:05:41 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id bt21-20020a17090af01500b001f1ea1152aasm8859856pjb.57.2022.08.02.13.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 13:05:41 -0700 (PDT) In-Reply-To: <83tu6u5u9r.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238582 Archived-At: On 8/2/2022 12:18 PM, Eli Zaretskii wrote: > Why not make the icon customizable, and offer several possible bitmaps > to chose from? Hardcoding a single icon will always annoy someone. Sure, we could make this customizable. What would be a good way to go about this? I see three options: 1) The status quo: users can already call (define-fringe-bitmap 'bookmark-fringe-bitmap ...) to make the icon whatever they like, though that obviously requires writing (or copy/pasting) Elisp. 2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for the mark (it currently takes a boolean). This would solve this immediate case, but not other similar cases. For example, what if a user wants to customize the fringe icons in diff-mode? 3) Provide a generic way to select what any fringe bitmap looks like. I'm not quite sure how this would be implemented, but it would then allow users to change the appearance of, say, the `left-curly-arrow' icon. (In the past, I've done this via (1) by just calling `define-fringe-bitmap' again.)