unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56896@debbugs.gnu.org
Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark
Date: Tue, 2 Aug 2022 13:05:40 -0700	[thread overview]
Message-ID: <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> (raw)
In-Reply-To: <83tu6u5u9r.fsf@gnu.org>

On 8/2/2022 12:18 PM, Eli Zaretskii wrote:
> Why not make the icon customizable, and offer several possible bitmaps
> to chose from?  Hardcoding a single icon will always annoy someone.

Sure, we could make this customizable. What would be a good way to go 
about this? I see three options:

1) The status quo: users can already call (define-fringe-bitmap 
'bookmark-fringe-bitmap ...) to make the icon whatever they like, though 
that obviously requires writing (or copy/pasting) Elisp.

2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for 
the mark (it currently takes a boolean). This would solve this immediate 
case, but not other similar cases. For example, what if a user wants to 
customize the fringe icons in diff-mode?

3) Provide a generic way to select what any fringe bitmap looks like. 
I'm not quite sure how this would be implemented, but it would then 
allow users to change the appearance of, say, the `left-curly-arrow' 
icon. (In the past, I've done this via (1) by just calling 
`define-fringe-bitmap' again.)





  reply	other threads:[~2022-08-02 20:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 19:13 bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Jim Porter
2022-08-02 19:18 ` Eli Zaretskii
2022-08-02 20:05   ` Jim Porter [this message]
2022-08-03  2:28     ` Eli Zaretskii
2022-08-04  3:24       ` Jim Porter
2022-08-04  6:53         ` Eli Zaretskii
2022-08-04  6:57           ` Lars Ingebrigtsen
2022-08-05  4:41           ` Jim Porter
2022-08-13 21:59             ` bug#56896: 29.0.50; [PATCHv3] " Jim Porter
2022-08-15  6:44               ` Lars Ingebrigtsen
2022-08-16  4:17                 ` Jim Porter
2022-08-21 16:23                 ` Juri Linkov
2022-08-02 20:10   ` bug#56896: 29.0.50; [PATCH] " Drew Adams
2022-08-03  2:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-03  2:42   ` Jim Porter
2022-08-03  4:31     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=56896@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).