From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Laimonas =?UTF-8?Q?V=C4=97bra?= Newsgroups: gmane.emacs.bugs Subject: bug#24439: ispell.el; cutom setting `ispell-library-directory'; patch Date: Thu, 15 Sep 2016 18:56:38 +0300 Message-ID: <57DAC4B6.9040204@yahoo.com> References: <57D9ACBB.8020908@yahoo.com> <837fad6w2e.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1473955460 23230 195.159.176.226 (15 Sep 2016 16:04:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Sep 2016 16:04:20 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 Cc: 24439@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 15 18:04:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkZ93-0005N8-FG for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Sep 2016 18:04:13 +0200 Original-Received: from localhost ([::1]:35793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkZ91-000693-Ip for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Sep 2016 12:04:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkZ2A-0000T8-IT for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 11:57:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkZ26-00005E-Eh for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 11:57:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkZ26-000059-Ba for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 11:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bkZ26-0007x9-3M for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2016 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Laimonas =?UTF-8?Q?V=C4=97bra?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2016 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24439-submit@debbugs.gnu.org id=B24439.147395501830517 (code B ref 24439); Thu, 15 Sep 2016 15:57:02 +0000 Original-Received: (at 24439) by debbugs.gnu.org; 15 Sep 2016 15:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:60686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkZ1w-0007us-IW for submit@debbugs.gnu.org; Thu, 15 Sep 2016 11:56:57 -0400 Original-Received: from nm29-vm4.bullet.mail.ne1.yahoo.com ([98.138.91.189]:56438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkZ1p-0007tK-8a for 24439@debbugs.gnu.org; Thu, 15 Sep 2016 11:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1473954999; bh=KMzfKp04QxuyQCrmaWo56L1kcSHE1lI94I9HLp7KUL0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=jMiG5ULrRXoefF0Ox5KsLiUYBYuGkEoh9SqHaU3fMSi8Cr0lFkiNmrFx+4naCGJQs0wDAXTeXwyPLFcWQP5qyisHa/PiYISvCe6Dj5rMURRXSsr8tHNd8n1LhlIcD0GOYHFdUrO/G4jQWeq05pH4a0tYLxB3znZLpdP0VTzPXFwTFZvUxTeN7JrySOpEWq3djkOqRffU0qWa6OFwA6qhPKJoaaX70vu17Fk1LXdXwKae4SkbI5k+eHuryZXqENyprUwEKBcexKT8TrDVDQuIkiQN4TYmJV4O/4Ye1cJAn9F5uRLZlccKH/ypLurPCK+/CerNfoBehsPUm+6Bdmw/pw== Original-Received: from [98.138.100.102] by nm29.bullet.mail.ne1.yahoo.com with NNFMP; 15 Sep 2016 15:56:39 -0000 Original-Received: from [98.138.84.37] by tm101.bullet.mail.ne1.yahoo.com with NNFMP; 15 Sep 2016 15:56:39 -0000 Original-Received: from [127.0.0.1] by smtp105.mail.ne1.yahoo.com with NNFMP; 15 Sep 2016 15:56:39 -0000 X-Yahoo-Newman-Id: 665257.33742.bm@smtp105.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: ciFu12MVM1nmau1R697Mg_Pm3BRCm1eqtw9erw_ys85SDxr 80prM2O4b4.BKSXb79Z.o2bRyIt0Pg.QkSZ0grtko70UKvcAnkaC79j3L80q kwimbIGLPu9PTorgitGGBdhk5OSviXqevCavH2pBz5xq0CczoV3AWCugh4Nh 77tWkneqCR_GNRc_j9oESviDrT8GWEsbU.8M8FZ4_XYmjtMZzRLrq30iFqZ3 8nI_myzG1cgwzmNOUrbeZ_NF7GVzcXDoY6XjogvH0.Vu.aYuvYhL.OQtBawg SWk134RcW8HCbCfwjDoYaS9goOutXVpoPtbMq16HvqvGz1hk6y0YF4EXBuIm LUBv7Jg7G1FwZxYYbCqT_BzfaJPhDSq6maoZg9.yCr8vqGXykjGkRxQ0LCqg FJxv9dqsWsdVddRCxy.dfFU4vjmo1a2ZjLjgcZc99YeznCJbIJXWB6vIQqpn 05Zs3vNSxemCTTTGLtmb9tj4fgvl4Mj8ckdVCF65WPU0x1zrQ1AIgaxO9mzN X4TL2tkZS7bcFiXJ2EVS3q_VvCoGOCCxKrmmXYATt61PijXShXWTr01rdJKj 1Xq1TPy15hZs_kzOm8QdLhlK_HMdqHL7baw-- X-Yahoo-SMTP: _HanV_GswBBF01DkIFVlggE60r.1.Ajy974h In-Reply-To: <837fad6w2e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123345 Archived-At: Eli Zaretskii wrote: >> From: Laimonas Vėbra >> Date: Wed, 14 Sep 2016 23:02:03 +0300 >> >> On Windows if one uses cygwin ispell, then one should fix ispell LIBDIR >> (which is not correct absolute path) relative to cygwin root by setting >> `ispell-library-directory'. Or one also might wish to use custom >> location of dictionaries. > > ispell-library-directory is not supposed to be customized by users, > it's an internal variable set and used by ispell.el. To change the > location of dictionaries, users are supposed to customize > ispell-local-dictionary-alist. Why can't you do that instead? I do understand, that it's internal variable, though it it useful (and i would say crucial) for customization. How am i suppose to customize `ispell-local-dictionary-alist'? AFAICS dictionaries, that are added there, are not visible to `ispell-change-dictionary', because `ispell-library-directory' points to a wrong directory, where `ispell-valid-dictionary-list' can't find them, so they are ommited. > That's not what I see. What I see is that ispell-library-directory is > set once whenever the ispell process is created, which happens only > once in a session, or when you change your ispell dictionary. So I Correct: once per session. But it is redundant either, because it is already set before in `ispell-set-spellchecker-params', which is called by ispell-(region word change-dictionary). > think this is completely justified, because the user could install > additional dictionaries before restarting ispell. IMHO, resetting `ispell-library-directory', once it is already set, without changing ispell-program-name is simply redundant. It is clear from logic in `ispell-set-spellchecker-params' (unless (eq ispell-last-program-name ispell-program-name) ...) How (re)setting `ispell-library-directory' helps user installing new dictionaries? It's `ispell-valid-dictionary-list' responsibility to do actual work, besides `ispell-library-directory' is already set (before launching ispell process) and is not supposed to be changed if user doesn't change 'ispell-program-name'. > If the suggestions above don't solve your problems, perhaps you could > write a batch file or a script which reported the library directory in > the format that ispell.el expects in a native Windows build of Emacs. > Or maybe you could switch to Hunspell or Aspell, which don't need > ispell-library-directory at all. A native Windows port of Hunspell is > available (and works very well for me). Thanks, i'll consider that, but currently i'm happy with `ispell-library-directory customization' and elisp that fixes it.