From: martin rudalics <rudalics@gmx.at>
To: Andreas Politz <politza@hochschule-trier.de>
Cc: 24213@debbugs.gnu.org
Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el
Date: Thu, 01 Sep 2016 09:40:04 +0200 [thread overview]
Message-ID: <57C7DB54.6000605@gmx.at> (raw)
In-Reply-To: <8760qg69q3.fsf@hochschule-trier.de>
> I finally got around to this. The changes in the following diff seem to
> be all clear cut cases, where the window is created by
> display-buffer/pop-to-buffer without any special window-handling logic
> attached. Let me know what you think.
Thank you.
> "Exit Finder mode.
> Delete the window and kill all Finder-related buffers."
Maybe we should say that we "Quit" the window and "kill the Finder
buffer" here.
> (interactive)
> - (ignore-errors (delete-window))
> + (quit-window)
> (let ((buf "*Finder*"))
> (and (get-buffer buf) (kill-buffer buf))))
How about using (quit-window t) right away as in the next case?
> diff --git a/lisp/image-dired.el b/lisp/image-dired.el
> index 67b023d..36f148b 100644
> --- a/lisp/image-dired.el
> +++ b/lisp/image-dired.el
> @@ -2445,13 +2445,9 @@ image-dired-gallery-generate
> (insert "</html>"))))
>
> (defun image-dired-kill-buffer-and-window ()
> - "Kill the current buffer and, if possible, also the window."
> + "Kill the current buffer and quit it's window."
"its" not "it's".
The remainder looks OK. If no-one objects, please provide a ChangeLog
entry and I'll install the changes.
Thanks again, martin
next prev parent reply other threads:[~2016-09-01 7:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 20:22 bug#24213: 25.1.50; Fishy use of delete-window in register.el Andreas Politz
2016-08-13 2:39 ` Leo Liu
2016-08-13 6:43 ` Andreas Politz
2016-08-13 8:25 ` martin rudalics
2016-08-13 12:44 ` npostavs
2016-08-13 12:51 ` Eli Zaretskii
2016-08-13 13:30 ` martin rudalics
2016-08-13 9:50 ` Leo Liu
2016-08-13 8:24 ` martin rudalics
2016-08-13 9:50 ` Leo Liu
2016-08-13 8:24 ` martin rudalics
2016-08-13 8:47 ` Andreas Politz
2016-08-13 10:03 ` martin rudalics
2016-08-31 19:04 ` Andreas Politz
2016-09-01 7:40 ` martin rudalics [this message]
2016-09-01 11:22 ` Andreas Politz
2016-09-01 12:57 ` martin rudalics
2019-09-29 14:58 ` Lars Ingebrigtsen
2019-10-13 3:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C7DB54.6000605@gmx.at \
--to=rudalics@gmx.at \
--cc=24213@debbugs.gnu.org \
--cc=politza@hochschule-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).